Re: Detecting libc in perf (was Re: perf tools build broken after v5.1-rc1)

2019-05-02 Thread Arnaldo Carvalho de Melo
Em Thu, May 02, 2019 at 09:55:26AM -0700, Vineet Gupta escreveu: > On 4/30/19 8:12 PM, Rich Felker wrote: > >>> What are you trying to achieve? I was just CC'd and I'm missing the > >>> context. > >> > >> Sorry I added you as a subject matter expert but didn't provide enough > >> context. > >> > >

Re: perf tools build broken after v5.1-rc1

2019-05-02 Thread Vineet Gupta
On 5/2/19 9:41 AM, Arnaldo Carvalho de Melo wrote: >> While this takes care of immediate issues, for the long term, are you open >> to idea >> of removing the header duplicity. > > In the beginning we used the kernel headers directly, then, acting on > advice/complaints from Linus about tooling br

Re: Detecting libc in perf (was Re: perf tools build broken after v5.1-rc1)

2019-05-02 Thread Vineet Gupta
On 4/30/19 8:12 PM, Rich Felker wrote: >>> What are you trying to achieve? I was just CC'd and I'm missing the >>> context. >> >> Sorry I added you as a subject matter expert but didn't provide enough >> context. >> >> The original issue [1] was perf failing to build on ARC due to perf tools >> n

Re: perf tools build broken after v5.1-rc1

2019-05-02 Thread Vineet Gupta
On 4/29/19 6:18 PM, Arnaldo Carvalho de Melo wrote: >>> >>> Auto-detecting system features: >>> ... dwarf: [ OFF ] >>> ...dwarf_getlocations: [ OFF ] >>> ... glibc: [ on ] >> >> Not related to current issue, this run uses a uClibc toolcha

Re: perf tools build broken after v5.1-rc1

2019-05-02 Thread Arnaldo Carvalho de Melo
Em Thu, May 02, 2019 at 04:09:43PM +, Vineet Gupta escreveu: > On 5/2/19 7:36 AM, Arnaldo Carvalho de Melo wrote: > > Em Wed, May 01, 2019 at 09:17:52PM +, Vineet Gupta escreveu: > >> On 5/1/19 1:41 PM, Arnaldo Carvalho de Melo wrote: > The 1a787fc5ba18ac7 commit copied over the change

Re: perf tools build broken after v5.1-rc1

2019-05-02 Thread Arnaldo Carvalho de Melo
Em Thu, May 02, 2019 at 10:36:18AM -0400, Arnaldo Carvalho de Melo escreveu: > Em Wed, May 01, 2019 at 09:17:52PM +, Vineet Gupta escreveu: > > On 5/1/19 1:41 PM, Arnaldo Carvalho de Melo wrote: > > >> The 1a787fc5ba18ac7 commit copied over the changes for arm64, but > > >> missed all the other

Re: perf tools build broken after v5.1-rc1

2019-05-02 Thread Vineet Gupta
On 5/2/19 7:36 AM, Arnaldo Carvalho de Melo wrote: > Em Wed, May 01, 2019 at 09:17:52PM +, Vineet Gupta escreveu: >> On 5/1/19 1:41 PM, Arnaldo Carvalho de Melo wrote: The 1a787fc5ba18ac7 commit copied over the changes for arm64, but missed all the other architectures changed in c8ce4

Re: perf tools build broken after v5.1-rc1

2019-05-02 Thread Arnaldo Carvalho de Melo
Em Wed, May 01, 2019 at 09:17:52PM +, Vineet Gupta escreveu: > On 5/1/19 1:41 PM, Arnaldo Carvalho de Melo wrote: > >> The 1a787fc5ba18ac7 commit copied over the changes for arm64, but > >> missed all the other architectures changed in c8ce48f06503 and the > >> related commits. > > Right, I hav

Re: perf tools build broken after v5.1-rc1

2019-05-01 Thread Vineet Gupta
On 5/1/19 1:41 PM, Arnaldo Carvalho de Melo wrote: >> The 1a787fc5ba18ac7 commit copied over the changes for arm64, but >> missed all the other architectures changed in c8ce48f06503 and the >> related commits. > Right, I have a patch copying the missing headers, and that fixed the > build with the

Re: perf tools build broken after v5.1-rc1

2019-05-01 Thread Arnaldo Carvalho de Melo
Em Tue, Apr 30, 2019 at 06:12:35PM +0200, Arnd Bergmann escreveu: > On Mon, Apr 29, 2019 at 7:17 PM Vineet Gupta > wrote: > > > > On 4/22/19 8:31 AM, Arnaldo Carvalho de Melo wrote: > > >> A quick fix for ARC will be to create our own version but I presume all > > >> existing > > >> arches using

Re: Detecting libc in perf (was Re: perf tools build broken after v5.1-rc1)

2019-04-30 Thread Rich Felker
On Tue, Apr 30, 2019 at 10:13:40AM -0700, Vineet Gupta wrote: > On 4/30/19 10:04 AM, Rich Felker wrote: > > On Tue, Apr 30, 2019 at 03:53:18PM +, Vineet Gupta wrote: > >> On 4/29/19 6:18 PM, Arnaldo Carvalho de Melo wrote: > > Auto-detecting system features: > > ...

Re: Detecting libc in perf (was Re: perf tools build broken after v5.1-rc1)

2019-04-30 Thread Vineet Gupta
On 4/30/19 10:04 AM, Rich Felker wrote: > On Tue, Apr 30, 2019 at 03:53:18PM +, Vineet Gupta wrote: >> On 4/29/19 6:18 PM, Arnaldo Carvalho de Melo wrote: > Auto-detecting system features: > ... dwarf: [ OFF ] > ...dwarf_getlocations: [ OFF ]

Re: Detecting libc in perf (was Re: perf tools build broken after v5.1-rc1)

2019-04-30 Thread Rich Felker
On Tue, Apr 30, 2019 at 03:53:18PM +, Vineet Gupta wrote: > On 4/29/19 6:18 PM, Arnaldo Carvalho de Melo wrote: > >>> Auto-detecting system features: > >>> ... dwarf: [ OFF ] > >>> ...dwarf_getlocations: [ OFF ] > >>> ... glibc: [ on

Re: perf tools build broken after v5.1-rc1

2019-04-30 Thread Arnd Bergmann
On Mon, Apr 29, 2019 at 7:17 PM Vineet Gupta wrote: > > On 4/22/19 8:31 AM, Arnaldo Carvalho de Melo wrote: > >> A quick fix for ARC will be to create our own version but I presume all > >> existing > >> arches using generic syscall abi are affected. Thoughts ? In lack of ideas > >> I'll > >> se

Detecting libc in perf (was Re: perf tools build broken after v5.1-rc1)

2019-04-30 Thread Vineet Gupta
On 4/29/19 6:18 PM, Arnaldo Carvalho de Melo wrote: >>> Auto-detecting system features: >>> ... dwarf: [ OFF ] >>> ...dwarf_getlocations: [ OFF ] >>> ... glibc: [ on ] >> Not related to current issue, this run uses a uClibc toolchain and

Re: perf tools build broken after v5.1-rc1

2019-04-29 Thread Arnaldo Carvalho de Melo
Em Mon, Apr 29, 2019 at 05:14:54PM +, Vineet Gupta escreveu: > On 4/25/19 2:48 PM, Arnaldo Carvalho de Melo wrote: > > Em Mon, Apr 22, 2019 at 12:20:27PM -0300, Arnaldo Carvalho de Melo escreveu: > >> Em Fri, Apr 19, 2019 at 04:32:58PM -0700, Vineet Gupta escreveu: > >>> When building perf for

Re: perf tools build broken after v5.1-rc1

2019-04-29 Thread Vineet Gupta
On 4/26/19 12:35 PM, Arnaldo Carvalho de Melo wrote: > Em Fri, Apr 26, 2019 at 04:28:34PM -0300, Arnaldo Carvalho de Melo escreveu: >> Em Thu, Apr 25, 2019 at 06:48:00PM -0300, Arnaldo Carvalho de Melo escreveu: >>> Em Mon, Apr 22, 2019 at 12:20:27PM -0300, Arnaldo Carvalho de Melo escreveu: E

Re: perf tools build broken after v5.1-rc1

2019-04-29 Thread Vineet Gupta
On 4/22/19 8:31 AM, Arnaldo Carvalho de Melo wrote: >> A quick fix for ARC will be to create our own version but I presume all >> existing >> arches using generic syscall abi are affected. Thoughts ? In lack of ideas >> I'll >> send out a patch for ARC. >> >> P.S. Why do we need the unistd.h dupl

Re: perf tools build broken after v5.1-rc1

2019-04-29 Thread Vineet Gupta
On 4/25/19 2:48 PM, Arnaldo Carvalho de Melo wrote: > Em Mon, Apr 22, 2019 at 12:20:27PM -0300, Arnaldo Carvalho de Melo escreveu: >> Em Fri, Apr 19, 2019 at 04:32:58PM -0700, Vineet Gupta escreveu: >>> When building perf for ARC (v5.1-rc2) I get the following >> >>> | In file included from bench

Re: perf tools build broken after v5.1-rc1

2019-04-26 Thread Arnaldo Carvalho de Melo
Em Fri, Apr 26, 2019 at 04:28:34PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Thu, Apr 25, 2019 at 06:48:00PM -0300, Arnaldo Carvalho de Melo escreveu: > > Em Mon, Apr 22, 2019 at 12:20:27PM -0300, Arnaldo Carvalho de Melo escreveu: > > > Em Fri, Apr 19, 2019 at 04:32:58PM -0700, Vineet Gupta e

Re: perf tools build broken after v5.1-rc1

2019-04-26 Thread Arnaldo Carvalho de Melo
Em Thu, Apr 25, 2019 at 06:48:00PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Mon, Apr 22, 2019 at 12:20:27PM -0300, Arnaldo Carvalho de Melo escreveu: > > Em Fri, Apr 19, 2019 at 04:32:58PM -0700, Vineet Gupta escreveu: > > > When building perf for ARC (v5.1-rc2) I get the following > > > >

Re: perf tools build broken after v5.1-rc1

2019-04-25 Thread Arnaldo Carvalho de Melo
Em Mon, Apr 22, 2019 at 12:20:27PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Fri, Apr 19, 2019 at 04:32:58PM -0700, Vineet Gupta escreveu: > > When building perf for ARC (v5.1-rc2) I get the following > > > | In file included from bench/futex-hash.c:26: > > | bench/futex.h: In function 'fute

Re: perf tools build broken after v5.1-rc1

2019-04-22 Thread Arnaldo Carvalho de Melo
Em Fri, Apr 19, 2019 at 04:32:58PM -0700, Vineet Gupta escreveu: > When building perf for ARC (v5.1-rc2) I get the following > | In file included from bench/futex-hash.c:26: > | bench/futex.h: In function 'futex_wait': > | bench/futex.h:37:10: error: 'SYS_futex' undeclared (first use in this > f

perf tools build broken after v5.1-rc1

2019-04-19 Thread Vineet Gupta
Hi, When building perf for ARC (v5.1-rc2) I get the following | In file included from bench/futex-hash.c:26: | bench/futex.h: In function 'futex_wait': | bench/futex.h:37:10: error: 'SYS_futex' undeclared (first use in this function); git bisect led to 1a787fc5ba18ac767e635c58d06a0b46876184e3 (