Re: [PATCH v7.1 07/13] ARC: Linux Syscall Interface

2020-07-07 Thread Vineet Gupta
On 7/7/20 2:32 PM, Joseph Myers wrote: > On Tue, 7 Jul 2020, Vineet Gupta via Libc-alpha wrote: > >>> Each implementation has it ows requirements so I can't really say if >>> a helper function does make sense for all of them. For pause >>> specifically we can even simplify to since all architectu

Re: [PATCH v7.1 07/13] ARC: Linux Syscall Interface

2020-07-07 Thread Joseph Myers
On Tue, 7 Jul 2020, Vineet Gupta via Libc-alpha wrote: > > Each implementation has it ows requirements so I can't really say if > > a helper function does make sense for all of them. For pause > > specifically we can even simplify to since all architectures have > > either ppoll or ppoll_time64:

Re: [PATCH v7.1 07/13] ARC: Linux Syscall Interface

2020-07-07 Thread Vineet Gupta
On 7/7/20 12:24 PM, Adhemerval Zanella via Libc-alpha wrote: > > > On 06/07/2020 22:25, Vineet Gupta wrote: >> On 7/6/20 6:20 AM, Adhemerval Zanella via Libc-alpha wrote: >> diff --git a/sysdeps/unix/sysv/linux/arc/clone.S >> b/sysdeps/unix/sysv/linux/arc/clone.S >> diff --git a

Re: [PATCH v7.1 07/13] ARC: Linux Syscall Interface

2020-07-07 Thread Adhemerval Zanella
On 06/07/2020 22:25, Vineet Gupta wrote: > On 7/6/20 6:20 AM, Adhemerval Zanella via Libc-alpha wrote: > diff --git a/sysdeps/unix/sysv/linux/arc/clone.S > b/sysdeps/unix/sysv/linux/arc/clone.S >>> > diff --git a/sysdeps/unix/sysv/linux/arc/fixup-asm-unistd.h > b/sysdeps/unix/s

Re: [PATCH v7.1 07/13] ARC: Linux Syscall Interface

2020-07-06 Thread Vineet Gupta
On 7/6/20 6:20 AM, Adhemerval Zanella via Libc-alpha wrote: diff --git a/sysdeps/unix/sysv/linux/arc/clone.S b/sysdeps/unix/sysv/linux/arc/clone.S >> diff --git a/sysdeps/unix/sysv/linux/arc/fixup-asm-unistd.h b/sysdeps/unix/sysv/linux/arc/fixup-asm-unistd.h >> + +/*

Re: [PATCH v7.1 07/13] ARC: Linux Syscall Interface

2020-07-06 Thread Adhemerval Zanella
On 04/07/2020 00:54, Vineet Gupta wrote: > On 7/2/20 7:47 PM, Adhemerval Zanella via Libc-alpha wrote: >> >> >> On 30/06/2020 21:08, Vineet Gupta via Libc-alpha wrote: >>> --- >>>Changes since v7: >>> - used long int (iso int) in sysdep.h/syscall_error for handling >>> registers >> >>

Re: [PATCH v7.1 07/13] ARC: Linux Syscall Interface

2020-07-03 Thread Vineet Gupta
On 7/2/20 7:47 PM, Adhemerval Zanella via Libc-alpha wrote: > > > On 30/06/2020 21:08, Vineet Gupta via Libc-alpha wrote: >> --- >>Changes since v7: >> - used long int (iso int) in sysdep.h/syscall_error for handling >> registers > > Patch looks ok, but I have question on the __NR_* un