Re: [PATCH v4 04/15] ARC: Thread Local Storage support

2020-03-25 Thread Vineet Gupta
On 3/25/20 6:57 PM, Joseph Myers wrote: > On Thu, 12 Mar 2020, Vineet Gupta via Libc-alpha wrote: > >> +-- Derive offsets relative to the thread register. >> +#define thread_offsetof(mem)(long)(offsetof(struct pthread, mem) - >> sizeof(struct pthread)) > > Missing spaces before '(' in ca

Re: [PATCH v4 04/15] ARC: Thread Local Storage support

2020-03-25 Thread Joseph Myers
On Thu, 12 Mar 2020, Vineet Gupta via Libc-alpha wrote: > +-- Derive offsets relative to the thread register. > +#define thread_offsetof(mem) (long)(offsetof(struct pthread, mem) - > sizeof(struct pthread)) Missing spaces before '(' in calls to offsetof and sizeof. > +TLS_TCB_SIZE