Re: [PATCH v3 6/8] x86/module: perpare module loading for ROX allocations of text

2024-09-11 Thread Mike Rapoport
On Mon, Sep 09, 2024 at 10:49:40AM -0400, Steven Rostedt wrote: > On Mon, 9 Sep 2024 17:34:48 +0300 > Mike Rapoport wrote: > > > > This is insane, just force BUILDTIME_MCOUNT_SORT > > > > The comment in ftrace.c says "... while mcount loc in modules can not be > > sorted at build time" > > >

Re: [PATCH v3 6/8] x86/module: perpare module loading for ROX allocations of text

2024-09-09 Thread Steven Rostedt
On Mon, 9 Sep 2024 17:34:48 +0300 Mike Rapoport wrote: > > This is insane, just force BUILDTIME_MCOUNT_SORT > > The comment in ftrace.c says "... while mcount loc in modules can not be > sorted at build time" > > I don't know enough about objtool, but I'd presume it's because the sorting > s

Re: [PATCH v3 6/8] x86/module: perpare module loading for ROX allocations of text

2024-09-09 Thread Mike Rapoport
On Mon, Sep 09, 2024 at 11:29:23AM +0200, Peter Zijlstra wrote: > On Mon, Sep 09, 2024 at 09:47:28AM +0300, Mike Rapoport wrote: > > diff --git a/arch/x86/kernel/ftrace.c b/arch/x86/kernel/ftrace.c > > index 8da0e66ca22d..563d9a890ce2 100644 > > --- a/arch/x86/kernel/ftrace.c > > +++ b/arch/x86/ker

Re: [PATCH v3 6/8] x86/module: perpare module loading for ROX allocations of text

2024-09-09 Thread Peter Zijlstra
On Mon, Sep 09, 2024 at 09:47:28AM +0300, Mike Rapoport wrote: > diff --git a/arch/x86/kernel/ftrace.c b/arch/x86/kernel/ftrace.c > index 8da0e66ca22d..563d9a890ce2 100644 > --- a/arch/x86/kernel/ftrace.c > +++ b/arch/x86/kernel/ftrace.c > @@ -654,4 +656,15 @@ void ftrace_graph_func(unsigned long