Re: [PATCH 2/5] iee754: prvoide gcc builtins based generic sqrt functions

2020-06-01 Thread Adhemerval Zanella
On 01/06/2020 15:12, Vineet Gupta wrote: > On 6/1/20 7:42 AM, Adhemerval Zanella via Libc-alpha wrote: >> You will need to move this definitions inside the !USE_SQRTF_BUILTIN >> to avoid defined by not used warnings. Current practice is to just >> open code the constants and let compiler optimi

Re: [PATCH 2/5] iee754: prvoide gcc builtins based generic sqrt functions

2020-06-01 Thread Vineet Gupta
On 6/1/20 7:42 AM, Adhemerval Zanella via Libc-alpha wrote: > You will need to move this definitions inside the !USE_SQRTF_BUILTIN > to avoid defined by not used warnings. Current practice is to just > open code the constants and let compiler optimize the constant pool: Won't it be better to keep

Re: [PATCH 2/5] iee754: prvoide gcc builtins based generic sqrt functions

2020-06-01 Thread Vineet Gupta
On 6/1/20 7:18 AM, Florian Weimer wrote: > There's a typo in commit subject: “prvoide”. oops sorry, fixed now. ___ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc

Re: [PATCH 2/5] iee754: prvoide gcc builtins based generic sqrt functions

2020-06-01 Thread Adhemerval Zanella
On 01/06/2020 11:13, Adhemerval Zanella wrote: > > > On 29/05/2020 23:00, Vineet Gupta wrote: > > LGTM, thanks. > > Reviewed-by: Adhemerval Zanella > >> --- >> sysdeps/generic/math-use-builtins.h | 3 +++ >> sysdeps/ieee754/dbl-64/e_sqrt.c | 6 ++ >> sysdeps/ieee754/flt-32/e_sqrt

Re: [PATCH 2/5] iee754: prvoide gcc builtins based generic sqrt functions

2020-06-01 Thread Florian Weimer
There's a typo in commit subject: “prvoide”. ___ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc

Re: [PATCH 2/5] iee754: prvoide gcc builtins based generic sqrt functions

2020-06-01 Thread Adhemerval Zanella
On 29/05/2020 23:00, Vineet Gupta wrote: LGTM, thanks. Reviewed-by: Adhemerval Zanella > --- > sysdeps/generic/math-use-builtins.h | 3 +++ > sysdeps/ieee754/dbl-64/e_sqrt.c | 6 ++ > sysdeps/ieee754/flt-32/e_sqrtf.c| 6 ++ > 3 files changed, 15 insertions(+) > > diff --gi