Re: [PATCH 09/18] ARC: mm: non-functional code cleanup ahead of 3 levels

2021-08-12 Thread Vineet Gupta
On 8/11/21 11:18 PM, Mike Rapoport wrote: On Wed, Aug 11, 2021 at 06:37:19PM -0700, Vineet Gupta wrote: On 8/11/21 5:31 AM, Mike Rapoport wrote: +/* + * For ARC, pgtable_t is not struct page *, but pte_t * (to avoid + * extraneous page_address() calculations) hence can't use + * use asm-generic

Re: [PATCH 09/18] ARC: mm: non-functional code cleanup ahead of 3 levels

2021-08-11 Thread Mike Rapoport
On Wed, Aug 11, 2021 at 06:37:19PM -0700, Vineet Gupta wrote: > On 8/11/21 5:31 AM, Mike Rapoport wrote: > > > +/* > > > + * For ARC, pgtable_t is not struct page *, but pte_t * (to avoid > > > + * extraneous page_address() calculations) hence can't use > > > + * use asm-generic/pgalloc.h which ass

Re: [PATCH 09/18] ARC: mm: non-functional code cleanup ahead of 3 levels

2021-08-11 Thread Vineet Gupta
On 8/11/21 5:31 AM, Mike Rapoport wrote: +/* + * For ARC, pgtable_t is not struct page *, but pte_t * (to avoid + * extraneous page_address() calculations) hence can't use + * use asm-generic/pgalloc.h which assumes it being struct page * + */ Another reason to leave ARC without asm-generic/pgal

Re: [PATCH 09/18] ARC: mm: non-functional code cleanup ahead of 3 levels

2021-08-11 Thread Mike Rapoport
On Tue, Aug 10, 2021 at 05:42:49PM -0700, Vineet Gupta wrote: > Signed-off-by: Vineet Gupta > --- > arch/arc/include/asm/page.h| 30 -- > arch/arc/include/asm/pgalloc.h | 7 ++- > 2 files changed, 22 insertions(+), 15 deletions(-) > > diff --git a/arch/arc/in