Re: ARC binutils init/fini (was Re: [PATCH 03/21] ARC: ABI Implementation)

2019-01-28 Thread Vineet Gupta
On 1/28/19 3:13 PM, Joseph Myers wrote: > This was discussed at length in the C-Sky discussion. In short: the > proper fix is to change that configure test to apply for cross compilation > as well, other than in the very limited case where it tries to run > something (but doing so is not approp

Re: ARC binutils init/fini (was Re: [PATCH 03/21] ARC: ABI Implementation)

2019-01-28 Thread Joseph Myers
On Mon, 28 Jan 2019, Vineet Gupta wrote: > In the failing case, the dsos are NOT getting the DT_INIT/DT_FINI > dynamic tags And they shouldn't be (they should have DT_INIT_ARRAY / DT_FINI_ARRAY instead). > (1). gcc config test failing (false alaram) > > | host-gcc-final-ab544139bfee/build/gcc

ARC binutils init/fini (was Re: [PATCH 03/21] ARC: ABI Implementation)

2019-01-28 Thread Vineet Gupta
On 12/18/18 3:09 PM, Joseph Myers wrote: >> diff --git a/sysdeps/arc/crti.S b/sysdeps/arc/crti.S > As a new port I think it would be best to use init_array in your Implies > file so you don't need these crti / crtn files, and make GCC generate > init_array / fini_array exclusively. (See RISC-V a

Re: [PATCH 03/21] ARC: ABI Implementation

2018-12-19 Thread Joseph Myers
On Wed, 19 Dec 2018, Vineet Gupta wrote: > On 12/19/18 9:40 AM, Joseph Myers wrote: > > Architecture maintainers need wiki accounts in any case (to post test > > results for their architectures during every release freeze period), so > > you should create an account and post its name so someone

Re: [PATCH 03/21] ARC: ABI Implementation

2018-12-19 Thread Vineet Gupta
On 12/19/18 9:40 AM, Joseph Myers wrote: > Architecture maintainers need wiki accounts in any case (to post test > results for their architectures during every release freeze period), so > you should create an account and post its name so someone can add it to > EditorGroup so you can edit. Cre

Re: [PATCH 03/21] ARC: ABI Implementation

2018-12-19 Thread Joseph Myers
On Tue, 18 Dec 2018, Vineet Gupta wrote: > P.S. Is there a lint file or are these style guidelines in wiki > somewhere. If not I can volunteer to capture them in a wiki/readme for > future port submissions. In addition to the GNU Coding Standards (which cover many things such as comment format

Re: [PATCH 03/21] ARC: ABI Implementation

2018-12-18 Thread Vineet Gupta
On 12/18/18 3:09 PM, Joseph Myers wrote: > On Tue, 18 Dec 2018, Vineet Gupta wrote: > >> +/* FLAG 1 is privilege mode only instruction, hence will crash any program >> */ > > Generally, throughout the port, make sure comments end ". " (full stop, > two spaces, end of comment). I won't remark

Re: [PATCH 03/21] ARC: ABI Implementation

2018-12-18 Thread Joseph Myers
On Tue, 18 Dec 2018, Vineet Gupta wrote: > +/* FLAG 1 is privilege mode only instruction, hence will crash any program */ Generally, throughout the port, make sure comments end ". " (full stop, two spaces, end of comment). I won't remark on other places with this formatting issue. > diff --g