Re: [PATCH v3 2/2] DW DMAC: add multi-block property to device tree

2016-11-22 Thread Vinod Koul
On Fri, Nov 18, 2016 at 09:33:13PM +0200, Andy Shevchenko wrote: > > @@ -1569,7 +1569,7 @@ int dw_dma_probe(struct dw_dma_chip *chip) > >   (dwc_params >> DWC_PARAMS_MBLK_EN & > > 0x1) == 0; > >   } else { > >   dwc->block_size = pdata->block_si

Re: [PATCH v3 2/2] DW DMAC: add multi-block property to device tree

2016-11-21 Thread Arnd Bergmann
On Friday, November 18, 2016 10:12:36 PM CET Eugeniy Paltsev wrote: > +- multi-block: Multi block transfers supported by hardware per AHB master. > + 0 (default): not supported, 1: supported. Please clarify that this is an array with one cell per master. My first thought was "why is this not a bo

Re: [PATCH v3 2/2] DW DMAC: add multi-block property to device tree

2016-11-18 Thread Andy Shevchenko
On Fri, 2016-11-18 at 22:12 +0300, Eugeniy Paltsev wrote: > Several versions of DW DMAC have multi block transfers hardware > support. Hardware support of multi block transfers is disabled > by default if we use DT to configure DMAC and software emulation > of multi block transfers used instead. >

[PATCH v3 2/2] DW DMAC: add multi-block property to device tree

2016-11-18 Thread Eugeniy Paltsev
Several versions of DW DMAC have multi block transfers hardware support. Hardware support of multi block transfers is disabled by default if we use DT to configure DMAC and software emulation of multi block transfers used instead. Add multi-block property, so it is possible to enable hardware multi