Re: [PATCH v2 2/4] iee754: provide gcc builtins based generic fma functions

2020-06-02 Thread Stefan Liebler
On 6/2/20 7:13 PM, Vineet Gupta wrote: > On 6/2/20 5:51 AM, Stefan Liebler via Libc-alpha wrote: >> #endif /* math-use-builtins.h */ >> Please also update the current architecture specific math-use-builtins.h >> file: sysdeps/s390/fpu/math-use-builtins.h >> Otherwise it will break build on s390x.

Re: [PATCH v2 2/4] iee754: provide gcc builtins based generic fma functions

2020-06-02 Thread Vineet Gupta
On 6/2/20 10:27 AM, Adhemerval Zanella via Libc-alpha wrote: >> I used commit f82996f815 "Use GCC builtins for round functions if desired" as >> starting point for my change. And seems it was not an ideal reference :-) as >> round >> has far fewer instances than fma. Indeed fma is present in ldbl-

Re: [PATCH v2 2/4] iee754: provide gcc builtins based generic fma functions

2020-06-02 Thread Adhemerval Zanella
On 01/06/2020 21:35, Vineet Gupta wrote: > --- > sysdeps/generic/math-use-builtins.h | 5 + > sysdeps/ieee754/dbl-64/s_fma.c | 6 ++ > sysdeps/ieee754/dbl-64/s_fmaf.c | 6 ++ > sysdeps/ieee754/float128/float128_private.h | 2 ++ > sysdeps/ieee754/ldb

Re: [PATCH v2 2/4] iee754: provide gcc builtins based generic fma functions

2020-06-02 Thread Vineet Gupta
On 6/2/20 5:51 AM, Stefan Liebler via Libc-alpha wrote: > #endif /* math-use-builtins.h */ > Please also update the current architecture specific math-use-builtins.h > file: sysdeps/s390/fpu/math-use-builtins.h > Otherwise it will break build on s390x. Done. >> diff --git a/sysdeps/ieee754/dbl-6

[PATCH v2 2/4] iee754: provide gcc builtins based generic fma functions

2020-06-01 Thread Vineet Gupta
--- sysdeps/generic/math-use-builtins.h | 5 + sysdeps/ieee754/dbl-64/s_fma.c | 6 ++ sysdeps/ieee754/dbl-64/s_fmaf.c | 6 ++ sysdeps/ieee754/float128/float128_private.h | 2 ++ sysdeps/ieee754/ldbl-128/s_fmal.c | 5 + 5 files changed, 24