Re: [PATCH v2] ieee754/dbl-64: Reduce the scope of temporary storage variables

2020-06-15 Thread Vineet Gupta
On 6/15/20 12:53 PM, Joseph Myers wrote: >> This analysis looks good me, although I can't voucher for Joseph. > This patch is OK. Pushed. Thx ! -Vineet ___ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman

Re: [PATCH v2] ieee754/dbl-64: Reduce the scope of temporary storage variables

2020-06-15 Thread Joseph Myers
On Mon, 15 Jun 2020, Adhemerval Zanella wrote: > >> Is this sufficient for comparison ? > > > > ping ! > > > > This analysis looks good me, although I can't voucher for Joseph. This patch is OK. -- Joseph S. Myers jos...@codesourcery.com ___ linux

Re: [PATCH v2] ieee754/dbl-64: Reduce the scope of temporary storage variables

2020-06-15 Thread Adhemerval Zanella
On 15/06/2020 16:09, Vineet Gupta via Libc-alpha wrote: > On 6/4/20 12:08 PM, Vineet Gupta via Libc-alpha wrote: >> On 6/2/20 1:31 PM, Vineet Gupta via Libc-alpha wrote: >>> On 6/2/20 11:16 AM, Joseph Myers wrote: On Mon, 1 Jun 2020, Vineet Gupta via Libc-alpha wrote: > Also as sug

Re: [PATCH v2] ieee754/dbl-64: Reduce the scope of temporary storage variables

2020-06-15 Thread Vineet Gupta
On 6/4/20 12:08 PM, Vineet Gupta via Libc-alpha wrote: > On 6/2/20 1:31 PM, Vineet Gupta via Libc-alpha wrote: >> On 6/2/20 11:16 AM, Joseph Myers wrote: >>> On Mon, 1 Jun 2020, Vineet Gupta via Libc-alpha wrote: >>> Also as suggested by Joseph [1] used --strip and compared the libs with

Re: [PATCH v2] ieee754/dbl-64: Reduce the scope of temporary storage variables

2020-06-04 Thread Vineet Gupta
On 6/2/20 1:31 PM, Vineet Gupta via Libc-alpha wrote: > On 6/2/20 11:16 AM, Joseph Myers wrote: >> On Mon, 1 Jun 2020, Vineet Gupta via Libc-alpha wrote: >> >>> Also as suggested by Joseph [1] used --strip and compared the libs with >>> and w/o patch and their sizes are exactly same (with gcc 9). >

Re: [PATCH v2] ieee754/dbl-64: Reduce the scope of temporary storage variables

2020-06-02 Thread Vineet Gupta
On 6/2/20 11:16 AM, Joseph Myers wrote: > On Mon, 1 Jun 2020, Vineet Gupta via Libc-alpha wrote: > >> Also as suggested by Joseph [1] used --strip and compared the libs with >> and w/o patch and their sizes are exactly same (with gcc 9). > > My suggestion was to compare the *contents* of the libr

Re: [PATCH v2] ieee754/dbl-64: Reduce the scope of temporary storage variables

2020-06-02 Thread Joseph Myers
On Mon, 1 Jun 2020, Vineet Gupta via Libc-alpha wrote: > Also as suggested by Joseph [1] used --strip and compared the libs with > and w/o patch and their sizes are exactly same (with gcc 9). My suggestion was to compare the *contents* of the libraries, not just their sizes. Either they should

[PATCH v2] ieee754/dbl-64: Reduce the scope of temporary storage variables

2020-06-01 Thread Vineet Gupta
This came to light when adding hard-flaot support to ARC glibc port without hardware sqrt support causing glibc build to fail: | ../sysdeps/ieee754/dbl-64/e_sqrt.c: In function '__ieee754_sqrt': | ../sysdeps/ieee754/dbl-64/e_sqrt.c:58:54: error: unused variable 'ty' [-Werror=unused-variable] |