Re: [PATCH V14] mm/debug: Add tests validating architecture page table helpers

2020-03-04 Thread Anshuman Khandual
On 03/05/2020 11:13 AM, Christophe Leroy wrote: > > > Le 05/03/2020 à 01:54, Anshuman Khandual a écrit : >> >> >> On 03/04/2020 04:59 PM, Qian Cai wrote: >>> >>> On Mar 4, 2020, at 1:49 AM, Christophe Leroy wrote: AFAIU, you are not taking an interrupt here. You are stuck

Re: [PATCH V14] mm/debug: Add tests validating architecture page table helpers

2020-03-04 Thread Christophe Leroy
Le 05/03/2020 à 01:54, Anshuman Khandual a écrit : On 03/04/2020 04:59 PM, Qian Cai wrote: On Mar 4, 2020, at 1:49 AM, Christophe Leroy wrote: AFAIU, you are not taking an interrupt here. You are stuck in the pte_update(), most likely due to nested locks. Try with LOCKDEP ? Not exact

Re: [PATCH V14] mm/debug: Add tests validating architecture page table helpers

2020-03-04 Thread Anshuman Khandual
On 03/04/2020 04:59 PM, Qian Cai wrote: > > >> On Mar 4, 2020, at 1:49 AM, Christophe Leroy wrote: >> >> AFAIU, you are not taking an interrupt here. You are stuck in the >> pte_update(), most likely due to nested locks. Try with LOCKDEP ? > > Not exactly sure what did you mean here, but th

Re: [PATCH V14] mm/debug: Add tests validating architecture page table helpers

2020-03-04 Thread Qian Cai
> On Mar 4, 2020, at 1:49 AM, Christophe Leroy wrote: > > AFAIU, you are not taking an interrupt here. You are stuck in the > pte_update(), most likely due to nested locks. Try with LOCKDEP ? Not exactly sure what did you mean here, but the kernel has all lockdep enabled and did not flag an

Re: [PATCH V14] mm/debug: Add tests validating architecture page table helpers

2020-03-03 Thread Christophe Leroy
Le 04/03/2020 à 02:39, Qian Cai a écrit : Below is slightly modified version of your change above and should still prevent the bug on powerpc. Will it be possible for you to re-test this ? Once confirmed, will send a patch enabling this test on powerpc64 keeping your authorship. Thank you.

Re: [PATCH V14] mm/debug: Add tests validating architecture page table helpers

2020-03-03 Thread Qian Cai
> Below is slightly modified version of your change above and should still > prevent the bug on powerpc. Will it be possible for you to re-test this > ? Once confirmed, will send a patch enabling this test on powerpc64 > keeping your authorship. Thank you. This works fine on radix MMU but I decid

Re: [PATCH V14] mm/debug: Add tests validating architecture page table helpers

2020-03-02 Thread Christophe Leroy
Le 02/03/2020 à 20:40, Qian Cai a écrit : On Wed, 2020-02-26 at 10:51 -0500, Qian Cai wrote: On Wed, 2020-02-26 at 15:45 +0100, Christophe Leroy wrote: Le 26/02/2020 à 15:09, Qian Cai a écrit : On Mon, 2020-02-17 at 08:47 +0530, Anshuman Khandual wrote: This adds tests which will validate

Re: [PATCH V14] mm/debug: Add tests validating architecture page table helpers

2020-03-02 Thread Anshuman Khandual
On 03/03/2020 01:10 AM, Qian Cai wrote: > On Wed, 2020-02-26 at 10:51 -0500, Qian Cai wrote: >> On Wed, 2020-02-26 at 15:45 +0100, Christophe Leroy wrote: >>> >>> Le 26/02/2020 à 15:09, Qian Cai a écrit : On Mon, 2020-02-17 at 08:47 +0530, Anshuman Khandual wrote: > This adds tests which

Re: [PATCH V14] mm/debug: Add tests validating architecture page table helpers

2020-03-02 Thread Qian Cai
On Wed, 2020-02-26 at 10:51 -0500, Qian Cai wrote: > On Wed, 2020-02-26 at 15:45 +0100, Christophe Leroy wrote: > > > > Le 26/02/2020 à 15:09, Qian Cai a écrit : > > > On Mon, 2020-02-17 at 08:47 +0530, Anshuman Khandual wrote: > > > > This adds tests which will validate architecture page table he

Re: [PATCH V14] mm/debug: Add tests validating architecture page table helpers

2020-02-26 Thread Anshuman Khandual
On 02/27/2020 09:33 AM, Andrew Morton wrote: > On Thu, 27 Feb 2020 08:04:05 +0530 Anshuman Khandual > wrote: > >>> Must be something wrong with the following in debug_vm_pgtable() >>> >>> paddr = __pa(&start_kernel); >>> >>> Is there any explaination why start_kernel() is not in linear mem

Re: [PATCH V14] mm/debug: Add tests validating architecture page table helpers

2020-02-26 Thread Andrew Morton
On Thu, 27 Feb 2020 08:04:05 +0530 Anshuman Khandual wrote: > > Must be something wrong with the following in debug_vm_pgtable() > > > > paddr = __pa(&start_kernel); > > > > Is there any explaination why start_kernel() is not in linear memory on > > ARM64 ? > > > Cc: + James Morse > >

Re: [PATCH V14] mm/debug: Add tests validating architecture page table helpers

2020-02-26 Thread Anshuman Khandual
On 02/26/2020 08:14 PM, Christophe Leroy wrote: > > > Le 26/02/2020 à 15:12, Qian Cai a écrit : >> On Wed, 2020-02-26 at 09:09 -0500, Qian Cai wrote: >>> On Mon, 2020-02-17 at 08:47 +0530, Anshuman Khandual wrote: >>> >>> How useful is this that straightly crash the powerpc? >> >> And then genera

Re: [PATCH V14] mm/debug: Add tests validating architecture page table helpers

2020-02-26 Thread Qian Cai
On Wed, 2020-02-26 at 15:45 +0100, Christophe Leroy wrote: > > Le 26/02/2020 à 15:09, Qian Cai a écrit : > > On Mon, 2020-02-17 at 08:47 +0530, Anshuman Khandual wrote: > > > This adds tests which will validate architecture page table helpers and > > > other accessors in their compliance with expe

Re: [PATCH V14] mm/debug: Add tests validating architecture page table helpers

2020-02-26 Thread Christophe Leroy
Le 26/02/2020 à 15:09, Qian Cai a écrit : On Mon, 2020-02-17 at 08:47 +0530, Anshuman Khandual wrote: This adds tests which will validate architecture page table helpers and other accessors in their compliance with expected generic MM semantics. This will help various architectures in validati

Re: [PATCH V14] mm/debug: Add tests validating architecture page table helpers

2020-02-26 Thread Christophe Leroy
Le 26/02/2020 à 15:12, Qian Cai a écrit : On Wed, 2020-02-26 at 09:09 -0500, Qian Cai wrote: On Mon, 2020-02-17 at 08:47 +0530, Anshuman Khandual wrote: How useful is this that straightly crash the powerpc? And then generate warnings on arm64, [  146.634626][T1] debug_vm_pgtable: debug

Re: [PATCH V14] mm/debug: Add tests validating architecture page table helpers

2020-02-26 Thread Qian Cai
On Wed, 2020-02-26 at 09:09 -0500, Qian Cai wrote: > On Mon, 2020-02-17 at 08:47 +0530, Anshuman Khandual wrote: > > This adds tests which will validate architecture page table helpers and > > other accessors in their compliance with expected generic MM semantics. > > This will help various archite

Re: [PATCH V14] mm/debug: Add tests validating architecture page table helpers

2020-02-26 Thread Qian Cai
On Mon, 2020-02-17 at 08:47 +0530, Anshuman Khandual wrote: > This adds tests which will validate architecture page table helpers and > other accessors in their compliance with expected generic MM semantics. > This will help various architectures in validating changes to existing > page table helpe

Re: [PATCH V14] mm/debug: Add tests validating architecture page table helpers

2020-02-23 Thread Anshuman Khandual
On 02/17/2020 08:47 AM, Anshuman Khandual wrote: > This adds a test validation for architecture exported page table helpers. > Patch adds basic transformation tests at various levels of the page table. > > This test was originally suggested by Catalin during arm64 THP migration > RFC discussion ea

[PATCH V14] mm/debug: Add tests validating architecture page table helpers

2020-02-16 Thread Anshuman Khandual
This adds tests which will validate architecture page table helpers and other accessors in their compliance with expected generic MM semantics. This will help various architectures in validating changes to existing page table helpers or addition of new ones. This test covers basic page table entry