Re: [PATCH 3/4 v7] ASoC: dwc: Add PIO PCM extension

2016-05-25 Thread Mark Brown
On Wed, May 25, 2016 at 11:49:12AM +0100, Jose Abreu wrote: > Ok, will do that. I noticed the last I2S patch that you merged > ("ASoC: dwc: Add helper functions to disable/enable irqs") is not > in for-next yet. Should I base my work on 'topic/dwc' branch? We are in the merge window. No new non-

Re: [PATCH 3/4 v7] ASoC: dwc: Add PIO PCM extension

2016-05-25 Thread Jose Abreu
Hi Mark, On 25-05-2016 11:18, Mark Brown wrote: > On Wed, May 25, 2016 at 11:11:47AM +0100, Jose Abreu wrote: > >> I think I will take the second option. Something like this: >> " >> ret = snd_dmaengine_pcm_register(...) >> if (ret == -EPROBE_DEFER) >> return ret; >> else >>

Re: [PATCH 3/4 v7] ASoC: dwc: Add PIO PCM extension

2016-05-25 Thread Mark Brown
On Wed, May 25, 2016 at 11:11:47AM +0100, Jose Abreu wrote: > I think I will take the second option. Something like this: > " > ret = snd_dmaengine_pcm_register(...) > if (ret == -EPROBE_DEFER) > return ret; > else > pio_register(...); > "? Sure. You should print a di

Re: [PATCH 3/4 v7] ASoC: dwc: Add PIO PCM extension

2016-05-25 Thread Jose Abreu
Hi Mark, On 24-05-2016 18:51, Mark Brown wrote: > On Tue, May 24, 2016 at 06:07:14PM +0100, Jose Abreu wrote: >> On 24-05-2016 17:41, Mark Brown wrote: > Please fix your mail client to word wrap within paragraphs at something > substantially less than 80 columns. Doing this makes your messages m

Re: [PATCH 3/4 v7] ASoC: dwc: Add PIO PCM extension

2016-05-24 Thread Mark Brown
On Tue, May 24, 2016 at 06:07:14PM +0100, Jose Abreu wrote: > On 24-05-2016 17:41, Mark Brown wrote: Please fix your mail client to word wrap within paragraphs at something substantially less than 80 columns. Doing this makes your messages much easier to read and reply to. > >>if (substream-

Re: [PATCH 3/4 v7] ASoC: dwc: Add PIO PCM extension

2016-05-24 Thread Jose Abreu
Hi Mark, Thanks for your comments. On 24-05-2016 17:41, Mark Brown wrote: > On Mon, May 23, 2016 at 11:02:24AM +0100, Jose Abreu wrote: > >> +config SND_DESIGNWARE_PCM >> +bool "PCM PIO extension for I2S driver" > Why can't this be built as a module? I can change but my intention was to make

Re: [PATCH 3/4 v7] ASoC: dwc: Add PIO PCM extension

2016-05-24 Thread Mark Brown
On Mon, May 23, 2016 at 11:02:24AM +0100, Jose Abreu wrote: > +config SND_DESIGNWARE_PCM > + bool "PCM PIO extension for I2S driver" Why can't this be built as a module? > + > + return irq_valid ? IRQ_HANDLED : IRQ_NONE; Please write a normal if statement, the ternery operator doesn't h

[PATCH 3/4 v7] ASoC: dwc: Add PIO PCM extension

2016-05-23 Thread Jose Abreu
A PCM extension was added to I2S driver so that audio samples are transferred using PIO mode. The PCM supports two channels @ 16 or 32 bits with rates 32k, 44.1k and 48k. Although the mainline I2S driver uses ALSA DMA engine the I2S controller can be built without DMA support, therefore this is t