Re: [PATCH 3/4] ARC: refactor arch/arc/mm/dma.c

2018-07-30 Thread Eugeniy Paltsev
On Thu, 2018-07-26 at 11:17 +0200, Christoph Hellwig wrote: > On Tue, Jul 24, 2018 at 01:10:00PM +0300, Eugeniy Paltsev wrote: > > Refactoring, no functional change intended. > > [snip] > > > > *dma_handle = paddr; > > > > + /* > > +* - A coherent buffer needs MMU mapping to enforce

Re: [PATCH 3/4] ARC: refactor arch/arc/mm/dma.c

2018-07-26 Thread Christoph Hellwig
On Tue, Jul 24, 2018 at 01:10:00PM +0300, Eugeniy Paltsev wrote: > Refactoring, no functional change intended. Might be worth explaining a bit why you are refactoring it (i.e. what is the benefit). > > Signed-off-by: Eugeniy Paltsev > --- > arch/arc/mm/dma.c | 28 ++-- >

[PATCH 3/4] ARC: refactor arch/arc/mm/dma.c

2018-07-24 Thread Eugeniy Paltsev
Refactoring, no functional change intended. Signed-off-by: Eugeniy Paltsev --- arch/arc/mm/dma.c | 28 ++-- 1 file changed, 10 insertions(+), 18 deletions(-) diff --git a/arch/arc/mm/dma.c b/arch/arc/mm/dma.c index b693818cd8e5..46584c7c2858 100644 --- a/arch/arc/mm/dma.