Re: [PATCH] testsuite fix: timezone: failing due to permissions in cross testing

2019-01-09 Thread Florian Weimer
* Joseph Myers: > On Tue, 18 Dec 2018, Florian Weimer wrote: > >> There are also some xtests that require root privileges, such as >> nptl/tst-setuid1. Building and testing as root is supported (but > > That looks like it ought to become a test using user namespaces (and so > not an xtest). Can

Re: [PATCH] testsuite fix: timezone: failing due to permissions in cross testing

2018-12-18 Thread Joseph Myers
On Tue, 18 Dec 2018, Florian Weimer wrote: > There are also some xtests that require root privileges, such as > nptl/tst-setuid1. Building and testing as root is supported (but That looks like it ought to become a test using user namespaces (and so not an xtest). > obviously not recommended un

Re: [PATCH] testsuite fix: timezone: failing due to permissions in cross testing

2018-12-18 Thread Vineet Gupta
On 12/17/18 3:25 PM, Joseph Myers wrote: > root should not be involved in running tests at all; all tests should run > as a normal user, the same one that owns the build directory, and thus all > files and directories in the build directory should be owned by that user. > (Some tests use user n

Re: [PATCH] testsuite fix: timezone: failing due to permissions in cross testing

2018-12-18 Thread Florian Weimer
* Joseph Myers: > On Mon, 17 Dec 2018, Vineet Gupta wrote: > >> timezone test driver "zic" creates testdata directory wuth umask 755, so >> only root owner/group has write permissions. However the buildroot > > root should not be involved in running tests at all; all tests should run > as a norma

Re: [PATCH] testsuite fix: timezone: failing due to permissions in cross testing

2018-12-17 Thread Joseph Myers
On Mon, 17 Dec 2018, Vineet Gupta wrote: > The setup is obviously is cross test, built using buildroot. The system is > minimal > with root allowed w/o password to enable tests to run quickly. > > On host I do the following which certainly involves root. > > | make test-wrapper='/scripts/cross-

Re: [PATCH] testsuite fix: timezone: failing due to permissions in cross testing

2018-12-17 Thread Vineet Gupta
On 12/17/18 3:25 PM, Joseph Myers wrote: > On Mon, 17 Dec 2018, Vineet Gupta wrote: > >> timezone test driver "zic" creates testdata directory wuth umask 755, so >> only root owner/group has write permissions. However the buildroot > root should not be involved in running tests at all; all tests s

Re: [PATCH] testsuite fix: timezone: failing due to permissions in cross testing

2018-12-17 Thread Joseph Myers
On Mon, 17 Dec 2018, Vineet Gupta wrote: > timezone test driver "zic" creates testdata directory wuth umask 755, so > only root owner/group has write permissions. However the buildroot root should not be involved in running tests at all; all tests should run as a normal user, the same one that o

Re: [PATCH] testsuite fix: timezone: failing due to permissions in cross testing

2018-12-17 Thread Vineet Gupta
On 12/17/18 3:17 PM, Paul Eggert wrote: > >>   #ifdef S_IRUSR >> -#define MKDIR_UMASK >> (S_IRUSR|S_IWUSR|S_IXUSR|S_IRGRP|S_IXGRP|S_IROTH|S_IXOTH) >> +#define MKDIR_UMASK >> (S_IRUSR|S_IWUSR|S_IXUSR|S_IRGRP|S_IWGRP|S_IXGRP|S_IROTH|S_IWOTH|S_IXOTH) >>   #else >>   #define MKDIR_UMASK 0755 >>   #en

Re: [PATCH] testsuite fix: timezone: failing due to permissions in cross testing

2018-12-17 Thread Paul Eggert
#ifdef S_IRUSR -#define MKDIR_UMASK (S_IRUSR|S_IWUSR|S_IXUSR|S_IRGRP|S_IXGRP|S_IROTH|S_IXOTH) +#define MKDIR_UMASK (S_IRUSR|S_IWUSR|S_IXUSR|S_IRGRP|S_IWGRP|S_IXGRP|S_IROTH|S_IWOTH|S_IXOTH) #else #define MKDIR_UMASK 0755 #endif The zic.c code is taken from upstream, and I'm loath to c

[PATCH] testsuite fix: timezone: failing due to permissions in cross testing

2018-12-17 Thread Vineet Gupta
timezone test driver "zic" creates testdata directory wuth umask 755, so only root owner/group has write permissions. However the buildroot system created has sshd as default user, so sh fails to write to test results in this folder. Work around by relaxing umask to 777 | /bin/sh: build/glibc-fa3

[PATCH] testsuite fix: timezone: failing due to permissions in cross testing

2018-12-17 Thread Vineet Gupta
timezone test driver "zic" creates testdata directory wuth umask 755, so only root owner/group has write permissions. However the buildroot system created has sshd as default user, so sh fails to write to test results in this folder. Work around by relaxing umask to 777 | /bin/sh: build/glibc-fa3