Re: [PATCH] drm: fb-helper: Validate requested pixel format against bpp

2018-10-03 Thread Daniel Vetter
On Wed, Oct 3, 2018 at 4:30 PM Eugeniy Paltsev wrote: > > On Wed, 2018-10-03 at 15:30 +0300, Ville Syrjälä wrote: > > On Wed, Oct 03, 2018 at 01:36:00PM +0200, Daniel Vetter wrote: > > > On Wed, Oct 3, 2018 at 1:05 PM Eugeniy Paltsev > > > wrote: > > > > > > > > Validate requested pixel format ag

Re: [PATCH] drm: fb-helper: Validate requested pixel format against bpp

2018-10-03 Thread Ville Syrjälä
On Wed, Oct 03, 2018 at 05:29:34PM +0200, Daniel Vetter wrote: > On Wed, Oct 3, 2018 at 4:30 PM Eugeniy Paltsev > wrote: > > > > On Wed, 2018-10-03 at 15:30 +0300, Ville Syrjälä wrote: > > > On Wed, Oct 03, 2018 at 01:36:00PM +0200, Daniel Vetter wrote: > > > > On Wed, Oct 3, 2018 at 1:05 PM Eugen

Re: [PATCH] drm: fb-helper: Validate requested pixel format against bpp

2018-10-03 Thread Eugeniy Paltsev
On Wed, 2018-10-03 at 15:30 +0300, Ville Syrjälä wrote: > On Wed, Oct 03, 2018 at 01:36:00PM +0200, Daniel Vetter wrote: > > On Wed, Oct 3, 2018 at 1:05 PM Eugeniy Paltsev > > wrote: > > > > > > Validate requested pixel format against bits_per_pixel to reject > > > invalid formats with subcompone

Re: [PATCH] drm: fb-helper: Validate requested pixel format against bpp

2018-10-03 Thread Ville Syrjälä
On Wed, Oct 03, 2018 at 01:36:00PM +0200, Daniel Vetter wrote: > On Wed, Oct 3, 2018 at 1:05 PM Eugeniy Paltsev > wrote: > > > > Validate requested pixel format against bits_per_pixel to reject > > invalid formats with subcomponents length sum is greater than requested > > bits_per_pixel. > > > >

Re: [PATCH] drm: fb-helper: Validate requested pixel format against bpp

2018-10-03 Thread Daniel Vetter
On Wed, Oct 3, 2018 at 1:05 PM Eugeniy Paltsev wrote: > > Validate requested pixel format against bits_per_pixel to reject > invalid formats with subcomponents length sum is greater than requested > bits_per_pixel. > > weston 5.0.0 with fbdev backend tries to set up an ARGB x8r8g8b8 pixel > format

[PATCH] drm: fb-helper: Validate requested pixel format against bpp

2018-10-03 Thread Eugeniy Paltsev
Validate requested pixel format against bits_per_pixel to reject invalid formats with subcomponents length sum is greater than requested bits_per_pixel. weston 5.0.0 with fbdev backend tries to set up an ARGB x8r8g8b8 pixel format without bits_per_pixel updating. So it can request x8r8g8b8 with 16