Re: [PATCH] Remove STATFS_IS_STATFS64 conditional as it is zero in all ports

2020-09-09 Thread Vineet Gupta
On 9/9/20 11:36 AM, Adhemerval Zanella via Libc-alpha wrote: > > > On 08/09/2020 23:48, Vineet Gupta via Libc-alpha wrote: >> From: Vineet Gupta >> >> This seems to be dead code, so remove it. > > It could be useful for a possible statfs/statfs64 consolidation, but indeed > it is dead code now.

Re: [PATCH] Remove STATFS_IS_STATFS64 conditional as it is zero in all ports

2020-09-09 Thread Adhemerval Zanella
On 08/09/2020 23:48, Vineet Gupta via Libc-alpha wrote: > From: Vineet Gupta > > This seems to be dead code, so remove it. It could be useful for a possible statfs/statfs64 consolidation, but indeed it is dead code now. LGTM, thanks. Reviewed-by: Adhemerval Zanella > --- > sysdeps/unix

[PATCH] Remove STATFS_IS_STATFS64 conditional as it is zero in all ports

2020-09-08 Thread Vineet Gupta
From: Vineet Gupta This seems to be dead code, so remove it. --- sysdeps/unix/sysv/linux/alpha/kernel_stat.h | 1 - sysdeps/unix/sysv/linux/fstatfs64.c | 14 -- sysdeps/unix/sysv/linux/generic/kernel_stat.h | 2 -- .../unix/sysv/linux/generic/wordsize-32/fst

Re: [PATCH] Remove STATFS_IS_STATFS64 conditional as it is zero in all ports

2020-06-19 Thread Vineet Gupta
On 2/19/20 12:51 AM, Andreas Schwab wrote: > I think STATFS_IS_STATFS64 should actually be set to 1 on all 64-bit > architectures execpt alpha? So I experimented with making it 1 on a few 64-bit arches (s390x, powerpc64) but don't see any cogen changes compared to master for those 2 atleast.

Re: [PATCH] Remove STATFS_IS_STATFS64 conditional as it is zero in all ports

2020-02-19 Thread Andreas Schwab
I think STATFS_IS_STATFS64 should actually be set to 1 on all 64-bit architectures execpt alpha? Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different." _

[PATCH] Remove STATFS_IS_STATFS64 conditional as it is zero in all ports

2020-02-18 Thread Vineet Gupta
Signed-off-by: Vineet Gupta --- sysdeps/unix/sysv/linux/alpha/kernel_stat.h | 1 - sysdeps/unix/sysv/linux/fstatfs64.c | 14 -- sysdeps/unix/sysv/linux/generic/kernel_stat.h | 2 -- .../unix/sysv/linux/generic/wordsize-32/fstatfs.c | 2 -- .../unix/sysv/linu