On 08/02/2018 12:08 AM, Alexey Brodkin wrote:
>> The fault handling is spaghetti mess of checks and more checks and has not
>> really
>> been touched since upstreaming. I need to clean it up and essentially
>> rewrite it
>> for v4.19
> So would you like me to send a re-spin with less changes as d
Hi Vineet,
On Wed, 2018-08-01 at 12:49 -0700, Vineet Gupta wrote:
> Hi Alexey,
>
> I was finally forced to revisit this for my glibc tst-tls3-malloc deadlock.
> And
> indeed with this change we don'tsee the deadlock. But see below..
>
>
> > @@ -139,12 +139,16 @@ void do_page_fault(unsigned lon
Hi Alexey,
I was finally forced to revisit this for my glibc tst-tls3-malloc deadlock. And
indeed with this change we don'tsee the deadlock. But see below..
> @@ -139,12 +139,16 @@ void do_page_fault(unsigned long address, struct
> pt_regs *regs)
>*/
> fault = handle_mm_fault(vma,
Hi Vineet,
On Fri, 2018-06-29 at 11:20 -0700, Alexey Brodkin wrote:
> This was triggered by investigation of a deadlock after OOM killer invocation,
> see [1] for more details.
>
> Looks like our handling of fatal signal in do_page_fault() has some issues:
>
> 1. We only want to do special (read
This was triggered by investigation of a deadlock after OOM killer invocation,
see [1] for more details.
Looks like our handling of fatal signal in do_page_fault() has some issues:
1. We only want to do special (read "early") handling of fatal signal
if handle_mm_fault() returned VM_FAULT_RETR
