RE: [PATCH] ARC: [hsdk] Use rgmii-id mode for ethernet phy

2019-05-15 Thread Alexey Brodkin
Hi Trent, [snip] > > Even though it's not immediately clear there's a TI PHY as there's > > no PHY node at all but see what we have in the bootlog: > > > NatSemi DP83865 stmmac-0:01: attached PHY driver [NatSemi DP83865] ... > > > > I guess I need to add PHY node and use suggested by you "rgmii-i

Re: [PATCH] ARC: [hsdk] Use rgmii-id mode for ethernet phy

2019-05-15 Thread Trent Piepho
@lists.infradead.org > > Subject: Re: [PATCH] ARC: [hsdk] Use rgmii-id mode for ethernet phy > > > > On Tue, 2019-05-14 at 18:22 +0000, Alexey Brodkin wrote: > > > > Subject: [PATCH] ARC: [hsdk] Use rgmii-id mode for ethernet phy > > > > > > > &

RE: [PATCH] ARC: [hsdk] Use rgmii-id mode for ethernet phy

2019-05-15 Thread Alexey Brodkin
Hi Trent, > -Original Message- > From: Trent Piepho > Sent: Tuesday, May 14, 2019 10:05 PM > To: Alexey Brodkin > Cc: vineet.gup...@synopsys.com; eugeniy.palt...@synopsys.com; > linux-snps-arc@lists.infradead.org > Subject: Re: [PATCH] ARC: [hsdk] Use rgmii-id

Re: [PATCH] ARC: [hsdk] Use rgmii-id mode for ethernet phy

2019-05-14 Thread Trent Piepho
On Tue, 2019-05-14 at 18:22 +, Alexey Brodkin wrote: > > Subject: [PATCH] ARC: [hsdk] Use rgmii-id mode for ethernet phy > > > > If internal delays are desired on the RGMII link, "rgmii-id" should be > > used as the phy-mode rather than "rgmii" .

RE: [PATCH] ARC: [hsdk] Use rgmii-id mode for ethernet phy

2019-05-14 Thread Alexey Brodkin
Hi Trent, > -Original Message- > From: Trent Piepho > Sent: Tuesday, May 14, 2019 8:40 PM > To: linux-snps-arc@lists.infradead.org > Cc: Trent Piepho ; Alexey Brodkin > ; Vineet Gupta > > Subject: [PATCH] ARC: [hsdk] Use rgmii-id mode for ethernet phy >

[PATCH] ARC: [hsdk] Use rgmii-id mode for ethernet phy

2019-05-14 Thread Trent Piepho
If internal delays are desired on the RGMII link, "rgmii-id" should be used as the phy-mode rather than "rgmii" . This dts has properties to set the delay values, but they are ignored. I suspect this is a mistake. While the driver should disable delay based on the current DT, it does not, and ins