Re: [PATCH v3] ARC: HSDK: improve reset driver

2018-10-17 Thread Philipp Zabel
On Wed, 2018-10-17 at 17:05 +0300, Eugeniy Paltsev wrote: > As for today HSDK reset driver implements only .reset() callback. > > In case of driver which implements one of standard > reset controller usage pattern > (call *_deassert() in probe(), call *_assert() in remove()) > that leads to inoper

Re: [PATCH v2] ARC: HSDK: improve reset driver

2018-10-17 Thread Philipp Zabel
Hi Eugeniy, On Wed, 2018-10-17 at 13:54 +, Eugeniy Paltsev wrote: [...] > > The documentation states that calling reset_control_assert "on an > > exclusive reset controller guarantees that the reset will be asserted." > > Since this is clearly not the case with this driver, it is appropriate >

Re: [PATCH v2] ARC: HSDK: improve reset driver

2018-10-12 Thread Philipp Zabel
Hi Eugeniy, thank you for the update. On Fri, 2018-09-28 at 19:28 +0300, Eugeniy Paltsev wrote: > As for today HSDK reset driver implements only > .reset() callback. > > In case of driver which implements one of standard > reset controller usage pattern > (call *_deassert() in probe(), call *_as

Re: [PATCH] ARC: HSDK: improve reset driver

2018-09-14 Thread Philipp Zabel
Hi Eugeniy, On Mon, 2018-08-27 at 17:38 +0300, Eugeniy Paltsev wrote: > As for today HSDK reset driver implements only > .reset() callback. > > In case of driver which implements one of standard > reset controller usage pattern > (call *_deassert() in probe(), call *_assert() in remove()) > that

Re: [PATCH v2] ARC: reset: introduce AXS10x reset driver

2017-10-04 Thread Philipp Zabel
Hi Vineet, On Mon, 2017-09-18 at 18:51 +0200, Philipp Zabel wrote: > > Will it be OK for you to apply the corresponding DT update for > > platform - that way  > > I don't have to keep track of when ur branch hits mainline etc. > > > > The chances of any ensu

Re: [PATCH] ARC: reset: remove the misleading v1 suffix all over

2017-09-28 Thread Philipp Zabel
Hi Vineet, On Wed, 2017-09-27 at 11:07 -0700, Vineet Gupta wrote: [...] > How/when do you plan to get his merged. Perhaps I can work with a non- > mutable branch from you to base my changes off of ? I have sent a pull request [1] for this stable tag: git://git.pengutronix.de/git/pza/linux.git ta

Re: [PATCH] reset: Restrict RESET_HSDK_V1 to ARC_SOC_HSDK or COMPILE_TEST

2017-09-21 Thread Philipp Zabel
Hi Geert, On Mon, 2017-09-11 at 14:22 +0200, Geert Uytterhoeven wrote: > The HSDK reset driver is only useful when building for an ARC HSDK > platform. > > While at it, drop the "default n", as that is the default. > > Fixes: e0be864f14240cb1 ("ARC: reset: introduce HSDKv1 reset driver") > Signe

Re: [PATCH v2] ARC: reset: introduce AXS10x reset driver

2017-09-18 Thread Philipp Zabel
Hi Vineet, On Mon, 2017-09-18 at 09:14 -0700, Vineet Gupta wrote: > Hi Philipp, > > On 09/18/2017 05:07 AM, Philipp Zabel wrote: > > On Thu, 2017-09-14 at 17:28 +0300, Eugeniy Paltsev wrote: > > > ARC AXS10x boards support custom IP-block which allows to control > &g

Re: [PATCH v2] ARC: reset: introduce AXS10x reset driver

2017-09-18 Thread Philipp Zabel
On Thu, 2017-09-14 at 17:28 +0300, Eugeniy Paltsev wrote: > ARC AXS10x boards support custom IP-block which allows to control > reset signals of selected peripherals. For example DW GMAC, etc... > This block is controlled via memory-mapped register (AKA CREG) which > represents up-to 32 reset lines

Re: [PATCH] ARC: reset: remove the misleading v1 suffix all over

2017-09-14 Thread Philipp Zabel
On Mon, 2017-09-11 at 09:33 -0700, Vineet Gupta wrote: > On 09/11/2017 03:28 AM, Philipp Zabel wrote: > > Hi Vineet, > > > > [added Eugeniy to Cc] > > > > On Thu, 2017-08-31 at 11:06 -0700, Vineet Gupta wrote: > > > There is no plan yet to do a v2

Re: [PATCH] ARC: reset: remove the misleading v1 suffix all over

2017-09-11 Thread Philipp Zabel
Hi Vineet, [added Eugeniy to Cc] On Thu, 2017-08-31 at 11:06 -0700, Vineet Gupta wrote: > There is no plan yet to do a v2 board. And even if we were to do it > only some IPs would actually change, so it be best to add suffixes at > that point, not now ! > > Cc: Philipp Zabel

Re: [PATCH] ARC: reset: introduce AXS10x reset driver

2017-09-11 Thread Philipp Zabel
Hi Eugeniy, On Thu, 2017-08-31 at 11:28 +, Eugeniy Paltsev wrote: > Hi Philipp, > > Do you have plans to add reset-simple driver into 4.14? > It would be nice to use it for AXS10x in 4.14. I've already sent the 4.14 pull request on August 18. I would like to add the simple driver for 4.15.

Re: [PATCH] ARC: reset: introduce AXS10x reset driver

2017-08-11 Thread Philipp Zabel
Hi Eugeniy, On Thu, 2017-08-10 at 19:41 +0300, Eugeniy Paltsev wrote: > ARC AXS10x boards support custom IP-block which allows to control > reset signals of selected peripherals. For example DW GMAC, etc... > This block is controlled via memory-mapped register (AKA CREG) which > represents up-to 3

Re: [PATCH v2] ARC: reset: introduce HSDKv1 reset driver

2017-07-20 Thread Philipp Zabel
On Wed, 2017-07-19 at 21:45 +0300, Eugeniy Paltsev wrote: > The HSDK v1 periphery IPs can be reset by accessing some registers > from the CGU block. > > The list of available reset lines is documented in the DT bindings. > > Signed-off-by: Eugeniy Paltsev > --- > Changes v1 -> v2: > - Remove de

Re: [PATCH] ARC: reset: introduce HSDKv1 reset driver

2017-07-19 Thread Philipp Zabel
Hi Eugeniy, On Wed, 2017-07-19 at 15:32 +, Eugeniy Paltsev wrote: > Hi Philipp, > > On Wed, 2017-07-19 at 17:07 +0200, Philipp Zabel wrote: > > On Tue, 2017-07-18 at 20:25 +0300, Eugeniy Paltsev wrote: > > > The HSDK v1 periphery IPs can be reset by accessing some

Re: [PATCH] ARC: reset: introduce HSDKv1 reset driver

2017-07-19 Thread Philipp Zabel
On Tue, 2017-07-18 at 20:25 +0300, Eugeniy Paltsev wrote: > The HSDK v1 periphery IPs can be reset by accessing some registers > from the CGU block. > > The list of available reset lines is documented in the DT bindings. > > Signed-off-by: Eugeniy Paltsev > --- > .../bindings/reset/snps,hsdk-v1