Re: [PATCH v3] Kernel selftests: Add check if TPM devices are supported

2020-05-22 Thread Petr Vorel
Hi, > TPM2 tests set uses /dev/tpm0 and /dev/tpmrm0 without check if they > are available. In case, when these devices are not available test > fails, but expected behaviour is skipped test. Reviewed-by: Petr Vorel Kind regards, Petr ___ l

Re: [PATCH v2] Kernel selftests: Add check if tpm devices are supported

2020-05-19 Thread Petr Vorel
> tpm2 tests set uses /dev/tpm0 and /dev/tpmrm0 without check if they > are available. In case, when these devices are not available test > fails, but expected behaviour is skipped test. > Signed-off-by: Nikita Sobolev OK, I see it was also reverted by Jarkko https://git.kernel.org/pub/scm/linux

Re: [PATCH v2] Kernel selftests: Add check if tpm devices are supported

2020-05-19 Thread Petr Vorel
Hi Nikita, > tpm2 tests set uses /dev/tpm0 and /dev/tpmrm0 without check if they > are available. In case, when these devices are not available test > fails, but expected behaviour is skipped test. > Signed-off-by: Nikita Sobolev Reviewed-by: Petr Vorel Thanks for v2, but I se

Re: [PATCH] Kernel selftests: Add check if tpm devices are supported

2020-05-18 Thread Petr Vorel
Hi Nikita, > tpm2 tests set uses /dev/tpm0 and /dev/tpmrm0 without check if they > are available. In case, when these devices are not available test > fails, but expected behaviour is test to be skipped. > Signed-off-by: Nikita Sobolev Good catch. Reviewed-by: Petr Vorel &g

Re: [PATCH v2] autodetect fts support and tests depending on it

2019-03-21 Thread Petr Vorel
Hi Vineet, > On 3/20/19 3:37 PM, Petr Vorel wrote: > >> +# controllers/cpuset/cpuset_lib/libcpuset.c uses fts > >> +# which may not be available/configured in the libc build > >> +ifndef HAVE_FTS_H > >> +FILTER_OUT_DIRS += cpuset > >> +endif &g

Re: [PATCH] auto filter aio tests of libc can't support aio

2019-03-20 Thread Petr Vorel
Hi Vineet, > uClibc-ng lacks libaio.h and thus LTP UCLIBC=1 builds need to filter > out aio tests which it currently doesn't. > FWIW the tests sources themselves use a slightly different guard > HAVE_LIBAIO (while autotool generate HAVE_LIBAIO_H). > Anyhow that seems pointless as aio tests should

Re: [LTP] [PATCH v2] autodetect fts support and tests depending on it

2019-03-20 Thread Petr Vorel
Hi Vineet, > > Signed-off-by: Vineet Gupta > > --- > > configure.ac | 1 + > > testcases/kernel/controllers/Makefile | 6 ++ > > 2 files changed, 7 insertions(+) > > diff --git a/configure.ac b/configure.ac > > index e002c248eab2..10b2f6b1e43b 100644 > > --- a/confi

Re: [PATCH v2] autodetect fts support and tests depending on it

2019-03-20 Thread Petr Vorel
Hi Vineet, > Signed-off-by: Vineet Gupta > --- > configure.ac | 1 + > testcases/kernel/controllers/Makefile | 6 ++ > 2 files changed, 7 insertions(+) > diff --git a/configure.ac b/configure.ac > index e002c248eab2..10b2f6b1e43b 100644 > --- a/configure.ac > +++ b/

Re: [LTP] [PATCH] cpuset: disable for UCLIBC

2019-03-18 Thread Petr Vorel
Hi Vineet, > >> libcpuset.c relies on FTS which is not enabled by default on uClibc. > >> Instead of needing to reconfigure, rebuild uClibc lets disable this test > >> for uClibc > > Which uClibc version are you using? > > Both uClibc and uclibc-ng has it [1] since 2011, version v0.9.32, in commit

Re: [LTP] [PATCH] cpuset: disable for UCLIBC

2019-03-14 Thread Petr Vorel
Hi Vineet, > libcpuset.c relies on FTS which is not enabled by default on uClibc. > Instead of needing to reconfigure, rebuild uClibc lets disable this test > for uClibc Which uClibc version are you using? Both uClibc and uclibc-ng has it [1] since 2011, version v0.9.32, in commit a4aa01c12 ("Adde