[PATCH v5] mm: Avoid unnecessary page fault retires on shared memory types

Ren Acked-by: Max Filippov Acked-by: Christian Borntraeger Acked-by: Michael Ellerman (powerpc) Acked-by: Catalin Marinas Reviewed-by: Alistair Popple Reviewed-by: Ingo Molnar Signed-off-by: Peter Xu --- v5: - Picked up a few more a-bs - For s390, further optimize gmap==NULL case [Heiko]

Re: [PATCH v4] mm: Avoid unnecessary page fault retires on shared memory types

On Mon, May 30, 2022 at 07:03:31PM +0200, Heiko Carstens wrote: > On Mon, May 30, 2022 at 12:00:52PM -0400, Peter Xu wrote: > > On Mon, May 30, 2022 at 11:52:54AM -0400, Peter Xu wrote: > > > On Mon, May 30, 2022 at 11:35:10AM +0200, Christian Borntraeger wrote: > > > &g

Re: [PATCH v4] mm: Avoid unnecessary page fault retires on shared memory types

On Mon, May 30, 2022 at 11:52:54AM -0400, Peter Xu wrote: > On Mon, May 30, 2022 at 11:35:10AM +0200, Christian Borntraeger wrote: > > > > > > Am 29.05.22 um 22:33 schrieb Heiko Carstens: > > [...] > > > > > > Guess the patch below on top

Re: [PATCH v4] mm: Avoid unnecessary page fault retires on shared memory types

mmap_read_lock(mm); > > + goto out_gmap; > > + } > > + goto out; > > Yes, that makes sense. With that > > Acked-by: Christian Borntraeger Looks sane, thanks Heiko, Christian. I'll cook another one. -- Peter Xu ___ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc

[PATCH v4] mm: Avoid unnecessary page fault retires on shared memory types

Acked-by: Max Filippov Reviewed-by: Alistair Popple Reviewed-by: Ingo Molnar Signed-off-by: Peter Xu --- v4: - Picked up a-bs and r-bs - Fix grammar in the comment of faultin_page() [Ingo] - Fix s390 for gmap since gmap needs the mmap lock [Heiko] v3: - Rebase to akpm/mm-unstable - Copy ar

Re: [PATCH v3] mm: Avoid unnecessary page fault retires on shared memory types

On Fri, May 27, 2022 at 12:46:31PM +0200, Ingo Molnar wrote: > > * Peter Xu wrote: > > > This patch provides a ~12% perf boost on my aarch64 test VM with a simple > > program sequentially dirtying 400MB shmem file being mmap()ed and these are > > the time it needs: &

Re: [PATCH v3] mm: Avoid unnecessary page fault retires on shared memory types

Hi, Heiko, On Fri, May 27, 2022 at 02:23:42PM +0200, Heiko Carstens wrote: > On Tue, May 24, 2022 at 07:45:31PM -0400, Peter Xu wrote: > > I observed that for each of the shared file-backed page faults, we're very > > likely to retry one more time for the 1st write fault

[PATCH v3] mm: Avoid unnecessary page fault retires on shared memory types

citly didn't touch hmm_vma_fault() and break_ksm() because they do not handle VM_FAULT_RETRY even with existing code, so I'm literally keeping them as-is. Signed-off-by: Peter Xu --- v3: - Rebase to akpm/mm-unstable - Copy arch maintainers --- arch/alpha/mm/fault.c | 4 +

[PATCH v5 03/25] mm/arc: Use general page fault accounting

Gupta CC: linux-snps-arc@lists.infradead.org Signed-off-by: Peter Xu --- arch/arc/mm/fault.c | 18 +++--- 1 file changed, 3 insertions(+), 15 deletions(-) diff --git a/arch/arc/mm/fault.c b/arch/arc/mm/fault.c index 587dea524e6b..f5657cb68e4f 100644 --- a/arch/arc/mm/fault.c +++ b

[PATCH v4 03/26] mm/arc: Use general page fault accounting

Gupta CC: linux-snps-arc@lists.infradead.org Signed-off-by: Peter Xu --- arch/arc/mm/fault.c | 18 +++--- 1 file changed, 3 insertions(+), 15 deletions(-) diff --git a/arch/arc/mm/fault.c b/arch/arc/mm/fault.c index 1b178dc147fd..5601dec319b5 100644 --- a/arch/arc/mm/fault.c +++ b

[PATCH 03/26] mm/arc: Use general page fault accounting

Gupta CC: linux-snps-arc@lists.infradead.org Signed-off-by: Peter Xu --- arch/arc/mm/fault.c | 18 +++--- 1 file changed, 3 insertions(+), 15 deletions(-) diff --git a/arch/arc/mm/fault.c b/arch/arc/mm/fault.c index 34380139e7a2..68e6849cf086 100644 --- a/arch/arc/mm/fault.c +++ b

[PATCH 03/26] mm/arc: Use general page fault accounting

Gupta CC: linux-snps-arc@lists.infradead.org Signed-off-by: Peter Xu --- arch/arc/mm/fault.c | 18 +++--- 1 file changed, 3 insertions(+), 15 deletions(-) diff --git a/arch/arc/mm/fault.c b/arch/arc/mm/fault.c index 34380139e7a2..68e6849cf086 100644 --- a/arch/arc/mm/fault.c +++ b

[PATCH 04/25] mm/arc: Use mm_fault_accounting()

@lists.infradead.org Signed-off-by: Peter Xu --- arch/arc/mm/fault.c | 15 +++ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git a/arch/arc/mm/fault.c b/arch/arc/mm/fault.c index 92b339c7adba..bc89d4b9c59d 100644 --- a/arch/arc/mm/fault.c +++ b/arch/arc/mm/fault.c @@ -72,6

Re: [PATCH RFC] mm: arc: fix potential double realease of mmap_sem

On Tue, Nov 06, 2018 at 12:48:31AM +, Vineet Gupta wrote: > On 10/31/18 8:24 PM, Peter Xu wrote: > > In do_page_fault() of ARC we have: > > > > ... > > fault = handle_mm_fault(vma, address, flags); > > > > /* If Pagefault was interru

[PATCH RFC] mm: arc: fix potential double realease of mmap_sem

To fix this, we only release the mmap_sem at [1] when we're sure we'll quit immediately (after we checked with user_mode(regs)). CC: Vineet Gupta CC: "Eric W. Biederman" CC: Peter Xu CC: Andrew Morton CC: Souptick Joarder CC: Andrea Arcangeli CC: linux-snps-arc@lists.inf