RE: [PATCH] ARC: guard dsp early init against non ARCv2

2020-04-28 Thread Jose Abreu
From: Eugeniy Paltsev Date: Apr/28/2020, 19:50:24 (UTC+00:00) > As of today we guard early DSP init code with > ARC_AUX_DSP_BUILD (0x7A) BCR check to verify that we have > CPU with DSP configured. However that's not enough as in > ARCv1 CPU the same BCR (0x7A) is used for checking MUL/MAC > instr

[PATCH net 0/4] net: stmmac: Fix selftests in Synopsys AXS101 board

2020-01-14 Thread Jose Abreu
in HW. 4) Fixes the Ethernet DT bindings for AXS101 board. --- Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Jose Abreu Cc: "David S. Miller" Cc: Maxime Coquelin Cc: net...@vger.kernel.org Cc: linux-st...@st-md-mailman.stormreply.com Cc: linux-arm-ker...@lists.infradead.org Cc:

[PATCH net 3/4] net: stmmac: selftests: Guard VLAN Perfect test against non supported HW

2020-01-14 Thread Jose Abreu
When HW does not support perfect filtering the feature will not be enabled in the net_device. Add a check for this to prevent failures. Fixes: 1b2250a04c1f ("net: stmmac: selftests: Add tests for VLAN Perfect Filtering") Signed-off-by: Jose Abreu --- Cc: Giuseppe Cavallaro Cc:

[PATCH net 1/4] net: stmmac: selftests: Make it work in Synopsys AXS101 boards

2020-01-14 Thread Jose Abreu
Synopsys AXS101 boards do not support unaligned memory loads or stores. Change the selftests mechanism to explicity: - Not add extra alignment in TX SKB - Use the unaligned version of ether_addr_equal() Fixes: 091810dbded9 ("net: stmmac: Introduce selftests support") Signed-off-by:

[PATCH net 4/4] ARC: [plat-axs10x]: Add missing multicast filter number to GMAC node

2020-01-14 Thread Jose Abreu
Add a missing property to GMAC node so that multicast filtering works correctly. Fixes: 556cc1c5f528 ("ARC: [axs101] Add support for AXS101 SDP (software development platform)") Signed-off-by: Jose Abreu --- Cc: Alexey Brodkin Cc: Rob Herring Cc: Mark Rutland Cc: Vineet Gupta C

[PATCH net 2/4] net: stmmac: selftests: Mark as fail when received VLAN ID != expected

2020-01-14 Thread Jose Abreu
When the VLAN ID does not match the expected one it means filter failed in HW. Fix it. Fixes: 94e18382003c ("net: stmmac: selftests: Add selftest for VLAN TX Offload") Signed-off-by: Jose Abreu --- Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Jose Abreu Cc: "David S. Mill

RE: [U-Boot] [RFC PATCH] net: designware: drop compatible altr, socfpga-stmmac

2019-09-04 Thread Jose Abreu
t given we don't have any special quirks implemented whatever > > > is the most generic DW GMAC compatible string is should be good for us. > > > > > > Joe, could you please suggest if we need to use just "st,stm32-dwmac" > > > or add our own compatible a

[PATCH 2/2] ARC: [plat-hsdk]: Add missing FIFO size entry in GMAC node

2019-05-20 Thread Jose Abreu
Add the binding for RX/TX fifo size of GMAC node. Signed-off-by: Jose Abreu Cc: Joao Pinto Cc: Rob Herring Cc: Mark Rutland Cc: Vineet Gupta Cc: Eugeniy Paltsev Cc: Alexey Brodkin --- arch/arc/boot/dts/hsdk.dts | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arc/boot/dts

[PATCH 0/2] ARC: [plat-hsdk]: GMAC DT Bindings Improvements

2019-05-20 Thread Jose Abreu
Add two missing bindings. Cc: Joao Pinto Cc: Rob Herring Cc: Mark Rutland Cc: Vineet Gupta Cc: Eugeniy Paltsev Cc: Alexey Brodkin Jose Abreu (2): ARC: [plat-hsdk]: Add missing multicast filter bins number to GMAC node ARC: [plat-hsdk]: Add missing FIFO size entry in GMAC node

[PATCH 1/2] ARC: [plat-hsdk]: Add missing multicast filter bins number to GMAC node

2019-05-20 Thread Jose Abreu
GMAC controller on HSDK boards supports 256 Hash Table size so we need to add the multicast filter bins property. This allows for the Hash filter to work properly using stmmac driver. Signed-off-by: Jose Abreu Cc: Joao Pinto Cc: Rob Herring Cc: Mark Rutland Cc: Vineet Gupta Cc: Eugeniy

RE: [PATCH] ARC: [plat-hsdk]: Add missing multicast filter bins number to GMAC node

2019-05-08 Thread Jose Abreu
From: Alexey Brodkin Date: Wed, May 08, 2019 at 11:46:36 > Could you please propose a patch? I couldn't yet find the exact FIFO size of the HW (it's not described in the documents I have). Do you have the values ? Thanks, Jose Miguel Abreu ___ linux-

RE: [PATCH] ARC: [plat-hsdk]: Add missing multicast filter bins number to GMAC node

2019-05-08 Thread Jose Abreu
From: Eugeniy Paltsev Date: Mon, May 06, 2019 at 19:19:20 > Hi, > > I'll check this in the next few days. > I also noticed that FIFO size entry is missing. DWMAC1000 does not support automatic FIFO size detection so this entry needs to be added. Thanks, Jose Miguel Abreu

[PATCH] ARC: [plat-hsdk]: Add missing multicast filter bins number to GMAC node

2019-05-02 Thread Jose Abreu
GMAC controller on HSDK boards supports 256 Hash Table size so we need to add the multicast filter bins property. This allows for the Hash filter to work properly using stmmac driver. Signed-off-by: Jose Abreu Cc: Joao Pinto Cc: Rob Herring Cc: Mark Rutland Cc: Vineet Gupta --- arch/arc

[PATCH v3] ARC: io.h: Implement reads{x}()/writes{x}()

2018-11-30 Thread Jose Abreu
is already aligned (David) - Remove 64 bit mention (Alexey) Signed-off-by: Jose Abreu Tested-by: Vitor Soares Cc: Vineet Gupta Cc: Alexey Brodkin Cc: Joao Pinto Cc: Vitor Soares Cc: David Laight --- arch/arc/include/asm/io.h | 67 +++ 1 file c

Re: [PATCH v2] ARC: io.h: Implement reads{x}()/writes{x}()

2018-11-30 Thread Jose Abreu
On 29-11-2018 21:20, Arnd Bergmann wrote: > On Thu, Nov 29, 2018 at 5:14 PM Jose Abreu wrote: > >> --->8-- >> static noinline void test_readsl(char *buf, int len) >> { >> readsl(0xdeadbeef, buf, len); >> } >> --->8--- >> >

Re: [PATCH v2] ARC: io.h: Implement reads{x}()/writes{x}()

2018-11-29 Thread Jose Abreu
On 29-11-2018 14:42, Jose Abreu wrote: > On 29-11-2018 14:38, David Laight wrote: >> From: Jose Abreu >>> Sent: 29 November 2018 14:29 >>> >>> Some ARC CPU's do not support unaligned loads/stores. Currently, generic >>> implementation of rea

Re: [PATCH v2] ARC: io.h: Implement reads{x}()/writes{x}()

2018-11-29 Thread Jose Abreu
On 29-11-2018 14:38, David Laight wrote: > From: Jose Abreu >> Sent: 29 November 2018 14:29 >> >> Some ARC CPU's do not support unaligned loads/stores. Currently, generic >> implementation of reads{b/w/l}()/writes{b/w/l}() is being used with ARC. >> This can

[PATCH v2] ARC: io.h: Implement reads{x}()/writes{x}()

2018-11-29 Thread Jose Abreu
e {get/put}_unaligned() helper instead of plain dereference of pointer in order to fix this. Changes from v1: - Check if buffer is already aligned (David) - Remove 64 bit mention (Alexey) Signed-off-by: Jose Abreu Tested-by: Vitor Soares Cc: Vineet Gupta Cc: Alexey Brodkin Cc: Joao Pinto Cc: Vitor

Re: [PATCH] ARC: io.h: Implement reads{x}()/writes{x}()

2018-11-29 Thread Jose Abreu
On 29-11-2018 13:11, Jose Abreu wrote >> I was thinking of the (probably likely) case where the pointer is >> actually aligned. >> An extra check for ((pointer) & 3) is almost certainly a 'win' >> over the byte accesses and shift/mask/or use by

Re: [PATCH] ARC: io.h: Implement reads{x}()/writes{x}()

2018-11-29 Thread Jose Abreu
On 29-11-2018 13:03, David Laight wrote: > From: Jose Abreu [mailto:jose.ab...@synopsys.com] >> On 29-11-2018 12:47, David Laight wrote: >>> From: Jose Abreu >>>> Sent: 29 November 2018 12:42 >>>> >>>> Some ARC CPU's do not support unalig

Re: [PATCH] ARC: io.h: Implement reads{x}()/writes{x}()

2018-11-29 Thread Jose Abreu
On 29-11-2018 12:47, David Laight wrote: > From: Jose Abreu >> Sent: 29 November 2018 12:42 >> >> Some ARC CPU's do not support unaligned loads/stores. Currently, generic >> implementation of reads{b/w/l}()/writes{b/w/l}() is being used with ARC. >> This can

[PATCH] ARC: io.h: Implement reads{x}()/writes{x}()

2018-11-29 Thread Jose Abreu
e {get/put}_unaligned() helper instead of plain dereference of pointer in order to fix this. We do not implement readsq()/writesq() as we assume that only HS is a 64 Bit CPU and that it supports unaligned loads/stores. Signed-off-by: Jose Abreu Tested-by: Vitor Soares Cc: Vineet Gupta Cc: Alexey B

Re: DRM_UDL and GPU under Xserver

2018-04-05 Thread Jose Abreu
Hi Alexey, Daniel, On 05-04-2018 10:32, Daniel Vetter wrote: > On Thu, Apr 5, 2018 at 9:16 AM, Alexey Brodkin > wrote: >> Hi Daniel, >> >> On Thu, 2018-04-05 at 08:18 +0200, Daniel Vetter wrote: >>> On Wed, Apr 4, 2018 at 10:06 PM, Alexey Brodkin >>> wrote: Hello, We're trying to

Re: xf86-video-armada via UDL [was: Re: UDL's fbdev doesn't work for user-space apps]

2017-12-05 Thread Jose Abreu
On 05-12-2017 11:53, Alexey Brodkin wrote: > > From my note above about udl_drm_gem_mmap() being only used in case of Xserver > I barely may conclude anything. Given my lack of knowledge of DRM guts > especially > when it comes to complicated cases with DMA buffer exports/imports I cannot > say >

Re: xf86-video-armada via UDL [was: Re: UDL's fbdev doesn't work for user-space apps]

2017-12-05 Thread Jose Abreu
Hi Alexey, On 04-12-2017 17:29, Alexey Brodkin wrote: > > Indeed, in case of kmscube etnaviv is a renderer while UDL > outputs the picture on the screen. Thats nice :) Ok, from your logs I was not able to see anything wrong. X server does not error exit and Prime seems to be working in DRM ...

Re: xf86-video-armada via UDL [was: Re: UDL's fbdev doesn't work for user-space apps]

2017-12-04 Thread Jose Abreu
On 04-12-2017 16:00, Alexey Brodkin wrote: > [30.763] (II) armada(0): etnaviv: Xv: using YUY2 format intermediate YUV > target > I'm wondering if this means that target format for UDL is YUV ... But anyway, I revisited your first email and noticed that you said kmscube runs fine. Is this usi

Re: xf86-video-armada via UDL [was: Re: UDL's fbdev doesn't work for user-space apps]

2017-12-04 Thread Jose Abreu
On 04-12-2017 14:53, Alexey Brodkin wrote: > Full log you may find below. Sorry but I meant /var/log/Xorg.0.log file. ___ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc

Re: xf86-video-armada via UDL [was: Re: UDL's fbdev doesn't work for user-space apps]

2017-12-04 Thread Jose Abreu
On 04-12-2017 13:16, Alexey Brodkin wrote: > Option "kmsdev" "/dev/dri/card1" Which drm driver uses /dev/dri/card0? I'm seing drmOpen code and if you don't specify the busID it will fallback for the first card that matches "armada-drm" or "imx-drm" or "udl". > But if I swap "imx-

Re: UDL's fbdev doesn't work for user-space apps

2017-12-04 Thread Jose Abreu
Hi Alexey, On 04-12-2017 11:32, Alexey Brodkin wrote: > My first [probably incorrect] assumption is Xserver requires fbdev (/dev/fbX) > and it cannot use DRI video card natively. Is that correct? > > Xserver can use DRI directly, you need to enable modesetting driver in Xorg config or use the des

Re: [PATCH] ARC: Memory barriers for everyone!

2017-10-12 Thread Jose Abreu
Hi Vineet, Ping! On 13-09-2017 12:24, Jose Abreu wrote: > By default __iormb() and __iowmb() translate into a do { } while(0) for > AXS10x platform. As ARC700 supports the sync op we can use the standard > memory barriers that are supplied by asm-generic headers. > > Signed-off

[PATCH] ARC: Memory barriers for everyone!

2017-09-13 Thread Jose Abreu
By default __iormb() and __iowmb() translate into a do { } while(0) for AXS10x platform. As ARC700 supports the sync op we can use the standard memory barriers that are supplied by asm-generic headers. Signed-off-by: Jose Abreu Cc: Vineet Gupta Cc: Alexey Brodkin Cc: Joao Pinto --- Hi Vineet

[PATCH v3] arc: Re-enable MMU upon a Machine Check exception

2017-09-01 Thread Jose Abreu
stacktracing of modules work when a machine check exception happens. Signed-off-by: Jose Abreu Cc: Vineet Gupta Cc: Alexey Brodkin Changes from v2: - Rephrased commit title and description Changes from v1: - Moved MMU re-enable to machine check exception handler --- arch/arc/kernel

Re: [PATCH v2] arc: Re-enable MMU upon die()

2017-09-01 Thread Jose Abreu
Oops, the commit title is now a little bit odd. Let me rephrase and send a new version. On 01-09-2017 17:00, Jose Abreu wrote: > I recently came upon a scenario where I would get a double fault > after a machine check error. It turns out that for Ksymbol lookup > to work with modules w

[PATCH v2] arc: Re-enable MMU upon die()

2017-09-01 Thread Jose Abreu
stacktrace making stacktracing of modules work upon a fatal exception. Signed-off-by: Jose Abreu Cc: Vineet Gupta Cc: Alexey Brodkin Changes from v1: - Moved MMU re-enable to machine check exception handler --- arch/arc/kernel/traps.c | 5 + 1 file changed, 5 insertions(+) diff --git a

Re: [PATCH] arc: Re-enable MMU upon die()

2017-09-01 Thread Jose Abreu
Hi Alexey, On 01-09-2017 12:48, Alexey Brodkin wrote: > Hi Jose, > > On Fri, 2017-09-01 at 12:39 +0100, Jose Abreu wrote: >> I recently came upon a scenario where I would get a double fault >> after a machine check error. It turns out that for Ksymbol lookup >> to w

[PATCH] arc: Re-enable MMU upon die()

2017-09-01 Thread Jose Abreu
stacktrace making stacktracing of modules work upon a fatal exception. Signed-off-by: Jose Abreu Cc: Vineet Gupta Cc: Alexey Brodkin --- arch/arc/kernel/traps.c | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/arc/kernel/traps.c b/arch/arc/kernel/traps.c index ff83e78..9533e06 100644

[PATCH] arc: Show fault information passed to show_kernel_fault_diag()

2017-08-29 Thread Jose Abreu
000 [ECR ]: 0x00200400 => Other Fatal Err -- Which can help debugging. Signed-off-by: Jose Abreu Cc: Vineet Gupta Cc: Alexey Brodkin --- arch/arc/kernel/troubleshoot.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arc/kernel/troubleshoot.c b/arch/arc/

Re: [RESEND PATCH 1/2] arc: axs10x: Add DT bindings for I2S audio playback

2017-04-27 Thread Jose Abreu
Hi Vineet, On 27-04-2017 00:31, Vineet Gupta wrote: > On 04/26/2017 01:55 AM, Jose Abreu wrote: >> Hi Vineet, >> >> >> On 24-04-2017 18:36, Vineet Gupta wrote: >>> On 04/21/2017 03:15 AM, Jose Abreu wrote: >>>> This patch adds the necessary DT bind

Re: [RESEND PATCH 1/2] arc: axs10x: Add DT bindings for I2S audio playback

2017-04-26 Thread Jose Abreu
Hi Vineet, On 24-04-2017 18:36, Vineet Gupta wrote: > On 04/21/2017 03:15 AM, Jose Abreu wrote: >> This patch adds the necessary DT bindings to get HDMI audio >> output in ARC AXS10x SDP. The bindings for I2S controller were >> added as well as the bindings for simple au

Re: [PATCH v3] clk/axs10x: introduce AXS10X pll driver

2017-04-21 Thread Jose Abreu
hat generate clock for the > following devices: > * ARC core on AXC CPU tiles. > * ARC PGU on ARC SDP Mainboard. > and more to come later. > > Acked-by: Rob Herring > Signed-off-by: Vlad Zakharov > Signed-off-by: Jose Abreu > Cc: Michael Turquette > Cc: Stephen Boyd &g

Re: [PATCH v2] clk/axs10x: introduce AXS10X pll driver

2017-04-03 Thread Jose Abreu
hat generate clock for the > following devices: > * ARC core on AXC CPU tiles. > * ARC PGU on ARC SDP Mainboard. > and more to come later. > > Acked-by: Rob Herring > Signed-off-by: Vlad Zakharov > Signed-off-by: Jose Abreu > Cc: Michael Turquette > Cc: Stephen

Re: DRM: Component framework API support

2017-03-30 Thread Jose Abreu
Hi Eugeniy, On 30-03-2017 13:05, Eugeniy Paltsev wrote: > Hi, > > I am trying to add support of new component framework API in ARC PGU driver. > The point is that for now we have ARC PGU driver which works with adv7511 > encoder. Both of them don't support component framework API. I had to add

Re: [PATCH 1/2] arc: axs10x: Add DT bindings for I2S audio playback

2017-03-29 Thread Jose Abreu
Hi Vineet, Rob, On 20-03-2017 14:02, Jose Abreu wrote: > Hi Vineet, Alexey, Rob, > > > On 02-03-2017 18:57, Alexey Brodkin wrote: >> Hi Jose, >> >> On Wed, 2017-02-22 at 18:19 +, Jose Abreu wrote: >>> This patch adds the necessary DT bindings to get

Re: [PATCH 1/2] arc: axs10x: Add DT bindings for I2S audio playback

2017-03-20 Thread Jose Abreu
Hi Vineet, Alexey, Rob, On 02-03-2017 18:57, Alexey Brodkin wrote: > Hi Jose, > > On Wed, 2017-02-22 at 18:19 +0000, Jose Abreu wrote: >> This patch adds the necessary DT bindings to get HDMI audio >> output in ARC AXS10x SDP. The bindings for I2S controller were >> ad

Re: [PATCH] drm/arcpgu: use .mode_fixup instead of .atomic_check

2017-03-06 Thread Jose Abreu
Hi Alexey, On 03-03-2017 19:24, Alexey Brodkin wrote: > > Correct. Otherwise we'll get some modes and devices that > don't work. > > Remember our saga with 74.25 vs 74.40 MHz? > > With our PLLs on AXS and HSDK boards we may generate 74.25 MHz clock > which satisfy some monitors especially those w

Re: [PATCH] drm/arcpgu: use .mode_fixup instead of .atomic_check

2017-03-03 Thread Jose Abreu
Hi Alexey, On 03-03-2017 13:27, Alexey Brodkin wrote: > > So if I understood you correct here what I really need is just to get rid of > existing check, > right? I.e. the following is to be in v2 respin: > --->8--- > diff --git a/drivers/gp

[PATCH 1/2] arc: axs10x: Add DT bindings for I2S audio playback

2017-02-22 Thread Jose Abreu
This patch adds the necessary DT bindings to get HDMI audio output in ARC AXS10x SDP. The bindings for I2S controller were added as well as the bindings for simple audio card. Signed-off-by: Jose Abreu Cc: Carlos Palminha Cc: Alexey Brodkin Cc: Rob Herring Cc: Vineet Gupta Cc: devicet

[PATCH 2/2] arc: axs10x: Fix ARC PGU default clock frequency

2017-02-22 Thread Jose Abreu
Default clock frequency for ARC PGU does not match any existing HDMI mode, instead the default value matches a DVI mode. Change the clock frequency to 74.25MHz so that it matches HDMI mode 1280x720@60Hz Signed-off-by: Jose Abreu Cc: Carlos Palminha Cc: Alexey Brodkin Cc: Rob Herring Cc

[PATCH 2/2 v9] ASoC: dwc: Add irq parameter to DOCUMENTATION

2016-06-09 Thread Jose Abreu
A parameter description for the interruptions of the I2S controller was added. Signed-off-by: Jose Abreu Acked-by: Rob Herring Cc: Carlos Palminha Cc: Mark Brown Cc: Liam Girdwood Cc: Jaroslav Kysela Cc: Takashi Iwai Cc: Rob Herring Cc: Alexey Brodkin Cc: linux-snps-arc

[PATCH 1/2 v9] ASoC: dwc: Add PIO PCM extension

2016-06-09 Thread Jose Abreu
the reason why this extension was added. Signed-off-by: Jose Abreu Cc: Carlos Palminha Cc: Mark Brown Cc: Liam Girdwood Cc: Jaroslav Kysela Cc: Takashi Iwai Cc: Rob Herring Cc: Alexey Brodkin Cc: linux-snps-arc@lists.infradead.org Cc: alsa-de...@alsa-project.org Cc: linux-ker

[PATCH 0/2 v9] Add I2S audio support for ARC AXS10x boards

2016-06-09 Thread Jose Abreu
gs entries (as suggested by Alexey Brodkin) Cc: Carlos Palminha Cc: Mark Brown Cc: Liam Girdwood Cc: Jaroslav Kysela Cc: Takashi Iwai Cc: Rob Herring Cc: Alexey Brodkin Cc: linux-snps-arc@lists.infradead.org Cc: alsa-de...@alsa-project.org Cc: linux-ker...@vger.kernel.org Jose Abreu (2):

[PATCH 1/2 v8] ASoC: dwc: Add PIO PCM extension

2016-05-30 Thread Jose Abreu
the reason why this extension was added. Signed-off-by: Jose Abreu Cc: Carlos Palminha Cc: Mark Brown Cc: Liam Girdwood Cc: Jaroslav Kysela Cc: Takashi Iwai Cc: Rob Herring Cc: Alexey Brodkin Cc: linux-snps-arc@lists.infradead.org Cc: alsa-de...@alsa-project.org Cc: linux-ker

[PATCH 2/2 v8] ASoC: dwc: Add irq parameter to DOCUMENTATION

2016-05-30 Thread Jose Abreu
A parameter description for the interruptions of the I2S controller was added. Signed-off-by: Jose Abreu Acked-by: Rob Herring Cc: Carlos Palminha Cc: Mark Brown Cc: Liam Girdwood Cc: Jaroslav Kysela Cc: Takashi Iwai Cc: Rob Herring Cc: Alexey Brodkin Cc: linux-snps-arc

[PATCH 0/2 v8] Add I2S audio support for ARC AXS10x boards

2016-05-30 Thread Jose Abreu
os Palminha Cc: Mark Brown Cc: Liam Girdwood Cc: Jaroslav Kysela Cc: Takashi Iwai Cc: Rob Herring Cc: Alexey Brodkin Cc: linux-snps-arc@lists.infradead.org Cc: alsa-de...@alsa-project.org Cc: linux-ker...@vger.kernel.org Jose Abreu (2): ASoC: dwc: Add PIO PCM extension ASoC: dwc:

Re: [PATCH 3/4 v7] ASoC: dwc: Add PIO PCM extension

2016-05-25 Thread Jose Abreu
Hi Mark, On 25-05-2016 11:18, Mark Brown wrote: > On Wed, May 25, 2016 at 11:11:47AM +0100, Jose Abreu wrote: > >> I think I will take the second option. Something like this: >> " >> ret = snd_dmaengine_pcm_register(...) >> if (ret == -EPROBE_DEFER)

Re: [PATCH 3/4 v7] ASoC: dwc: Add PIO PCM extension

2016-05-25 Thread Jose Abreu
Hi Mark, On 24-05-2016 18:51, Mark Brown wrote: > On Tue, May 24, 2016 at 06:07:14PM +0100, Jose Abreu wrote: >> On 24-05-2016 17:41, Mark Brown wrote: > Please fix your mail client to word wrap within paragraphs at something > substantially less than 80 columns. Doing this make

Re: [PATCH 3/4 v7] ASoC: dwc: Add PIO PCM extension

2016-05-24 Thread Jose Abreu
Hi Mark, Thanks for your comments. On 24-05-2016 17:41, Mark Brown wrote: > On Mon, May 23, 2016 at 11:02:24AM +0100, Jose Abreu wrote: > >> +config SND_DESIGNWARE_PCM >> +bool "PCM PIO extension for I2S driver" > Why can't this be built as a module?

[PATCH 2/4 v7] ASoC: dwc: Do not use devm_clk_get() if using platform data

2016-05-23 Thread Jose Abreu
When using platform data the devm_clk_get() function is called causing a probe failure if the clock is not declared. As we can pass the clock handler by platform data call only devm_clk_get() when platform data is not used. Signed-off-by: Jose Abreu Cc: Carlos Palminha Cc: Mark Brown Cc: Liam

[PATCH 0/4 v7] Add I2S audio support for ARC AXS10x boards

2016-05-23 Thread Jose Abreu
ad.org Cc: alsa-de...@alsa-project.org Cc: devicet...@vger.kernel.org Cc: linux-ker...@vger.kernel.org Jose Abreu (4): ASoC: dwc: Add helper functions to disable/enable irqs ASoC: dwc: Do not use devm_clk_get() if using platform data ASoC: dwc: Add PIO PCM extension ASoC: dwc: Ad

[PATCH 4/4 v7] ASoC: dwc: Add irq parameter to DOCUMENTATION

2016-05-23 Thread Jose Abreu
A parameter description for the interruptions of the I2S controller was added. This interrupt parameter should only be set when I2S does not have DMA support. Signed-off-by: Jose Abreu Cc: Carlos Palminha Cc: Mark Brown Cc: Liam Girdwood Cc: Jaroslav Kysela Cc: Takashi Iwai Cc: Rob Herring

[PATCH 3/4 v7] ASoC: dwc: Add PIO PCM extension

2016-05-23 Thread Jose Abreu
the reason why this extension was added. The selection between the use of DMA engine or PIO mode is detected by declaring or not the interrupt parameters in the DT and using Kconfig. Signed-off-by: Jose Abreu Cc: Carlos Palminha Cc: Mark Brown Cc: Liam Girdwood Cc: Jaroslav Kysela Cc: Takashi

[PATCH 1/4 v7] ASoC: dwc: Add helper functions to disable/enable irqs

2016-05-23 Thread Jose Abreu
Helper functions to disable and enable the I2S interrupts were added. Only the interrupts of the used channels are enabled. Also, there is no need to enable irqs at dw_i2s_config(), they are already enabled at startup. Signed-off-by: Jose Abreu Cc: Carlos Palminha Cc: Mark Brown Cc: Liam

Re: [RESEND PATCH 2/2 v6] arc: axs10x: Add DT bindings for I2S PLL Clock

2016-05-09 Thread Jose Abreu
Hi Vineet, On 02-05-2016 10:39, Jose Abreu wrote: > Add device tree bindings for AXS10X I2S PLL Clock driver. > > Signed-off-by: Jose Abreu > Acked-by: Alexey Brodkin > Acked-by: Vineet Gupta > --- > > Changes v5 -> v6: > * Added 'clocks' field > >

Re: [PATCH 1/2 v6] ASoC: dwc: Add custom PCM driver

2016-04-29 Thread Jose Abreu
, Jose Abreu wrote: > HDMI audio support was added to the AXS board using an > I2S cpu driver and a custom platform driver. > > The platform driver supports two channels @ 16 bits with > rates 32k, 44.1k and 48k. > > Although the mainline I2S driver uses ALSA DMA engine, > this

Re: [PATCH 2/2 v6] ASoC: dwc: Update DOCUMENTATION for I2S Driver

2016-04-27 Thread Jose Abreu
Hi Mark, Sorry. Follows bellow. On 27-04-2016 11:05, Jose Abreu wrote: > This patch updates documentation for the Designware I2S > driver. > > Signed-off-by: Jose Abreu > Acked-by: Rob Herring > Cc: Rob Herring > Cc: Carlos Palminha > Cc: Alexey Brodkin > Cc: devi

[PATCH 0/2 v6] Add I2S audio support for ARC AXS10x boards

2016-04-27 Thread Jose Abreu
c: Takashi Iwai Cc: Rob Herring Cc: Alexey Brodkin Cc: linux-snps-arc@lists.infradead.org Cc: alsa-de...@alsa-project.org Cc: devicet...@vger.kernel.org Cc: linux-ker...@vger.kernel.org Jose Abreu (2): ASoC: dwc: Add custom PCM driver ASoC: dwc: Update DOCUMENTATION for I2S Driver .../devi

[PATCH 2/2 v6] ASoC: dwc: Update DOCUMENTATION for I2S Driver

2016-04-27 Thread Jose Abreu
This patch updates documentation for the Designware I2S driver. Signed-off-by: Jose Abreu Acked-by: Rob Herring Cc: Rob Herring Cc: Carlos Palminha Cc: Alexey Brodkin Cc: devicet...@vger.kernel.org Cc: linux-snps-arc@lists.infradead.org Cc: alsa-de...@alsa-project.org Cc: linux-ker

[PATCH 1/2 v6] ASoC: dwc: Add custom PCM driver

2016-04-27 Thread Jose Abreu
necessary to add this custom platform driver so that HDMI audio works in AXS boards. The selection between the use of DMA engine or PIO mode is detected by declaring or not the DMA parameters in the device tree. Signed-off-by: Jose Abreu Cc: Carlos Palminha Cc: Mark Brown Cc: Liam Girdwood Cc

Re: [PATCH 1/2 v6] clk/axs10x: Add I2S PLL clock driver

2016-04-26 Thread Jose Abreu
2] https://marc.info/?l=devicetree&m=146126139521541&w=2 On 21-04-2016 18:55, Jose Abreu wrote: > Adding device tree mailing list and Rob Herring. > > On 21-04-2016 18:19, Jose Abreu wrote: >> The ARC SDP I2S clock can be programmed using a >> specific PLL. >> &

Re: [PATCH 2/2 v6] arc: axs10x: Add DT bindings for I2S PLL Clock

2016-04-21 Thread Jose Abreu
Adding device tree mailing list and Rob Herring. On 21-04-2016 18:19, Jose Abreu wrote: > Add device tree bindings for AXS10X I2S PLL Clock driver. > > Signed-off-by: Jose Abreu > --- > > Changes v5 -> v6: > * Added 'clocks' field > > This patch was only

Re: [PATCH 1/2 v6] clk/axs10x: Add I2S PLL clock driver

2016-04-21 Thread Jose Abreu
Adding device tree mailing list and Rob Herring. On 21-04-2016 18:19, Jose Abreu wrote: > The ARC SDP I2S clock can be programmed using a > specific PLL. > > This patch has the goal of adding a clock driver > that programs this PLL. > > At this moment the rate values are h

[PATCH 1/2 v6] clk/axs10x: Add I2S PLL clock driver

2016-04-21 Thread Jose Abreu
rate. Signed-off-by: Jose Abreu --- Changes v5 -> v6: * Use parent clock to determine PLL input rate instead of using hardcoded values * Documentation update (added 'clocks' field) Changes v4 -> v5: * Documentation update (as suggested by Alexey Brodkin) * Changed compatible

[PATCH 0/2 v6] Add AXS10X I2S PLL clock driver

2016-04-21 Thread Jose Abreu
sted by Vineet Gupta) Changes v2 -> v3: * Implemented recalc_rate Changes v1 -> v2: * Renamed folder to axs10x (as suggested by Alexey Brodkin) * Added more supported rates Jose Abreu (2): clk/axs10x: Add I2S PLL clock driver arc: axs10x: Add DT bindings for I2S PLL Clock .../binding

[PATCH 2/2 v6] arc: axs10x: Add DT bindings for I2S PLL Clock

2016-04-21 Thread Jose Abreu
Add device tree bindings for AXS10X I2S PLL Clock driver. Signed-off-by: Jose Abreu --- Changes v5 -> v6: * Added 'clocks' field This patch was only introduced in v5. arch/arc/boot/dts/axs10x_mb.dtsi | 13 + 1 file changed, 13 insertions(+) diff --git a/arch

Re: [RESEND PATCH v4] clk/axs10x: Add I2S PLL clock driver

2016-04-21 Thread Jose Abreu
Hi Alexey, On 21-04-2016 13:18, Alexey Brodkin wrote: > Hi Jose, > > On Thu, 2016-04-21 at 10:51 +0100, Jose Abreu wrote: >> Hi Alexey, > >>>>> Otherwise, I still prefer two DTS files for the two different FPGA >>>>> versions. At the least, pl

Re: [RESEND PATCH v4] clk/axs10x: Add I2S PLL clock driver

2016-04-21 Thread Jose Abreu
Hi Alexey, On 20-04-2016 17:12, Alexey Brodkin wrote: > Hi Jose, Stephen, > > On Wed, 2016-04-20 at 10:47 +0100, Jose Abreu wrote: >> Hi Stephen, >> >> >> On 20-04-2016 02:54, Stephen Boyd wrote: >>> On 04/19, Jose Abreu wrote: >>>> @Step

Re: [RESEND PATCH v4] clk/axs10x: Add I2S PLL clock driver

2016-04-20 Thread Jose Abreu
Hi Stephen, On 20-04-2016 02:54, Stephen Boyd wrote: > On 04/19, Jose Abreu wrote: >> @Stephen: can you give some input so that I can submit a v6? >> > I don't prefer putting the second register in the same DT node, > but that's really up to the DT reviewers

Re: [RESEND PATCH v4] clk/axs10x: Add I2S PLL clock driver

2016-04-19 Thread Jose Abreu
Hi Vineet, On 18-04-2016 12:49, Vineet Gupta wrote: > On Monday 18 April 2016 04:00 PM, Jose Abreu wrote: >>>> + if (readl((void *)FPGA_VER_INFO) <= FPGA_VER_27M) { >>>> Please don't readl directly from addresses. I think I mentioned >>>> that bef

Re: [RESEND PATCH v4] clk/axs10x: Add I2S PLL clock driver

2016-04-18 Thread Jose Abreu
Hi Stephen, On 16-04-2016 00:46, Stephen Boyd wrote: > On 04/11, Jose Abreu wrote: >> new file mode 100644 >> index 000..3ba4e2f >> --- /dev/null >> +++ b/drivers/clk/axs10x/i2s_pll_clock.c >> @@ -0,0 +1,217 @@ >> + >> +static int i

[PATCH 2/2 v5] ASoC: dwc: Update DOCUMENTATION for I2S Driver

2016-04-12 Thread Jose Abreu
This patch updates documentation for the Designware I2S driver. Signed-off-by: Jose Abreu --- Changes v4 -> v5: * interrupts is now required property * Drop 'snps-use-dmaengine' property This patch was only introduced in v4. Documentation/devicetree/bindings/sound/designwar

[PATCH 1/2 v5] ASoC: dwc: Add custom PCM driver

2016-04-12 Thread Jose Abreu
necessary to add this custom platform driver so that HDMI audio works in AXS boards. The selection between the use of DMA engine or PIO mode is detected by declaring or not the DMA parameters in the device tree. Signed-off-by: Jose Abreu --- Changes v4 -> v5: * Resolve undefined references w

[PATCH 0/2 v5] Add I2S/ADV7511 audio support for ARC AXS10x boards

2016-04-12 Thread Jose Abreu
te patch (as suggested by Alexey Brodkin) * Removed defconfigs entries (as suggested by Alexey Brodkin) NOTE: Although the mainline I2S driver uses ALSA DMA engine, this controller can be built without DMA support so it was necessary to add this custom platform driver so that HDMI audio works in A

[PATCH 2/2 v5] arc: axs10x: Add DT bindings for I2S PLL Clock

2016-04-12 Thread Jose Abreu
Add device tree bindings for AXS10X I2S PLL Clock driver. Signed-off-by: Jose Abreu --- This patch was only introduced in v5. arch/arc/boot/dts/axs10x_mb.dtsi | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arc/boot/dts/axs10x_mb.dtsi b/arch/arc/boot/dts/axs10x_mb.dtsi index

[PATCH 1/2 v5] clk/axs10x: Add I2S PLL clock driver

2016-04-12 Thread Jose Abreu
rate. Signed-off-by: Jose Abreu --- Changes v4 -> v5: * Documentation update (as suggested by Alexey Brodkin) * Changed compatible string to "snps,axs10x-i2s-pll-clock" (as suggested by Alexey Brodkin) Changes v3 -> v4: * Added binding document (as suggested by Stephen Boyd) *

[PATCH 0/2 v5] Add AXS10X I2S PLL clock driver

2016-04-12 Thread Jose Abreu
tform driver (as suggested by Stephen Boyd) * Use {readl/writel}_relaxed (as suggested by Vineet Gupta) Changes v2 -> v3: * Implemented recalc_rate Changes v1 -> v2: * Renamed folder to axs10x (as suggested by Alexey Brodkin) * Added more supported rates Jose Abreu (2): clk/axs10x: Ad

Re: [alsa-devel] [PATCH 2/5 v4] drm/i2c/adv7511: Add audio support

2016-04-11 Thread Jose Abreu
Hi Lars, On 11-04-2016 13:23, Lars-Peter Clausen wrote: > On 04/11/2016 01:32 PM, Jose Abreu wrote: >> Hi Lars, >> >> >> On 11-04-2016 10:33, Lars-Peter Clausen wrote: >>> On 04/11/2016 11:27 AM, Jose Abreu wrote: >>>> Hi Lars, >>>

Re: [alsa-devel] [PATCH 2/5 v4] drm/i2c/adv7511: Add audio support

2016-04-11 Thread Jose Abreu
Hi Lars, On 11-04-2016 10:33, Lars-Peter Clausen wrote: > On 04/11/2016 11:27 AM, Jose Abreu wrote: >> Hi Lars, >> >> >> On 09-04-2016 16:02, Lars-Peter Clausen wrote: >>> On 04/08/2016 06:12 PM, Jose Abreu wrote: >>> [...] >>>>> [...

Re: [alsa-devel] [PATCH 2/5 v4] drm/i2c/adv7511: Add audio support

2016-04-11 Thread Jose Abreu
Hi Lars, On 09-04-2016 16:02, Lars-Peter Clausen wrote: > On 04/08/2016 06:12 PM, Jose Abreu wrote: > [...] >>> [...] >>>> +- adi,enable-audio: If set the ADV7511 driver will register a codec >>>> interface >>>> + into ALSA SoC. >>>

Re: [alsa-devel] [PATCH 5/5 v4] ASoC: dwc: Update DOCUMENTATION for I2S Driver

2016-04-11 Thread Jose Abreu
Hi Lars, On 09-04-2016 15:55, Lars-Peter Clausen wrote: > On 04/08/2016 06:08 PM, Jose Abreu wrote: >> Hi Lars, >> >> >> On 08-04-2016 16:52, Lars-Peter Clausen wrote: >>> On 04/08/2016 12:06 PM, Jose Abreu wrote: >>>> Hi Mark, >>>> &

Re: [alsa-devel] [PATCH 2/5 v4] drm/i2c/adv7511: Add audio support

2016-04-08 Thread Jose Abreu
Hi Lars, On 08-04-2016 16:46, Lars-Peter Clausen wrote: > On 04/07/2016 06:53 PM, Jose Abreu wrote: >> This patch adds audio support for the ADV7511 HDMI transmitter >> using ALSA SoC. >> >> The code was ported from Analog Devices linux tree from >> commit 177

Re: [alsa-devel] [PATCH 5/5 v4] ASoC: dwc: Update DOCUMENTATION for I2S Driver

2016-04-08 Thread Jose Abreu
Hi Lars, On 08-04-2016 16:52, Lars-Peter Clausen wrote: > On 04/08/2016 12:06 PM, Jose Abreu wrote: >> Hi Mark, >> >> >> On 07-04-2016 18:53, Mark Brown wrote: >>> On Thu, Apr 07, 2016 at 05:53:59PM +0100, Jose Abreu wrote: >>> >>>> + Opt

Re: [alsa-devel] [PATCH 2/5 v4] drm/i2c/adv7511: Add audio support

2016-04-08 Thread Jose Abreu
Hi Lars, On 08-04-2016 16:46, Lars-Peter Clausen wrote: > On 04/07/2016 06:53 PM, Jose Abreu wrote: >> This patch adds audio support for the ADV7511 HDMI transmitter >> using ALSA SoC. >> >> The code was ported from Analog Devices linux tree from >> commit 177

Re: [PATCH 5/5 v4] ASoC: dwc: Update DOCUMENTATION for I2S Driver

2016-04-08 Thread Jose Abreu
Hi Mark, On 07-04-2016 18:53, Mark Brown wrote: > On Thu, Apr 07, 2016 at 05:53:59PM +0100, Jose Abreu wrote: > >> + Optional properties: >> + - snps,use-dmaengine: If set the driver will use ALSA DMA engine. If set >> + it is required to use the properties 'dma

[PATCH 5/5 v4] ASoC: dwc: Update DOCUMENTATION for I2S Driver

2016-04-07 Thread Jose Abreu
This patch updates documentation for the Designware I2S driver. Signed-off-by: Jose Abreu --- This patch was only introduced in v4. Documentation/devicetree/bindings/sound/designware-i2s.txt | 5 + 1 file changed, 5 insertions(+) diff --git a/Documentation/devicetree/bindings/sound

[PATCH 2/5 v4] drm/i2c/adv7511: Add audio support

2016-04-07 Thread Jose Abreu
alogdevicesinc/linux/ The audio can be disabled using menu-config and/or device tree so it is possible to use only video mode. The audio (when enabled) registers as a codec into ALSA. SPDIF DAI format was also added to ASoC as it is required by adv7511 audio. Signed-off-by: Jose Abreu ---

[PATCH 4/5 v4] ASoC: dwc: Add custom PCM driver

2016-04-07 Thread Jose Abreu
necessary to add this custom platform driver so that HDMI audio works in AXS boards. The selection between the use of DMA engine or custom PCM can be made using a device tree boolean parameter which was introduced in this patch ('snps,use-dmaengine'). Signed-off-by: Jose Abreu ---

[PATCH 1/5 v4] drm/i2c/adv7511: Rename and move to separate folder

2016-04-07 Thread Jose Abreu
adding of audio support. Signed-off-by: Jose Abreu --- No changes v3 -> v4. This patch was only introduced in v3. drivers/gpu/drm/i2c/Kconfig| 6 +--- drivers/gpu/drm/i2c/Makefile | 2 +- drivers/gpu/drm/i2c/adv7511/Kconfig|

[PATCH 3/5 v4] ASoC: dwc: Use fifo depth to program FCR

2016-04-07 Thread Jose Abreu
This patch makes Designware I2S driver use the fifo depth value to program the fifo configuration register instead of using hardcoded values. Signed-off-by: Jose Abreu --- This patch was only introduced in v4. sound/soc/dwc/designware_i2s.c | 9 +++-- 1 file changed, 7 insertions(+), 2

[PATCH 0/5 v4] Add I2S/ADV7511 audio support for ARC AXS10x boards

2016-04-07 Thread Jose Abreu
gested by Alexey Brodkin) * Removed defconfigs entries (as suggested by Alexey Brodkin) NOTE: Although the mainline I2S driver uses ALSA DMA engine, this controller can be built without DMA support so it was necessary to add this custom platform driver so that HDMI audio works in AXS boards. Jose

[PATCH 2/3 v3] drm/i2c/adv7511: Add audio support

2016-04-05 Thread Jose Abreu
alogdevicesinc/linux/ The audio can be disabled using menu-config so it is possible to use only video mode. The audio (when enabled) registers as a codec into ALSA. SPDIF DAI format was also added to ASoC as it is required by adv7511 audio. Signed-off-by: Jose Abreu --- .../bindings/display/br

  1   2   >