Re: [v3,17/19] arch/sparc: Implement fb_is_primary_device() in source file

2023-06-24 Thread Guenter Roeck
On 6/24/23 02:27, Arnd Bergmann wrote: On Sat, Jun 24, 2023, at 03:55, Guenter Roeck wrote: On Mon, Apr 17, 2023 at 02:56:49PM +0200, Thomas Zimmermann wrote: Other architectures implment fb_is_primary_device() in a source file. Do the same on sparc. No functional changes, but allows to

Re: [v3,17/19] arch/sparc: Implement fb_is_primary_device() in source file

2023-06-23 Thread Guenter Roeck
Hi, On Mon, Apr 17, 2023 at 02:56:49PM +0200, Thomas Zimmermann wrote: > Other architectures implment fb_is_primary_device() in a source > file. Do the same on sparc. No functional changes, but allows to > remove several include statement from . > > v2: > * don't include in header file >

Re: [PATCH v2 4/4] mm, arch: add generic implementation of pfn_valid() for FLATMEM

2023-02-12 Thread Guenter Roeck
On 2/12/23 17:26, Mike Rapoport wrote: On Sun, Feb 12, 2023 at 08:13:20AM -0800, Guenter Roeck wrote: On Sun, Jan 29, 2023 at 02:42:35PM +0200, Mike Rapoport wrote: From: "Mike Rapoport (IBM)" Every architecture that supports FLATMEM memory model defines its own version of pfn_va

Re: [PATCH v2 2/4] m68k: use asm-generic/memory_model.h for both MMU and !MMU

2023-02-12 Thread Guenter Roeck
On 2/12/23 17:15, Mike Rapoport wrote: Hi, On Sun, Feb 12, 2023 at 09:35:13AM -0800, Guenter Roeck wrote: Hi, On Sun, Jan 29, 2023 at 02:42:33PM +0200, Mike Rapoport wrote: From: "Mike Rapoport (IBM)" The MMU variant uses generic definitions of page_to_pfn() and pfn_to_page()

Re: [PATCH v2 4/4] mm, arch: add generic implementation of pfn_valid() for FLATMEM

2023-02-12 Thread Guenter Roeck
On 2/12/23 08:26, Mike Rapoport wrote: Hi Guenter, On Sun, Feb 12, 2023 at 08:13:20AM -0800, Guenter Roeck wrote: On Sun, Jan 29, 2023 at 02:42:35PM +0200, Mike Rapoport wrote: From: "Mike Rapoport (IBM)" Every architecture that supports FLATMEM memory model defines its own

Re: [PATCH v2 2/4] m68k: use asm-generic/memory_model.h for both MMU and !MMU

2023-02-12 Thread Guenter Roeck
Hi, On Sun, Jan 29, 2023 at 02:42:33PM +0200, Mike Rapoport wrote: > From: "Mike Rapoport (IBM)" > > The MMU variant uses generic definitions of page_to_pfn() and > pfn_to_page(), but !MMU defines them in include/asm/page_no.h for no > good reason. > > Include asm-generic/memory_model.h in the

Re: [PATCH v2 4/4] mm, arch: add generic implementation of pfn_valid() for FLATMEM

2023-02-12 Thread Guenter Roeck
On Sun, Jan 29, 2023 at 02:42:35PM +0200, Mike Rapoport wrote: > From: "Mike Rapoport (IBM)" > > Every architecture that supports FLATMEM memory model defines its own > version of pfn_valid() that essentially compares a pfn to max_mapnr. > > Use mips/powerpc version implemented as static inline

[PATCH] ARC: Fix CONFIG_STACKDEPOT

2021-07-10 Thread Guenter Roeck
ress this problem by adding IRQENTRY_TEXT and SOFTIRQENTRY_TEXT to the text segment, so do the same here. Signed-off-by: Guenter Roeck --- arch/arc/kernel/vmlinux.lds.S | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arc/kernel/vmlinux.lds.S b/arch/arc/kernel/vmlinux.lds.S index e21

Re: [PATCH 07/13] ia64: make SPARSEMEM default and disable DISCONTIGMEM

2020-12-12 Thread Guenter Roeck
On Tue, Oct 27, 2020 at 01:29:49PM +0200, Mike Rapoport wrote: > From: Mike Rapoport > > SPARSEMEM memory model suitable for systems with large holes in their > phyiscal memory layout. With SPARSEMEM_VMEMMAP enabled it provides > pfn_to_page() and page_to_pfn() as fast as FLATMEM. > > Make it th

Re: [PATCH] arch/{mips,sparc,microblaze,powerpc}: Don't enable pagefault/preempt twice

2020-06-04 Thread Guenter Roeck
On 6/3/20 11:22 PM, Ira Weiny wrote: [ ... ] > > s390: (does not compile) > > :1511:2: warning: #warning syscall clone3 not implemented [-Wcpp] > In file included from ./arch/sparc/include/asm/bug.h:6:0, > from ./include/linux/bug.h:5, > from ./include/linux/mmde

Re: [PATCH] arch/{mips,sparc,microblaze,powerpc}: Don't enable pagefault/preempt twice

2020-06-03 Thread Guenter Roeck
On 6/3/20 2:14 PM, Ira Weiny wrote: > On Wed, Jun 03, 2020 at 01:57:36PM -0700, Andrew Morton wrote: >> On Thu, 21 May 2020 10:42:50 -0700 Ira Weiny wrote: >> > > Actually it occurs to me that the patch consolidating kmap_prot is odd for > sparc 32 bit... > > Its a long shot bu

Re: [PATCH] arch/{mips,sparc,microblaze,powerpc}: Don't enable pagefault/preempt twice

2020-05-21 Thread Guenter Roeck
On Fri, May 22, 2020 at 02:35:23AM +0100, Al Viro wrote: > On Fri, May 22, 2020 at 02:29:50AM +0100, Al Viro wrote: > > On Thu, May 21, 2020 at 06:11:08PM -0700, Guenter Roeck wrote: > > > > > Mainline, with: > > > > > > qemu-system-sparc -M SS-4

Re: [PATCH] arch/{mips,sparc,microblaze,powerpc}: Don't enable pagefault/preempt twice

2020-05-21 Thread Guenter Roeck
On 5/21/20 5:46 PM, Al Viro wrote: > On Thu, May 21, 2020 at 11:46:12PM +0100, Al Viro wrote: >> On Thu, May 21, 2020 at 03:20:46PM -0700, Guenter Roeck wrote: >>> On 5/21/20 10:27 AM, Al Viro wrote: >>>> On Tue, May 19, 2020 at 09:54:22AM -0700, Guenter Roeck wrote:

Re: [PATCH] arch/{mips,sparc,microblaze,powerpc}: Don't enable pagefault/preempt twice

2020-05-21 Thread Guenter Roeck
On 5/21/20 10:42 AM, Ira Weiny wrote: > On Thu, May 21, 2020 at 09:05:41AM -0700, Guenter Roeck wrote: >> On 5/19/20 10:13 PM, Ira Weiny wrote: >>> On Tue, May 19, 2020 at 12:42:15PM -0700, Guenter Roeck wrote: >>>> On Tue, May 19, 2020 at 11:40:32AM -0700, Ira Wei

Re: [PATCH] arch/{mips,sparc,microblaze,powerpc}: Don't enable pagefault/preempt twice

2020-05-21 Thread Guenter Roeck
On 5/21/20 10:27 AM, Al Viro wrote: > On Tue, May 19, 2020 at 09:54:22AM -0700, Guenter Roeck wrote: >> On Mon, May 18, 2020 at 11:48:43AM -0700, ira.we...@intel.com wrote: >>> From: Ira Weiny >>> >>> The kunmap_atomic clean up failed to remove one set of page

Re: [PATCH] arch/{mips,sparc,microblaze,powerpc}: Don't enable pagefault/preempt twice

2020-05-21 Thread Guenter Roeck
On 5/19/20 10:13 PM, Ira Weiny wrote: > On Tue, May 19, 2020 at 12:42:15PM -0700, Guenter Roeck wrote: >> On Tue, May 19, 2020 at 11:40:32AM -0700, Ira Weiny wrote: >>> On Tue, May 19, 2020 at 09:54:22AM -0700, Guenter Roeck wrote: >>>> On Mon, May 18, 2020 at 11:48:4

Re: [PATCH] arch/{mips,sparc,microblaze,powerpc}: Don't enable pagefault/preempt twice

2020-05-19 Thread Guenter Roeck
On Tue, May 19, 2020 at 11:40:32AM -0700, Ira Weiny wrote: > On Tue, May 19, 2020 at 09:54:22AM -0700, Guenter Roeck wrote: > > On Mon, May 18, 2020 at 11:48:43AM -0700, ira.we...@intel.com wrote: > > > From: Ira Weiny > > > > > > The kunmap_atomic clean up f

Re: [PATCH] arch/{mips,sparc,microblaze,powerpc}: Don't enable pagefault/preempt twice

2020-05-19 Thread Guenter Roeck
On Mon, May 18, 2020 at 11:48:43AM -0700, ira.we...@intel.com wrote: > From: Ira Weiny > > The kunmap_atomic clean up failed to remove one set of pagefault/preempt > enables when vaddr is not in the fixmap. > > Fixes: bee2128a09e6 ("arch/kunmap_atomic: consolidate duplicate code") > Signed-off-b

Re: [PATCH V3 07/15] arch/kunmap_atomic: Consolidate duplicate code

2020-05-18 Thread Guenter Roeck
Hi Ira, On 5/18/20 5:03 PM, Ira Weiny wrote: > On Sun, May 17, 2020 at 09:29:32PM -0700, Guenter Roeck wrote: >> On Sun, May 17, 2020 at 08:49:39PM -0700, Ira Weiny wrote: >>> On Sat, May 16, 2020 at 03:33:06PM -0700, Guenter Roeck wrote: >>>> On Thu, May 07, 20

Re: [PATCH V3 07/15] arch/kunmap_atomic: Consolidate duplicate code

2020-05-18 Thread Guenter Roeck
On Sun, May 17, 2020 at 08:49:39PM -0700, Ira Weiny wrote: [ ... ] > > > > --- > > # bad: [bdecf38f228bcca73b31ada98b5b7ba1215eb9c9] Add linux-next specific > > files for 20200515 > > # good: [2ef96a5bb12be62ef75b5828c0aab838ebb29cb8] Linux 5.7-rc5 > > git bisect start 'HEAD' 'v5.7-rc5' > > # g

Re: [PATCH V3 07/15] arch/kunmap_atomic: Consolidate duplicate code

2020-05-17 Thread Guenter Roeck
On Sun, May 17, 2020 at 08:49:39PM -0700, Ira Weiny wrote: > On Sat, May 16, 2020 at 03:33:06PM -0700, Guenter Roeck wrote: > > On Thu, May 07, 2020 at 07:59:55AM -0700, ira.we...@intel.com wrote: > > > From: Ira Weiny > > > > > > Every single architectu

Re: [PATCH V3 10/15] arch/kmap: Define kmap_atomic_prot() for all arch's

2020-05-17 Thread Guenter Roeck
Hi, On Thu, May 07, 2020 at 07:59:58AM -0700, ira.we...@intel.com wrote: > From: Ira Weiny > > To support kmap_atomic_prot(), all architectures need to support > protections passed to their kmap_atomic_high() function. Pass > protections into kmap_atomic_high() and change the name to > kmap_ato

Re: [PATCH V3 07/15] arch/kunmap_atomic: Consolidate duplicate code

2020-05-16 Thread Guenter Roeck
On Thu, May 07, 2020 at 07:59:55AM -0700, ira.we...@intel.com wrote: > From: Ira Weiny > > Every single architecture (including !CONFIG_HIGHMEM) calls... > > pagefault_enable(); > preempt_enable(); > > ... before returning from __kunmap_atomic(). Lift this code into the > kunmap_at

Re: [PATCH v2 17/20] mm: free_area_init: allow defining max_zone_pfn in descending order

2020-05-05 Thread Guenter Roeck
On 5/4/20 8:39 AM, Mike Rapoport wrote: > On Sun, May 03, 2020 at 11:43:00AM -0700, Guenter Roeck wrote: >> On Sun, May 03, 2020 at 10:41:38AM -0700, Guenter Roeck wrote: >>> Hi, >>> >>> On Wed, Apr 29, 2020 at 03:11:23PM +0300, Mike Rapoport wrote: >

Re: [PATCH v2 17/20] mm: free_area_init: allow defining max_zone_pfn in descending order

2020-05-03 Thread Guenter Roeck
On Sun, May 03, 2020 at 10:41:38AM -0700, Guenter Roeck wrote: > Hi, > > On Wed, Apr 29, 2020 at 03:11:23PM +0300, Mike Rapoport wrote: > > From: Mike Rapoport > > > > Some architectures (e.g. ARC) have the ZONE_HIGHMEM zone below the > > ZONE_NORMAL

Re: [PATCH v2 17/20] mm: free_area_init: allow defining max_zone_pfn in descending order

2020-05-03 Thread Guenter Roeck
Hi, On Wed, Apr 29, 2020 at 03:11:23PM +0300, Mike Rapoport wrote: > From: Mike Rapoport > > Some architectures (e.g. ARC) have the ZONE_HIGHMEM zone below the > ZONE_NORMAL. Allowing free_area_init() parse max_zone_pfn array even it is > sorted in descending order allows using free_area_init()

Re: Build regressions/improvements in v5.6

2020-03-30 Thread Guenter Roeck
On 3/30/20 2:17 PM, Vineet Gupta wrote: > On 3/30/20 1:40 PM, Alexey Brodkin wrote: >> Hi Andy, Geert, >> >>> -Original Message- >>> From: Andy Shevchenko >>> Sent: Monday, March 30, 2020 4:28 PM >>> To: Geert Uytterhoeven ; Alexey Brodkin >>> >>> Cc: Linux Kernel Mailing List >>> Subje

Re: [PATCH 6/7] dma-direct: handle DMA_ATTR_NO_KERNEL_MAPPING in common code

2019-06-29 Thread Guenter Roeck
On Fri, Jun 14, 2019 at 04:44:30PM +0200, Christoph Hellwig wrote: > DMA_ATTR_NO_KERNEL_MAPPING is generally implemented by allocating > normal cacheable pages or CMA memory, and then returning the page > pointer as the opaque handle. Lift that code from the xtensa and > generic dma remapping impl

Re: [PATCH] mm: Generalize and rename notify_page_fault() as kprobe_page_fault()

2019-06-29 Thread Guenter Roeck
Hi, On Thu, Jun 13, 2019 at 03:37:24PM +0530, Anshuman Khandual wrote: > Architectures which support kprobes have very similar boilerplate around > calling kprobe_fault_handler(). Use a helper function in kprobes.h to unify > them, based on the x86 code. > > This changes the behaviour for other a

Re: [PATCH] ARCv2: Add explcit unaligned access support (and ability to disable too)

2019-02-28 Thread Guenter Roeck
On Wed, Jan 30, 2019 at 07:32:41PM +0300, Eugeniy Paltsev wrote: > As of today we enable unaligned access unconditionally on ARCv2. > Do this under a Kconfig option to allow disable it for test, benchmarking > etc. Also while at it > > - Select HAVE_EFFICIENT_UNALIGNED_ACCESS > - Although gcc

Re: [PATCH] ARCv2: Add explcit unaligned access support (and ability to disable too)

2019-02-28 Thread Guenter Roeck
On Thu, Feb 28, 2019 at 06:12:33PM +, Vineet Gupta wrote: > On 2/28/19 9:47 AM, Guenter Roeck wrote: > > On Wed, Jan 30, 2019 at 07:32:41PM +0300, Eugeniy Paltsev wrote: > >> As of today we enable unaligned access unconditionally on ARCv2. > >> Do this under a Kcon

Re: [PATCH 3/6] sparc: remove the sparc32_dma_ops indirection

2018-12-15 Thread Guenter Roeck
On 12/15/18 2:47 AM, Christoph Hellwig wrote: On Fri, Dec 14, 2018 at 10:30:18PM -0800, Guenter Roeck wrote: and so on, until qemu is terminated. This is seen with all sparc32 qemu emulations. Reverting the patch fixes the problem. Hi Guenter, can you check which of the three new ops is used

Re: [PATCH 3/6] sparc: remove the sparc32_dma_ops indirection

2018-12-14 Thread Guenter Roeck
On Sat, Dec 08, 2018 at 09:41:12AM -0800, Christoph Hellwig wrote: > There is no good reason to have a double indirection for the sparc32 > dma ops, so remove the sparc32_dma_ops and define separate dma_map_ops > instance for the different IOMMU types. > Except maybe this: scsi host0: esp scsi h

Re: [PATCH] ARCv2: build: use mcpu=hs38 iso generic mcpu=archs

2018-10-11 Thread Guenter Roeck
Hi Alexey, On Thu, Oct 11, 2018 at 09:22:50PM +, Alexey Brodkin wrote: > Hu Guenter, > > > -Original Message- > > From: linux-snps-arc [mailto:linux-snps-arc-boun...@lists.infradead.org] On > > Behalf Of Guenter Roeck > > Sent: Wednesday, September 1

Re: [PATCH] ARCv2: build: use mcpu=hs38 iso generic mcpu=archs

2018-10-11 Thread Guenter Roeck
Hi, On Fri, Sep 07, 2018 at 03:13:10PM -0700, Vineet Gupta wrote: > helps gcc with better instruction selections such as 64-bit multiply MPYD > > before > -- > 82c34b58 : > 82c34b58: ld r2,[0x83068d00] > 82c34b60: add_s r2,r2,0x7530 > 82c34b66: mov_s r0,0x989680 > 82c34b6

Re: [PATCH] ARCv2: build: use mcpu=hs38 iso generic mcpu=archs

2018-09-12 Thread Guenter Roeck
On Wed, Sep 12, 2018 at 05:06:25PM +, Vineet Gupta wrote: > > > > I use a toolchain based on gcc 7.3.0 and binutils 2.30. What version > > of gcc and binutils do I need for the builds to complete ? > > Hmm I have a prebuilt 2017.03 release of tools (gcc 7.1.1 based) and I don't > see > the is

Re: [PATCH] ARCv2: build: use mcpu=hs38 iso generic mcpu=archs

2018-09-12 Thread Guenter Roeck
On Wed, Sep 12, 2018 at 05:06:25PM +, Vineet Gupta wrote: > > Hmm I have a prebuilt 2017.03 release of tools (gcc 7.1.1 based) and I don't > see > the issue above when building net/core/dev.o > I presume your toolchain was built off of upstream gcc sources. Yes, using buildroot. > Can you p

Re: Build failure in linux mainline when building arcv2 images

2016-07-29 Thread Guenter Roeck
On 07/29/2016 03:46 PM, Vineet Gupta wrote: What you want is 2016-05-19 09439560b9f9 toolchain: bump ARC tools to arc-2016.03 release which seems to be present in released 2016.05, but when I checkout 2016.05 tag (or aa6fd11feebff) that patch is not there ! A toolchain build off SHA 0943956

Re: Build failure in linux mainline when building arcv2 images

2016-07-29 Thread Guenter Roeck
On Fri, Jul 29, 2016 at 01:03:56PM -0700, Vineet Gupta wrote: > On 07/29/2016 06:43 AM, Guenter Roeck wrote: > > On 07/28/2016 10:20 PM, Vineet Gupta wrote: > >> Hi Guenter, > >> > >> On 07/28/2016 08:23 PM, Guenter Roeck wrote: > >>> Hi Vineet,

Re: Build failure in linux mainline when building arcv2 images

2016-07-29 Thread Guenter Roeck
On 07/28/2016 10:20 PM, Vineet Gupta wrote: Hi Guenter, On 07/28/2016 08:23 PM, Guenter Roeck wrote: Hi Vineet, Mainline fails to build arcv2 images with the following error. {standard input}: Assembler messages: {standard input}:19174: Error: Instruction with long immediate data in delay

Build failure in linux mainline when building arcv2 images

2016-07-28 Thread Guenter Roeck
Hi Vineet, Mainline fails to build arcv2 images with the following error. {standard input}: Assembler messages: {standard input}:19174: Error: Instruction with long immediate data in delay slot make[2]: *** [block/cfq-iosched.o] Error 1 Bisect points to commit 9a7f38c42c2 ("cfq-iosched: Conver

Re: Build failures in -next due to 'locking/atomic, arch/arc: Implement atomic_fetch_{add,sub,and,andnot,or,xor}()'

2016-06-17 Thread Guenter Roeck
On Fri, Jun 17, 2016 at 10:22:46PM +0200, Vineet Gupta wrote: > On Friday 17 June 2016 06:04 PM, Ingo Molnar wrote: > >> I've misplaced my arc compiler, but does this make it go again? > > There's no arc compiler on korg's cross-building directory. > > Yeah, I'd requested that a few times... > >

Re: Build failures in -next due to 'locking/atomic, arch/arc: Implement atomic_fetch_{add,sub,and,andnot,or,xor}()'

2016-06-17 Thread Guenter Roeck
On 06/17/2016 07:41 AM, Peter Zijlstra wrote: On Fri, Jun 17, 2016 at 04:39:42PM +0200, Peter Zijlstra wrote: On Fri, Jun 17, 2016 at 07:36:56AM -0700, Guenter Roeck wrote: Hi Peter, I am seeing build failures in -next when trying to build arc / arcv2 targets. arch/arc/include/asm/atomic.h

Build failures in -next due to 'locking/atomic, arch/arc: Implement atomic_fetch_{add,sub,and,andnot,or,xor}()'

2016-06-17 Thread Guenter Roeck
Hi Peter, I am seeing build failures in -next when trying to build arc / arcv2 targets. arch/arc/include/asm/atomic.h:74:2: error: ‘SCOND_FAIL_RETRY_VAR_DEF’ undeclared arch/arc/include/asm/atomic.h:87:2: error: expected ‘:’ or ‘)’ before ‘SCOND_FAIL_RETRY_ASM’ Problems seem to be caused by 'l

Re: Build error due to commit 458aa76d132dc ("mm/thp/migration: switch from flush_tlb_range to flush_pmd_tlb_range")

2016-03-22 Thread Guenter Roeck
On 03/21/2016 10:14 PM, Aneesh Kumar K.V wrote: Guenter Roeck writes: [ text/plain ] Hi, Your commit 458aa76d132dc1 ("mm/thp/migration: switch from flush_tlb_range to flush_pmd_tlb_range") causes a build error when building arcv2:vdk_hs38_smp_defconfig. include/asm-generic/pgtabl

Build error due to commit 458aa76d132dc ("mm/thp/migration: switch from flush_tlb_range to flush_pmd_tlb_range")

2016-03-21 Thread Guenter Roeck
Hi, Your commit 458aa76d132dc1 ("mm/thp/migration: switch from flush_tlb_range to flush_pmd_tlb_range") causes a build error when building arcv2:vdk_hs38_smp_defconfig. include/asm-generic/pgtable.h:799:45: note: in expansion of macro ‘BUILD_BUG’ #define flush_pmd_tlb_range(vma, addr, end) BUILD