Re: [PATCH v2 1/1] mm: pgtable: fix pte_swp_exclusive

2025-04-07 Thread Geert Uytterhoeven
on the other hand. On Alpha, "pte_val(pte) & _PAGE_SWP_EXCLUSIVE" is either _PAGE_SWP_EXCLUSIVE == 0x80UL or zero. Due to the return type being int, the return value was truncated, and the function always returned zero. Gr{oetje,eeting}s,

Re: [PATCH v2 13/13] arch, mm: make releasing of memory to page allocator more explicit

2025-03-13 Thread Geert Uytterhoeven
t more explicit where the free memory is > released from memblock to the buddy allocator and to reduce code > duplication in architecture specific code. > > Acked-by: Dave Hansen # x86 > Signed-off-by: Mike Rapoport (Microsoft) > arch/m68k/mm/init.c | 2 -

Re: [PATCH 10/13] arch, mm: set high_memory in free_area_init()

2025-03-11 Thread Geert Uytterhoeven
0.00] Memory policy: Data cache writealloc > [0.00] efi: UEFI not found. > [0.00] cma: Reserved 64 MiB at 0x > > - I'd only been sampling the logs for the physical platforms, none of > which had shown anything. Hangs that early need "earlycon",

Re: [PATCH v5 3/8] asm-generic: introduce text-patching.h

2024-10-10 Thread Geert Uytterhoeven
-patching.h and add an empty > header in asm-generic for architectures that do not support text patching. > > Signed-off-by: Mike Rapoport (Microsoft) > arch/m68k/include/asm/Kbuild | 1 + Acked-by: Geert Uytterhoeven # m68k Gr{oetje,eeting}s,

Re: [PATCH RFC v3 1/2] mm: Add personality flag to limit address to 47 bits

2024-09-10 Thread Geert Uytterhoeven
ze achievable with a 47BIT > address, that naming would be more consistant with the ADDR_LIMIT_3GB > just above that means a 3 Gigabytes limit. Hence ADDR_LIMIT_128TB? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In perso

Re: [PATCH 07/17] clone3: drop __ARCH_WANT_SYS_CLONE3 macro

2024-07-05 Thread Geert Uytterhoeven
ectures that don't > already provide the syscall, and remove __ARCH_WANT_SYS_CLONE3 > from all the other ones. > > Signed-off-by: Arnd Bergmann > arch/m68k/include/asm/unistd.h | 1 - Acked-by: Geert Uytterhoeven Gr{oetje,eeting}s,

Re: [PATCH v2 3/3] arch: define CONFIG_PAGE_SIZE_*KB on all architectures

2024-03-06 Thread Geert Uytterhoeven
+++ > arch/m68k/Kconfig.cpu | 2 ++ > arch/m68k/include/asm/page.h | 6 +- Acked-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations

Re: [PATCH 3/4] arch: define CONFIG_PAGE_SIZE_*KB on all architectures

2024-02-27 Thread Geert Uytterhoeven
Hi Arnd, CC Greg On Tue, Feb 27, 2024 at 11:59 AM Arnd Bergmann wrote: > On Tue, Feb 27, 2024, at 09:54, Geert Uytterhoeven wrote: > >> diff --git a/arch/m68k/Kconfig.cpu b/arch/m68k/Kconfig.cpu > >> index 9dcf245c9cbf..c777a129768a 100644 > >> --- a/arch/m68k/Kc

Re: [PATCH 3/4] arch: define CONFIG_PAGE_SIZE_*KB on all architectures

2024-02-27 Thread Geert Uytterhoeven
ut MMU? > select LEGACY_TIMER_TICK > help > The Freescale (was Motorola) 68000 CPU is the first generation of Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@li

Re: [PATCH 1/4] arch: consolidate existing CONFIG_PAGE_SIZE_*KB definitions

2024-02-27 Thread Geert Uytterhoeven
ficial binary prefixes => "4 KiB". > + depends on HAVE_PAGE_SIZE_4KB Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call mysel

Re: [PATCH 08/22] [v2] arch: consolidate arch_irq_work_raise prototypes

2024-01-10 Thread Geert Uytterhoeven
er Gordeev > Signed-off-by: Arnd Bergmann Tested-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker.

Re: [PATCH 10/22] microblaze: include linux/cpu.h for trap_init() prototype

2023-11-08 Thread Geert Uytterhoeven
Hi Arnd, On Wed, Nov 8, 2023 at 10:07 PM Arnd Bergmann wrote: > On Wed, Nov 8, 2023, at 21:42, Geert Uytterhoeven wrote: > > On Wed, Nov 8, 2023 at 2:01 PM Arnd Bergmann wrote: > >> From: Arnd Bergmann > >> > >> Microblaze runs into a single -Wmis

Re: [PATCH 10/22] microblaze: include linux/cpu.h for trap_init() prototype

2023-11-08 Thread Geert Uytterhoeven
.h | 1 - > arch/x86/kernel/traps.c| 1 + > 10 files changed, 7 insertions(+), 8 deletions(-) > delete mode 100644 arch/m68k/coldfire/vectors.h Obviously the non-microblaze changes should be spun off in separate patches. Gr{oetje,eeting}s, Geert -- Geer

Re: (subset) [PATCH 00/17] -Wmissing-prototype warning fixes

2023-08-27 Thread Geert Uytterhoeven
into doing that... Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programm

Re: (subset) [PATCH 00/17] -Wmissing-prototype warning fixes

2023-08-25 Thread Geert Uytterhoeven
ails around the use of DMA masks for Amiga WD33C93 > drivers, Geert? Doh, it's been a while, and I never had an affected system. Probably it's needed on A2000 with an accelerator card and GVP II SCSI, to prevent DMA to RAM banks that do not support fast DMA cycles. Gr{oetje,eeting}s,

Re: [PATCH] treewide: drop CONFIG_EMBEDDED

2023-08-16 Thread Geert Uytterhoeven
Hi Randy, On Wed, Aug 16, 2023 at 7:50 AM Randy Dunlap wrote: > There is only one Kconfig user of CONFIG_EMBEDDED and it can be > switched to EXPERT or "if !ARCH_MULTIPLATFORM" (suggested by Arnd). > > Signed-off-by: Randy Dunlap Makes perfect sense to me. Acked-by: G

Re: [PATCH 20/21] ARM: dma-mapping: split out arch_dma_mark_clean() helper

2023-07-03 Thread Geert Uytterhoeven
arch_sync_dma_for_cpu(phys, size, dir); > + arm_iommu_sync_dma_for_cpu(phys, size, dir, > dev->dma_coherent); > } > > iommu_unmap(mapping->domain, iova, len); With the above fixed, it builds and boots fine (on R-Car M2-W). Gr{oetje,eeting}

Re: [PATCH 21/21] dma-mapping: replace custom code with generic implementation

2023-06-27 Thread Geert Uytterhoeven
e void arch_dma_cache_wback_inv(phys_addr_t paddr, size_t size) { - dcache_clean_inval_poc(paddr, paddr + size); + unsigned long start = (unsigned long)phys_to_virt(paddr); + + dcache_clean_inval_poc(start, start + size); } static inline bool arch_sync_dma_clean_before_fromdevice(void) Gr{oetje,ee

Re: [PATCH v9 01/42] mm: Rename arch pte_mkwrite()'s to pte_mkwrite_novma()

2023-06-13 Thread Geert Uytterhoeven
; Cc: linux-a...@vger.kernel.org > Cc: linux...@kvack.org > Suggested-by: Linus Torvalds > Signed-off-by: Rick Edgecombe > Link: > https://lore.kernel.org/lkml/CAHk-=wizjsu7c9sfyzb3q04108stghff2wfbokgccgw7riz...@mail.gmail.com/ > arch/m68k/include/asm/mcf_pgtable.

Re: [PATCH v3 12/12] m68k/mm: Make pfn accessors static inlines

2023-05-24 Thread Geert Uytterhoeven
ymorphic and accepting many types > such as (void *), (unitptr_t) or (unsigned long) as arguments > without warnings. > > For symmetry, do the same with pfn_to_virt(). > > Signed-off-by: Linus Walleij Reviewed-by: Geert Uytterhoeven Acked-by: Geert Uytterhoeven Gr{oetje,eeting}s,

Re: [PATCH v3 02/12] m68k: Pass a pointer to virt_to_pfn() virt_to_page()

2023-05-24 Thread Geert Uytterhoeven
variants of the defines depending on whether you build for > classic m68k, ColdFire or Sun3, so fix all variants. > > Tested-by: Geert Uytterhoeven > Signed-off-by: Linus Walleij Thanks for your patch! > --- > ChangeLog v2->v3: > - Fix up versioning. This is v3. >

Re: [PATCH] mm/slab: rename CONFIG_SLAB to CONFIG_SLAB_DEPRECATED

2023-05-23 Thread Geert Uytterhoeven
defconfig | 1 - > arch/m68k/configs/q40_defconfig | 1 - > arch/m68k/configs/sun3_defconfig| 1 - > arch/m68k/configs/sun3x_defconfig | 1 - Regardless, Acked-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert U

Re: [PATCH v2 02/12] m68k: Pass a pointer to virt_to_pfn() virt_to_page()

2023-05-22 Thread Geert Uytterhoeven
variants of the defines depending on whether you build for > classic m68k, ColdFire or Sun3, so fix all variants. > > Tested-by: Geert Uytterhoeven > Signed-off-by: Linus Walleij Thanks for the update! > --- > ChangeLog v2->v3: v3? > - Fix the sun3 pgtable macro to

Re: [PATCH 02/12] m68k: Pass a pointer to virt_to_pfn() virt_to_page()

2023-05-12 Thread Geert Uytterhoeven
On Fri, May 12, 2023 at 11:55 AM Geert Uytterhoeven wrote: > On Thu, May 11, 2023 at 1:59 PM Linus Walleij > wrote: > > Functions that work on a pointer to virtual memory such as > > virt_to_pfn() and users of that function such as > > virt_to_page() are supposed to p

Re: [PATCH 00/12] arch: Make virt_to_pfn into a static inline

2023-05-12 Thread Geert Uytterhoeven
s fine on ARAnyM, with the extra changes I replied on patch 2/12. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journa

Re: [PATCH 02/12] m68k: Pass a pointer to virt_to_pfn() virt_to_page()

2023-05-12 Thread Geert Uytterhoeven
PTE; ++i, ++pg_table) { - pte_t pte = pfn_pte(virt_to_pfn(address), PAGE_INIT); + pte_t pte = pfn_pte(virt_to_pfn((void *)address), PAGE_INIT); if (address >= (unsigned long) high_memory) pte_val(p

Re: [PATCH v6 1/6] fbdev/matrox: Remove trailing whitespaces

2023-05-11 Thread Geert Uytterhoeven
through the fbdev API. Or do you mean the resolution of the text console, akin to "fbset "? I have to admit I do not know if there is a command line tool to do that... Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 --

Re: [PATCH v6 5/6] fbdev: Move framebuffer I/O helpers into

2023-05-11 Thread Geert Uytterhoeven
nw/outw > implementations. See also commit 4aafae27d0ce73f8 ("sh: hd64461 tidying."), which claims they are no longer needed. Don't the I/O port macros just treat the port as an absolute base address when sh_io_port_base isn't set? Gr{oetje,eeting}s, Geert -

Re: [PATCH v6 5/6] fbdev: Move framebuffer I/O helpers into

2023-05-10 Thread Geert Uytterhoeven
Hi Thomas, On Wed, May 10, 2023 at 4:20 PM Thomas Zimmermann wrote: > Am 10.05.23 um 14:34 schrieb Geert Uytterhoeven: > > On Wed, May 10, 2023 at 1:06 PM Thomas Zimmermann > > wrote: > >> Implement framebuffer I/O helpers, such as fb_read*() and fb_write*(), > >&

Re: [PATCH v6 5/6] fbdev: Move framebuffer I/O helpers into

2023-05-10 Thread Geert Uytterhoeven
emoved. > + */ > +#ifdef CONFIG_64BIT > +static inline u64 fb_readq(const volatile void __iomem *addr) > +{ > + return __raw_readq(addr); ... so how can this call work? > +} > +#define fb_readq fb_readq > + > +static inline void fb_writeq(u64 b, volatile void __iomem *

Re: [PATCH v3 0/6] fbdev: Move framebuffer I/O helpers to

2023-05-03 Thread Geert Uytterhoeven
v3 00/19] arch: Consolidate "[1], but with that applied, I had to manually fixup drivers/video/fbdev/core/fb_cfb_fops.c. [1] https://lore.kernel.org/all/20230417125651.25126-1-tzimmerm...@suse.de, Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lo

Re: [PATCH v3 4/6] fbdev: Include via

2023-05-03 Thread Geert Uytterhoeven
t this in the case of asm/io.h > > vs. linux/io.h. > > > > I understand that's the case too. I believe even checkpatch.pl complains > about it? (not that the script always get right, but just as an example). One more to chime in: in general, drivers should only include

Re: [PATCH v2 5/5] fbdev: Define framebuffer I/O from Linux' I/O functions

2023-04-28 Thread Geert Uytterhoeven
> native-endian, whereas the regular accessors are explicitly > little-endian, so there is a slight risk of inadvertently changing > behaviour on big-endian systems (MIPS most likely, but a few old ARM > platforms run BE as well). Also on m68k, when ISA or PCI

Re: [PATCH] [v2] mm: make arch_has_descending_max_zone_pfns() static

2023-04-18 Thread Geert Uytterhoeven
("mm: make arch_has_descending_max_zone_pfns() static") in next-20230417 and applying your v2 makes Salvator-XS regain its DMA memory zone. Tested-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots o

Re: [PATCH v2 08/19] arch/m68k: Implement with generic helpers

2023-04-11 Thread Geert Uytterhoeven
On Thu, Apr 6, 2023 at 4:30 PM Thomas Zimmermann wrote: > Replace the architecture's fb_is_primary_device() with the generic > one from . No functional changes. > > v2: > * provide empty fb_pgprotect() on non-MMU systems > > Signed-off-by: Thomas Zimmermann

Re: [PATCH v2 07/19] arch/m68k: Merge variants of fb_pgprotect() into single function

2023-04-11 Thread Geert Uytterhoeven
he switch to . > > Signed-off-by: Thomas Zimmermann Reviewed-by: Geert Uytterhoeven Acked-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical

Re: [PATCH v2 01/19] fbdev: Prepare generic architecture helpers

2023-04-11 Thread Geert Uytterhoeven
unsigned long off) Does this affect any noMMU platforms that relied on fb_pgprotect() doing nothing before? Perhaps the body below should be protected by "#ifdef CONFIG_MMU"? > +{ > + vma->vm_page_prot = pgprot_writecombine(vma->vm_page_prot);

Re: [PATCH v4 00/24] Remove COMMAND_LINE_SIZE from uapi

2023-03-02 Thread Geert Uytterhoeven
Hi Alex, On Thu, Mar 2, 2023 at 11:09 AM Alexandre Ghiti wrote: > On 3/2/23 10:47, Geert Uytterhoeven wrote: > > On Thu, Mar 2, 2023 at 10:35 AM Alexandre Ghiti > > wrote: > >> This all came up in the context of increasing COMMAND_LINE_SIZE in the > >> RISC

Re: [PATCH v4 00/24] Remove COMMAND_LINE_SIZE from uapi

2023-03-02 Thread Geert Uytterhoeven
sectable, but I haven't > tested it all that aggressively. > > Changes since v3 > <https://lore.kernel.org/all/20230214074925.228106-1-alexgh...@rivosinc.com/>: > * Added RB/AB > * Added a mention to commit 622021cd6c56 ("s390: make command line > configurable

Re: [PATCH mm-unstable v1 11/26] microblaze/mm: support __HAVE_ARCH_PTE_SWP_EXCLUSIVE

2023-02-27 Thread Geert Uytterhoeven
s... > I recall that I used the comment above "/* Definitions for MicroBlaze. > */" as an orientation. > > 0 1 2 3 4 ... 18 19 20 21 22 23 24 25 26 27 28 29 30 31 > RPN. 0 0 EX WR ZSEL... W I M G Indeed, that's where I noticed the

Re: [PATCH mm-unstable v1 11/26] microblaze/mm: support __HAVE_ARCH_PTE_SWP_EXCLUSIVE

2023-02-27 Thread Geert Uytterhoeven
Hi David, On Mon, Feb 27, 2023 at 2:31 PM David Hildenbrand wrote: > On 26.02.23 21:13, Geert Uytterhoeven wrote: > > On Fri, Jan 13, 2023 at 6:16 PM David Hildenbrand wrote: > >> Let's support __HAVE_ARCH_PTE_SWP_EXCLUSIVE by stealing one bit > >> from the type

Re: [PATCH mm-unstable v1 11/26] microblaze/mm: support __HAVE_ARCH_PTE_SWP_EXCLUSIVE

2023-02-26 Thread Geert Uytterhoeven
extern pte_t *va_to_pte(unsigned long address); > #define _PAGE_ACCESSED 0x400 /* software: R: page referenced */ > #define _PMD_PRESENT PAGE_MASK > > +/* We borrow bit 24 to store the exclusive marker in swap PTEs. */ > +#define _PAGE_SWP_EXCLUSIVE_PAGE_DIRTY _PAGE_DIRTY is 0x8

Re: [PATCH v3 05/24] m68k: Remove COMMAND_LINE_SIZE from uapi

2023-02-14 Thread Geert Uytterhoeven
On Tue, Feb 14, 2023 at 8:55 AM Alexandre Ghiti wrote: > From: Palmer Dabbelt > > As far as I can tell this is not used by userspace and thus should not > be part of the user-visible API. > > Signed-off-by: Palmer Dabbelt Acked-by: Geert Uytterhoeven

Re: [PATCH v3 15/24] m68k: Remove empty

2023-02-14 Thread Geert Uytterhoeven
On Tue, Feb 14, 2023 at 9:05 AM Alexandre Ghiti wrote: > From: Palmer Dabbelt > > Signed-off-by: Palmer Dabbelt Acked-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.or

Re: [PATCH v3 00/24] Remove COMMAND_LINE_SIZE from uapi

2023-02-14 Thread Geert Uytterhoeven
l out and leave it bisectable, but I haven't > > tested it all that aggressively. > > Just to confirm this assumption a bit more: that's actually the same > conclusion that we ended up with when commit 3da0243f906a ("s390: make > command line configurable") went upstre

Re: [PATCH 1/3] m68k: use asm-generic/memory_model.h for both MMU and !MMU

2023-01-26 Thread Geert Uytterhoeven
y_model.h in the common include/asm/page.h and > drop redundant definitions. > > Signed-off-by: Mike Rapoport (IBM) Reviewed-by: Geert Uytterhoeven Acked-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux bey

Re: [PATCH v4] arch: rename all internal names __xchg to __arch_xchg

2023-01-16 Thread Geert Uytterhoeven
v4: adjusted indentation (Heiko) > arch/m68k/include/asm/cmpxchg.h | 6 +++--- Acked-by: Geert Uytterhoeven [m68k] Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with t

Re: [PATCH v2] arch: rename all internal names __xchg to __arch_xchg

2023-01-02 Thread Geert Uytterhoeven
On Thu, Dec 29, 2022 at 12:34 PM Andrzej Hajda wrote: > __xchg will be used for non-atomic xchg macro. > > Signed-off-by: Andrzej Hajda > Reviewed-by: Arnd Bergmann Acked-by: Geert Uytterhoeven [m68k] Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- The

Re: [PATCH 00/19] Introduce __xchg, non-atomic xchg

2022-12-22 Thread Geert Uytterhoeven
ity header. > > If the idea is OK there are still 2 qestions to answer: > > 1. Name of the helper, __xchg follows kernel conventions, > but for me Rust names are also OK. Before I realized the missing "&", I wondered how this is different from swap(), so naming is important

Re: [PATCH] mm: remove kern_addr_valid() completely

2022-10-18 Thread Geert Uytterhoeven
, so no need kern_addr_valid(), > let's remove unneeded kern_addr_valid() completely. > > Signed-off-by: Kefeng Wang > arch/m68k/include/asm/pgtable_mm.h| 2 - > arch/m68k/include/asm/pgtable_no.h| 1 - Acked-by: Geert Uytterhoeven [m68k] Gr{oetje,eeting}s

Re: [PATCH] kernel: exit: cleanup release_thread()

2022-08-19 Thread Geert Uytterhoeven
ruct *leader; Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "progra

Re: [PATCH] arch: mm: rename FORCE_MAX_ZONEORDER to ARCH_FORCE_MAX_ORDER

2022-08-15 Thread Geert Uytterhoeven
| 2 +- Acked-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to jour

Re: [PATCH v4 2/3] PCI: Move isa_dma_bridge_buggy out of dma.h

2022-07-20 Thread Geert Uytterhoeven
hristoph Hellwig > Signed-off-by: Stafford Horne > --- > Since v3: > - New patch. > arch/m68k/include/asm/dma.h | 6 -- Acked-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia

Re: [PATCH V6 26/26] mm/mmap: Drop ARCH_HAS_VM_GET_PAGE_PROT

2022-07-06 Thread Geert Uytterhoeven
8k/Kconfig | 1 - Reviewed-by: Geert Uytterhoeven Acked-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. B

Re: [PATCH V6 21/26] m68k/mm: Enable ARCH_HAS_VM_GET_PAGE_PROT

2022-07-06 Thread Geert Uytterhoeven
(implying read and execute) and writeable. > These > * are as close as we can get... > */ The comment above should be removed, too. > -#define __P000 PAGE_NONE > -#define __P001 PAGE_READONLY With the above fixed: Reviewed-by: Geert Uytterhoeven Acked-by: Geert Uytterhoeven

Re: [PATCH 19/36] objtool/idle: Validate __cpuidle code as noinstr

2022-07-06 Thread Geert Uytterhoeven
inux-std.lds |1 - > arch/m68k/kernel/vmlinux-sun3.lds | 1 - FWIW Acked-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical peop

Re: [PATCH v2 2/3] m68k: bitops: Change __fls to return and accept unsigned long

2022-07-06 Thread Geert Uytterhoeven
d-by: Cezary Rojewski > Signed-off-by: Amadeusz Sławiński Reviewed-by: Geert Uytterhoeven i.e. will queue in the m68k for-v5.20 branch. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conver

Re: [PATCH v3] mm: Avoid unnecessary page fault retires on shared memory types

2022-05-25 Thread Geert Uytterhoeven
t() and break_ksm() because they do > not handle VM_FAULT_RETRY even with existing code, so I'm literally keeping > them as-is. > > Signed-off-by: Peter Xu > arch/m68k/mm/fault.c | 4 Acked-by: Geert Uytterhoeven Gr{oetje,eeting}s,

Re: [PATCH V3 09/30] arm/mm: Enable ARCH_HAS_VM_GET_PAGE_PROT

2022-03-02 Thread Geert Uytterhoeven
Hi Anshuman, On Wed, Mar 2, 2022 at 12:07 PM Anshuman Khandual wrote: > On 3/2/22 3:35 PM, Geert Uytterhoeven wrote: > > On Wed, Mar 2, 2022 at 10:51 AM Anshuman Khandual > > wrote: > >> On 3/2/22 12:35 PM, Christophe Leroy wrote: > >>> Le 02/03/202

Re: [PATCH V3 09/30] arm/mm: Enable ARCH_HAS_VM_GET_PAGE_PROT

2022-03-02 Thread Geert Uytterhoeven
x27;s objection. > > > > As this is bad for ARM and bad for PPC32, do we have any evidence that > > your change is good for any other architecture ? > > > > I checked PPC64 and there is exactly the same drawback. With the current > > implementation it is a small functio

Re: [PATCH V3 09/30] arm/mm: Enable ARCH_HAS_VM_GET_PAGE_PROT

2022-02-28 Thread Geert Uytterhoeven
the (few different) cases is offset by a 16-bit jump table (which is to be credited to the compiler). In terms of CPU cycles, it's indeed worse than before. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.o

Re: [PATCH v2 13/18] uaccess: generalize access_ok()

2022-02-18 Thread Geert Uytterhoeven
> arch/m68k/Kconfig.cpu | 1 + > arch/m68k/include/asm/uaccess.h | 19 +---- Acked-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal co

Re: [PATCH v2 10/18] m68k: fix access_ok for coldfire

2022-02-18 Thread Geert Uytterhoeven
y compilers that warn (or worse with -Werror) about "condition always true" for TASK_SIZE = 0xUL? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conv

Re: [PATCH v2 08/18] uaccess: add generic __{get,put}_kernel_nofault

2022-02-18 Thread Geert Uytterhoeven
al > copy_{from,to}_kernel_nofault() code based on these, removing the last > use of get_fs()/set_fs() from architecture-independent code. > > Reviewed-by: Christoph Hellwig > Signed-off-by: Arnd Bergmann > arch/m68k/include/asm/uaccess.h | 2 - Acked-by: Ge

Re: [RFC 02/32] Kconfig: introduce HAS_IOPORT option and select it as necessary

2021-12-28 Thread Geert Uytterhoeven
ks way too broad to me: most m68k platform do not have I/O port access support. My gut feeling says: select HAS_IOPORT if PCI || ISA but that might miss some intricate details... Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia

Re: [PATCH 2/2] futex: remove futex_cmpxchg detection

2021-10-26 Thread Geert Uytterhoeven
1 - Acked-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say

Re: [PATCH 2/2] kbuild: use more subdir- for visiting subdirectories while cleaning

2021-10-13 Thread Geert Uytterhoeven
;), we can use the "subdir- += boot" trick for > all architectures. This can take advantage of the parallel option (-j) > for "make clean". > > I also cleaned up the comments. The "archdep" target does not exist. > > Signed-off-by: Masahiro Yamada >

Re: [PATCH v1 2/4] memblock: allow to specify flags with memblock_add_node()

2021-09-27 Thread Geert Uytterhoeven
we don't want to add the memory first and apply flags later: it > should happen within one memblock call. > > Signed-off-by: David Hildenbrand > arch/m68k/mm/mcfmmu.c| 3 ++- > arch/m68k/mm/motorola.c | 6 -- Acked-by: Geert Uytterhoeven Gr{oetje,

Re: [PATCH v3 9/9] asm-generic: reverse GENERIC_{STRNCPY_FROM, STRNLEN}_USER symbols

2021-07-24 Thread Geert Uytterhoeven
t; Cc: linux-i...@vger.kernel.org > Cc: linux-m...@vger.kernel.org > Cc: linux-par...@vger.kernel.org > Cc: linux-s...@vger.kernel.org > Cc: linux...@lists.infradead.org > Cc: linux-xte...@linux-xtensa.org > Signed-off-by: Arnd Bergmann > arch/m68k/Kconfig

Re: [PATCH v2 8/9] mm: replace CONFIG_NEED_MULTIPLE_NODES with CONFIG_NUMA

2021-06-07 Thread Geert Uytterhoeven
EM - unsigned long max_mapnr; - EXPORT_SYMBOL(max_mapnr); - Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. B

Re: [PATCH v2 0/9] Remove DISCINTIGMEM memory model

2021-06-07 Thread Geert Uytterhoeven
Hi Mike, You may want to fix the DISCINTIGMEM typo in the subject for v3, unless you think that makes tracking series versions more complicated ;-) Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In per

Re: [PATCH 4/9] m68k: remove support for DISCONTIGMEM

2021-06-02 Thread Geert Uytterhoeven
your patch! Reviewed-by: Geert Uytterhoeven Acked-by: Geert Uytterhoeven > --- a/arch/m68k/include/asm/page_mm.h > +++ b/arch/m68k/include/asm/page_mm.h > @@ -126,25 +126,7 @@ static inline void *__va(unsigned long x) > > extern int m68k_virt_to_node_shift; > > -#ifndef

Re: [PATCH 4/5] asm-generic: uaccess: remove inline strncpy_from_user/strnlen_user

2021-05-17 Thread Geert Uytterhoeven
On Sat, May 15, 2021 at 12:11 AM Arnd Bergmann wrote: > From: Arnd Bergmann > > Consolidate the asm-generic implementation with the library version > that is used everywhere else. > > Signed-off-by: Arnd Bergmann > arch/m68k/Kconfig | 4 +-- Reviewed-by: Geer

Re: [PATCH 1/5] asm-generic/uaccess.h: remove __strncpy_from_user/__strnlen_user

2021-05-17 Thread Geert Uytterhoeven
> > Signed-off-by: Arnd Bergmann Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalis

Re: [PATCH 1/2] mm: Fix struct page layout on 32-bit systems

2021-04-20 Thread Geert Uytterhoeven
dr(struct page *page, dma_addr_t addr) > +{ > + page->dma_addr[0] = addr; > + if (sizeof(dma_addr_t) > sizeof(unsigned long)) > + page->dma_addr[1] = addr >> 16 >> 16; ... but we do have upper_32_bits() for a 32-bi

Re: [PATCH] kbuild: use ?= to assign CROSS_COMPILE by arch-Makefile

2021-04-12 Thread Geert Uytterhoeven
8k") no longer pick up the cross-compiler, but fall back to the native compiler, thus breaking the build. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversatio

Re: [PATCH] arch: consolidate pm_power_off callback

2020-12-23 Thread Geert Uytterhoeven
Hi Enrico, On Tue, Dec 22, 2020 at 9:15 PM Enrico Weigelt, metux IT consult wrote: > On 22.12.20 19:54, Geert Uytterhoeven wrote: > > On Tue, Dec 22, 2020 at 7:46 PM Enrico Weigelt, metux IT consult > > wrote: > >> Move the pm_power_off callback into one glob

Re: [PATCH] arch: consolidate pm_power_off callback

2020-12-22 Thread Geert Uytterhoeven
ny > - */ > -void (*pm_power_off)(void) = machine_power_off; Assignments like these are lost in the conversion. > -EXPORT_SYMBOL(pm_power_off); Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In perso

Re: [PATCH v2 00/13] arch, mm: deprecate DISCONTIGMEM

2020-12-01 Thread Geert Uytterhoeven
gt; > >> That's with "localmodconfig", see attached configuration file. > > > > Thanks. > > It seems that the recent addition of TIF_NOTIFY_SIGNAL to ia64 in > > linux-next caused the issue. Can you please try the below patch? > > That's a

Re: [PATCH 11/13] m68k/mm: make node data and node setup depend on CONFIG_DISCONTIGMEM

2020-10-28 Thread Geert Uytterhoeven
| 4 ++-- > 3 files changed, 6 insertions(+), 6 deletions(-) Is there any specific reason you didn't convert the checks for CONFIG_SINGLE_MEMORY_CHUNK in arch/m68k/kernel/setup_mm.c and arch/m68k/include/asm/virtconvert.h? Gr{oetje,eeting}s, Geert -- Geert Uytt

Re: Build regressions/improvements in v5.10-rc1

2020-10-26 Thread Geert Uytterhoeven
On Mon, Oct 26, 2020 at 10:46 AM Geert Uytterhoeven wrote: > Below is the list of build error/warning regressions/improvements in > v5.10-rc1[1] compared to v5.9[2]. > > Summarized: > - build errors: +3/-7 > - build warnings: +26/-28 > > Happy fixing! ;-) > > Tha

Re: [PATCH 6/8] asm-generic: pgalloc: provide generic pgd_free()

2020-06-29 Thread Geert Uytterhoeven
Rapoport For the m68k part: Acked-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm

Re: [PATCH 1/8] mm: remove unneeded includes of

2020-06-29 Thread Geert Uytterhoeven
alloc\.h/d' \ > $(grep -L -w -f /tmp/xx \ > $(git grep -E -l '[<"]asm/pgalloc\.h')) > > where /tmp/xx contains all the symbols defined in > arch/*/include/asm/pgalloc.h. > > Signed-off-by: Mike Rapoport For

Re: [PATCH 17/17] arch: rename copy_thread_tls() back to copy_thread()

2020-06-23 Thread Geert Uytterhoeven
process > creation work since we've added clone3(). > Signed-off-by: Christian Brauner > arch/m68k/kernel/process.c | 2 +- Acked-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia3

Re: [PATCH 16/17] arch: remove HAVE_COPY_THREAD_TLS

2020-06-23 Thread Geert Uytterhoeven
ad_tls() and struct kernel_clone_args. This will make it easier to > maintain the core process creation code under kernel/, simplifies the > callpaths and makes the identical for all architectures. > Signed-off-by: Christian Brauner > arch/m68k/Kconfig | 1 - Acked-by: Geert

Re: Build regressions/improvements in v5.6

2020-03-30 Thread Geert Uytterhoeven
Hi Vineet, On Mon, Mar 30, 2020 at 11:18 PM Vineet Gupta wrote: > On 3/30/20 1:40 PM, Alexey Brodkin wrote: > >> -Original Message- > >> From: Andy Shevchenko > >> Sent: Monday, March 30, 2020 4:28 PM > >> To: Geert Uytterhoeven ; Alexey Brodkin &

Re: [RFC 1/3] mm/vma: Define a default value for VM_DATA_DEFAULT_FLAGS

2020-03-02 Thread Geert Uytterhoeven
ith standard VMA access flag combinations that are used frequently across > many platforms. Apart from simplification, this reduces code duplication > as well. > Signed-off-by: Anshuman Khandual > arch/m68k/include/asm/page.h | 3 --- For m68k: Acked-by: Geert Uytterho

Re: [RESEND PATCH v2 9/9] ath5k: Constify ioreadX() iomem argument (as in generic implementation)

2020-02-24 Thread Geert Uytterhoeven
t > > bring except longer code to read? > > Because the argument is an int: > > drivers/net/wireless/ath/ath5k/ahb.c: In function ‘ath_ahb_probe’: > drivers/net/wireless/ath/ath5k/ahb.c:141:18: warning: passing argument 1 of > ‘ioread32’ makes pointer from integer without a cast

Re: [PATCH] ARC: Replace by

2020-02-12 Thread Geert Uytterhoeven
Hi Vineet, On Wed, Feb 12, 2020 at 6:30 PM Vineet Gupta wrote: > On 2/12/20 2:00 AM, Geert Uytterhoeven wrote: > > The ARC platform code is not a clock provider, and just needs to call > > of_clk_init(). > > > > Hence it can include instead of . > > >

[PATCH] ARC: Replace by

2020-02-12 Thread Geert Uytterhoeven
The ARC platform code is not a clock provider, and just needs to call of_clk_init(). Hence it can include instead of . Signed-off-by: Geert Uytterhoeven --- arch/arc/kernel/setup.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arc/kernel/setup.c b/arch/arc/kernel

Re: [PATCH v2 1/9] iomap: Constify ioreadX() iomem argument (as in generic implementation)

2020-01-09 Thread Geert Uytterhoeven
emory under the address > so they can be converted to a "const" version for const-safety and > consistency among architectures. > > Suggested-by: Geert Uytterhoeven > Signed-off-by: Krzysztof Kozlowski > Reviewed-by: Geert Uytterhoeven Reviewed

Re: [RFT 00/13] iomap: Constify ioreadX() iomem argument

2020-01-08 Thread Geert Uytterhoeven
Hi Christophe, On Wed, Jan 8, 2020 at 9:35 AM Christophe Leroy wrote: > Le 08/01/2020 à 09:18, Krzysztof Kozlowski a écrit : > > On Wed, 8 Jan 2020 at 09:13, Geert Uytterhoeven > > wrote: > >> On Wed, Jan 8, 2020 at 9:07 AM Geert Uytterhoeven > >> wrote: >

Re: [RFT 00/13] iomap: Constify ioreadX() iomem argument

2020-01-08 Thread Geert Uytterhoeven
Hi Krzysztof, On Wed, Jan 8, 2020 at 9:07 AM Geert Uytterhoeven wrote: > On Tue, Jan 7, 2020 at 5:53 PM Krzysztof Kozlowski wrote: > > The ioread8/16/32() and others have inconsistent interface among the > > architectures: some taking address as const, some not. > >

Re: [RFT 02/13] alpha: Constify ioreadX() iomem argument (as in generic implementation)

2020-01-08 Thread Geert Uytterhoeven
adw, const volatile) > REMAP1(u32, readl, const volatile) Same for REMAP2() macro below, for iowrite*(). Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people,

Re: [RFT 00/13] iomap: Constify ioreadX() iomem argument

2020-01-08 Thread Geert Uytterhoeven
hed into one. Yes, they should be squashed, cfr. Arnd's comment. I also wouldn't bother doing the updates in patches 6-10. The rest looks good to me. Thanks a lot! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux

Re: [PATCH 11/21] asm-generic: don't provide ioremap for CONFIG_MMU

2019-11-06 Thread Geert Uytterhoeven
7;d go for the second one. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to jou

Re: [PATCH 13/21] m68k: rename __iounmap and mark it static

2019-10-30 Thread Geert Uytterhoeven
ellwig Thanks for the update! Reviewed-by: Geert Uytterhoeven Acked-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call mysel

Re: [PATCH 13/21] m68k: rename __iounmap and mark it static

2019-10-18 Thread Geert Uytterhoeven
r, unsigned long size) > { > unsigned long virtaddr = (unsigned long)addr; > pgd_t *pgd_dir; > @@ -297,6 +299,7 @@ void __iounmap(void *addr, unsigned long size) > > flush_tlb_all(); > } > +#endif /* CPU_M68040_OR_M68060_ONLY */ > > /* >

Re: [PATCH 08/26] m68k: simplify ioremap_nocache

2019-09-02 Thread Geert Uytterhoeven
Hi Christoph, On Fri, Aug 30, 2019 at 6:06 PM Christoph Hellwig wrote: > On Mon, Aug 19, 2019 at 10:56:02AM +0200, Geert Uytterhoeven wrote: > > On Sat, Aug 17, 2019 at 9:48 AM Christoph Hellwig wrote: > > > Just define ioremap_nocache to ioremap instead of duplicating the &

Re: [PATCH 18/26] m68k: rename __iounmap and mark it static

2019-08-19 Thread Geert Uytterhoeven
unsigned long virtaddr = (unsigned long)addr; > pgd_t *pgd_dir; > @@ -297,6 +299,7 @@ void __iounmap(void *addr, unsigned long size) > > flush_tlb_all(); > } > +#endif /* CPU_M68040_OR_M68060_ONLY */ > > /* > * Set new cache mode for some k

  1   2   >