Re: [PATCH 1/2] gpio: tb10x: Create local helper variables

2018-08-20 Thread Christian Ruppert
Acked-by: Christian Ruppert On 06.08.2018 17:12, Linus Walleij wrote: > Create a local struct device *dev helper variable to make the code > easier to read. > > Most GPIO drivers use "np" (node pointer) rather than "dn" (device node) > to point to the

Re: [PATCH] gpio: tb10x: Use the right include

2018-08-20 Thread Christian Ruppert
Acked-by: Christian Ruppert On 06.08.2018 16:23, Linus Walleij wrote: > This driver includes the legacy and > but all it needs is really . > > Cc: linux-snps-arc@lists.infradead.org > Cc: Christian Ruppert > Signed-off-by: Linus Walleij > --- > drivers/gpio/gpio-t

Re: [PATCH 2/2] gpio: tb10x: Use GENERIC_GPIO

2018-08-20 Thread Christian Ruppert
Acked-by: Christian Ruppert On 06.08.2018 17:12, Linus Walleij wrote: > Instead of open coding logic for reading and writing GPIO lines, > use the generic GPIO library. Also switch to using the spinlock > from the generic GPIO to protect the registers. > > Cc: linux-snps-arc@list

Re: [PATCH v2 7/9] ARC: use fixed frequencies in arc_set_early_base_baud()

2016-03-08 Thread christian . ruppert
arc_{get|set}_core_freq() and switch to generic clock > framework later on. > > Cc: Christian Ruppert > Signed-off-by: Alexey Brodkin > Signed-off-by: Vineet Gupta Acked-by: Christian Ruppert > --- > Changes v1 -> v2 > - Base baud TB10x needs to be 166.66 not 166.6

Re: [PATCH 7/9] ARC: use fixed frequencies in arc_set_early_base_baud()

2016-02-02 Thread christian . ruppert
Alexey Brodkin wrote on 02.02.2016 13:53:26: > > Adding Christian for Abilis TB10x clocks review. > > On Tue, 2016-02-02 at 16:28 +0530, Vineet Gupta wrote: > > From: Alexey Brodkin > > > > UARTs usually have fixed clock so we're switching to use of > > constant values instead of something der