Re: [PATCH] ARC:mm:Fix syntax errors in comments

2022-06-23 Thread Bagas Sanjaya
On 6/24/22 08:57, Vineet Gupta wrote: > "Repeated" is the key - First time I'd politely tell them to DTRT but will > just ignore if things continue. > >> Lazily speaking, I'd like to privately notice the >> submitter about the situation, and I withhold these for now. > > Funny that you say this:

Re: [PATCH] ARC:mm:Fix syntax errors in comments

2022-06-23 Thread Bagas Sanjaya
On 6/23/22 09:50, Vineet Gupta wrote: >> The patch is OK, but its subject is wrong. > > Right. > >> The patch above isn't fixing any syntax errors, but rather minor cleanup. >> The subject should have been "Remove duplicate 'to' in the >> flush_dcache_page() comment". > > I'd just say "ARC: mm:

Re: [PATCH] ARC:mm:Fix syntax errors in comments

2022-06-22 Thread Bagas Sanjaya
On 6/22/22 16:38, Julia Lawall wrote: >>> So code that is fine will have typos forever? Fixing typos in comments >>> doesn't break git blame for the following code. And typos in comments >>> give a bad impression about the state of the code in general. >> >> Of course not! Documentation is as imp

Re: [PATCH] ARC:mm:Fix syntax errors in comments

2022-06-22 Thread Bagas Sanjaya
On Wed, Jun 22, 2022 at 04:04:23PM +0800, Jilin Yuan wrote: > Delete the redundant word 'to'. > > Signed-off-by: Jilin Yuan > --- > arch/arc/mm/cache.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arc/mm/cache.c b/arch/arc/mm/cache.c > index 5446967ea98d..84fe78