Re: [PATCH 1/7] vsprintf: Add %pTN to print task name

2024-12-13 Thread Andy Shevchenko
On Fri, Dec 13, 2024 at 02:27:09PM +0100, Borislav Petkov wrote: > On Fri, Dec 13, 2024 at 10:35:03AM +0200, Kalle Valo wrote: > > I agree, it makes the code harder to read for someone who is not > > familiar with all the %p magic we have (like me). > +1 And me too. In case one thinks of unprinta

Re: [PATCH mm-unstable v2 00/16] mm: Introduce arch_mmap_hint()

2024-12-13 Thread Kalesh Singh
On Fri, Dec 13, 2024 at 11:45 AM 'Liam R. Howlett' via kernel-team wrote: > > * Lorenzo Stoakes [241213 10:16]: > > On Fri, Dec 13, 2024 at 10:06:55AM -0500, Kalesh Singh wrote: > > > On Fri, Dec 13, 2024 at 4:00 AM Lorenzo Stoakes > > > wrote: > > ... > > > > > > > On the technical side, Liam i

Re: [PATCH mm-unstable v2 00/16] mm: Introduce arch_mmap_hint()

2024-12-13 Thread Liam R. Howlett
* Lorenzo Stoakes [241213 10:16]: > On Fri, Dec 13, 2024 at 10:06:55AM -0500, Kalesh Singh wrote: > > On Fri, Dec 13, 2024 at 4:00 AM Lorenzo Stoakes > > wrote: ... > > > > On the technical side, Liam is right that the copy-pasted arch code > > has inconsistencies (missing checks, order of chec

Re: [PATCH mm-unstable v2 00/16] mm: Introduce arch_mmap_hint()

2024-12-13 Thread Lorenzo Stoakes
On Fri, Dec 13, 2024 at 10:06:55AM -0500, Kalesh Singh wrote: > On Fri, Dec 13, 2024 at 4:00 AM Lorenzo Stoakes > wrote: > > > > On Thu, Dec 12, 2024 at 05:36:09PM -0800, Andrew Morton wrote: > > > On Thu, 12 Dec 2024 22:51:34 + Lorenzo Stoakes > > > wrote: > > > > > > > You've fundamentally

Re: [PATCH mm-unstable v2 00/16] mm: Introduce arch_mmap_hint()

2024-12-13 Thread Kalesh Singh
On Fri, Dec 13, 2024 at 4:00 AM Lorenzo Stoakes wrote: > > On Thu, Dec 12, 2024 at 05:36:09PM -0800, Andrew Morton wrote: > > On Thu, 12 Dec 2024 22:51:34 + Lorenzo Stoakes > > wrote: > > > > > You've fundamentally violated kernel process and etiquette. I'd be more > > > forgiving, but this

Re: [PATCH 1/7] vsprintf: Add %pTN to print task name

2024-12-13 Thread Borislav Petkov
On Fri, Dec 13, 2024 at 10:35:03AM +0200, Kalle Valo wrote: > I agree, it makes the code harder to read for someone who is not > familiar with all the %p magic we have (like me). +1 -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette _

Re: [PATCH mm-unstable v2 00/16] mm: Introduce arch_mmap_hint()

2024-12-13 Thread Lorenzo Stoakes
On Thu, Dec 12, 2024 at 05:36:09PM -0800, Andrew Morton wrote: > On Thu, 12 Dec 2024 22:51:34 + Lorenzo Stoakes > wrote: > > > You've fundamentally violated kernel process and etiquette. I'd be more > > forgiving, but this is at v2 and you've not cc'd KEY people. Twice. This is > > totally un

Re: [PATCH 1/7] vsprintf: Add %pTN to print task name

2024-12-13 Thread Yafang Shao
On Fri, Dec 13, 2024 at 4:05 PM Petr Mladek wrote: > > On Fri 2024-12-13 13:46:04, Yafang Shao wrote: > > Since the task->comm is guaranteed to be NUL-ternimated, we can print it > > directly. Add a new vsnprintf format specifier "%pTN" to print task comm, > > where 'p' represents the task Pointer

Re: [PATCH 1/7] vsprintf: Add %pTN to print task name

2024-12-13 Thread Kalle Valo
Petr Mladek writes: > On Fri 2024-12-13 13:46:04, Yafang Shao wrote: >> Since the task->comm is guaranteed to be NUL-ternimated, we can print it >> directly. Add a new vsnprintf format specifier "%pTN" to print task comm, >> where 'p' represents the task Pointer, 'T' stands for Task, and 'N' deno

Re: [PATCH 1/7] vsprintf: Add %pTN to print task name

2024-12-13 Thread Petr Mladek
On Fri 2024-12-13 13:46:04, Yafang Shao wrote: > Since the task->comm is guaranteed to be NUL-ternimated, we can print it > directly. Add a new vsnprintf format specifier "%pTN" to print task comm, > where 'p' represents the task Pointer, 'T' stands for Task, and 'N' denots > Name. With this abstra