Re: [PATCH v5 RESEND 07/17] arc: mm: Convert to GENERIC_IOREMAP

2023-05-17 Thread Baoquan He
On 05/16/23 at 11:31pm, Christoph Hellwig wrote: > > +#define ioremap ioremap > > +#define ioremap_prot ioremap_prot > > +#define iounmap iounmap > > Nit: I think it's cleaner to have these #defines right next to the > function declaration. Makes sense, will do. > > Otherwise looks good: > >

Re: [PATCH 06/12] cifs: Pass a pointer to virt_to_page() in cifsglob

2023-05-17 Thread Tom Talpey
On 5/11/2023 7:59 AM, Linus Walleij wrote: Like the other calls in this function virt_to_page() expects a pointer, not an integer. However since many architectures implement virt_to_pfn() as a macro, this function becomes polymorphic and accepts both a (unsigned long) and a (void *). Fix this u

Re: [PATCH 05/12] cifs: Pass a pointer to virt_to_page()

2023-05-17 Thread Tom Talpey
On 5/11/2023 7:59 AM, Linus Walleij wrote: Like the other calls in this function virt_to_page() expects a pointer, not an integer. However since many architectures implement virt_to_pfn() as a macro, this function becomes polymorphic and accepts both a (unsigned long) and a (void *). Fix this u