Re: [PATCH v3 6/6] fbdev: Rename fb_mem*() helpers

2023-05-03 Thread Sam Ravnborg
Hi Thomas, On Wed, May 03, 2023 at 10:15:46AM +0200, Thomas Zimmermann wrote: > Hi > > Am 02.05.23 um 22:08 schrieb Sam Ravnborg: > > Hi Thomas. > > > > On Tue, May 02, 2023 at 03:02:23PM +0200, Thomas Zimmermann wrote: > > > Update the names of the fb_mem*() helpers to be consistent with their

Re: [PATCH v3 5/6] fbdev: Move framebuffer I/O helpers into

2023-05-03 Thread Sam Ravnborg
Hi Thomas, > > But I am missing something somewhere as I cannot see how this builds. > > asm-generic now provide the fb_read/fb_write helpers. > > But for example sparc has an architecture specifc fb.h so it will not > > use the asm-generic variant. So I wonder how sparc get hold of the > > asm-ge

Re: [PATCH v3 5/6] fbdev: Move framebuffer I/O helpers into

2023-05-03 Thread Arnd Bergmann
On Wed, May 3, 2023, at 16:55, Thomas Zimmermann wrote: > Am 02.05.23 um 22:06 schrieb Arnd Bergmann: >> It's probably safe to deal with all the above by either adding >> architecture specific overrides to the current version, or >> by doing the semantic changes before the move to asm/fb.h, but >>

Re: [PATCH v3 5/6] fbdev: Move framebuffer I/O helpers into

2023-05-03 Thread Thomas Zimmermann
Hi Am 02.05.23 um 22:06 schrieb Arnd Bergmann: On Tue, May 2, 2023, at 15:02, Thomas Zimmermann wrote: Implement framebuffer I/O helpers, such as fb_read*() and fb_write*(), in the architecture's header file or the generic one. The common case has been the use of regular I/O functions, such a

Re: [PATCH] Remove HAVE_VIRT_CPU_ACCOUNTING_GEN option

2023-05-03 Thread Frederic Weisbecker
Le Sat, Apr 29, 2023 at 04:33:48PM +1000, Nicholas Piggin a écrit : > This option was created in commit 554b0004d0ec4 ("vtime: Add > HAVE_VIRT_CPU_ACCOUNTING_GEN Kconfig") for architectures to indicate > they support the 64-bit cputime_t required for VIRT_CPU_ACCOUNTING_GEN. > > The cputime_t type

Re: [PATCH v3 4/6] fbdev: Include via

2023-05-03 Thread Arnd Bergmann
On Wed, May 3, 2023, at 10:12, Thomas Zimmermann wrote: > Am 03.05.23 um 09:19 schrieb Javier Martinez Canillas: >> Thomas Zimmermann writes: There are countless examples where the above are not followed, but to my best understanding the above it the preferred way to do it. >>> >>>

Re: [PATCH v3 0/6] fbdev: Move framebuffer I/O helpers to

2023-05-03 Thread Geert Uytterhoeven
Hi Thomas, On Tue, May 2, 2023 at 3:02 PM Thomas Zimmermann wrote: > (was: fbdev: Use regular I/O function for framebuffers) > > Fbdev provides helpers for framebuffer I/O, such as fb_readl(), > fb_writel() or fb_memcpy_to_fb(). The implementation of each helper > depends on the architecture, but

Re: [PATCH v3 6/6] fbdev: Rename fb_mem*() helpers

2023-05-03 Thread Thomas Zimmermann
Hi Am 02.05.23 um 22:08 schrieb Sam Ravnborg: Hi Thomas. On Tue, May 02, 2023 at 03:02:23PM +0200, Thomas Zimmermann wrote: Update the names of the fb_mem*() helpers to be consistent with their regular counterparts. Hence, fb_memset() now becomes fb_memset_io(), fb_memcpy_fromfb() now becomes

Re: [PATCH v3 4/6] fbdev: Include via

2023-05-03 Thread Thomas Zimmermann
Hi Am 03.05.23 um 09:19 schrieb Javier Martinez Canillas: Thomas Zimmermann writes: Hello Thomas, Am 02.05.23 um 21:54 schrieb Sam Ravnborg: On Tue, May 02, 2023 at 03:02:21PM +0200, Thomas Zimmermann wrote: [...] #include /* Why should fb driver call console functions? because con

Re: [PATCH v3 4/6] fbdev: Include via

2023-05-03 Thread Geert Uytterhoeven
On Wed, May 3, 2023 at 9:19 AM Javier Martinez Canillas wrote: > Thomas Zimmermann writes: > > Am 02.05.23 um 21:54 schrieb Sam Ravnborg: > >> On Tue, May 02, 2023 at 03:02:21PM +0200, Thomas Zimmermann wrote: > > [...] > > >>> #include /* Why should fb driver call console > >>> functions? be

Re: [PATCH v3 4/6] fbdev: Include via

2023-05-03 Thread Javier Martinez Canillas
Thomas Zimmermann writes: Hello Thomas, > Am 02.05.23 um 21:54 schrieb Sam Ravnborg: >> On Tue, May 02, 2023 at 03:02:21PM +0200, Thomas Zimmermann wrote: [...] >>> #include /* Why should fb driver call console >>> functions? because console_lock() */ >>> #include >>> >>> +#include

Re: [PATCH v3 4/6] fbdev: Include via

2023-05-03 Thread Thomas Zimmermann
Hi Am 02.05.23 um 21:54 schrieb Sam Ravnborg: Hi Thomas, On Tue, May 02, 2023 at 03:02:21PM +0200, Thomas Zimmermann wrote: Fbdev's main header file, , includes to get declarations for I/O helper functions. From these declarations, it later defines framebuffer I/O helpers, such as fb_{read,wr