Re: [PATCH v3 5/6] fbdev: Move framebuffer I/O helpers into

2023-05-02 Thread Thomas Zimmermann
Hi Sam Am 02.05.23 um 22:03 schrieb Sam Ravnborg: Hi Thomas, On Tue, May 02, 2023 at 03:02:22PM +0200, Thomas Zimmermann wrote: Implement framebuffer I/O helpers, such as fb_read*() and fb_write*(), in the architecture's header file or the generic one. In reality they are now all implemente

Re: [PATCH v3 6/6] fbdev: Rename fb_mem*() helpers

2023-05-02 Thread Sam Ravnborg
Hi Thomas. On Tue, May 02, 2023 at 03:02:23PM +0200, Thomas Zimmermann wrote: > Update the names of the fb_mem*() helpers to be consistent with their > regular counterparts. Hence, fb_memset() now becomes fb_memset_io(), > fb_memcpy_fromfb() now becomes fb_memcpy_fromio() and fb_memcpy_tofb() > be

Re: [PATCH v3 5/6] fbdev: Move framebuffer I/O helpers into

2023-05-02 Thread Arnd Bergmann
On Tue, May 2, 2023, at 15:02, Thomas Zimmermann wrote: > Implement framebuffer I/O helpers, such as fb_read*() and fb_write*(), > in the architecture's header file or the generic one. > > The common case has been the use of regular I/O functions, such as > __raw_readb() or memset_io(). A few arch

Re: [PATCH v3 5/6] fbdev: Move framebuffer I/O helpers into

2023-05-02 Thread Sam Ravnborg
Hi Thomas, On Tue, May 02, 2023 at 03:02:22PM +0200, Thomas Zimmermann wrote: > Implement framebuffer I/O helpers, such as fb_read*() and fb_write*(), > in the architecture's header file or the generic one. In reality they are now all implemented in the generic one. > > The common case has bee

Re: [PATCH v3 4/6] fbdev: Include via

2023-05-02 Thread Sam Ravnborg
Hi Thomas, On Tue, May 02, 2023 at 03:02:21PM +0200, Thomas Zimmermann wrote: > Fbdev's main header file, , includes to get > declarations for I/O helper functions. From these declarations, it > later defines framebuffer I/O helpers, such as fb_{read,write}[bwlq]() > or fb_memset(). > > The fram

Re: [PATCH] Remove HAVE_VIRT_CPU_ACCOUNTING_GEN option

2023-05-02 Thread Nicholas Piggin
On Sun Apr 30, 2023 at 6:14 AM AEST, Palmer Dabbelt wrote: > On Fri, 28 Apr 2023 23:33:48 PDT (-0700), npig...@gmail.com wrote: > > This option was created in commit 554b0004d0ec4 ("vtime: Add > > HAVE_VIRT_CPU_ACCOUNTING_GEN Kconfig") for architectures to indicate > > they support the 64-bit cputi

[PATCH v3 6/6] fbdev: Rename fb_mem*() helpers

2023-05-02 Thread Thomas Zimmermann
Update the names of the fb_mem*() helpers to be consistent with their regular counterparts. Hence, fb_memset() now becomes fb_memset_io(), fb_memcpy_fromfb() now becomes fb_memcpy_fromio() and fb_memcpy_tofb() becomes fb_memcpy_toio(). No functional changes. Signed-off-by: Thomas Zimmermann ---

[PATCH v3 4/6] fbdev: Include via

2023-05-02 Thread Thomas Zimmermann
Fbdev's main header file, , includes to get declarations for I/O helper functions. From these declarations, it later defines framebuffer I/O helpers, such as fb_{read,write}[bwlq]() or fb_memset(). The framebuffer I/O helpers depend on the system architecture and will therefore be moved into . Pr

[PATCH v3 3/6] fbdev: Include in various drivers

2023-05-02 Thread Thomas Zimmermann
The code uses writel() and similar I/O-memory helpers. Include the header file to get the declarations. Signed-off-by: Thomas Zimmermann Reviewed-by: Sam Ravnborg --- drivers/video/fbdev/arcfb.c | 1 + drivers/video/fbdev/aty/atyfb.h | 2 ++ drivers/video/fbdev/wmt_ge_rops.c | 2 ++ 3 f

[PATCH v3 2/6] ipu-v3: Include

2023-05-02 Thread Thomas Zimmermann
The code uses readl() and writel(). Include the header file to get the declarations. Signed-off-by: Thomas Zimmermann Reviewed-by: Sam Ravnborg --- drivers/gpu/ipu-v3/ipu-prv.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/ipu-v3/ipu-prv.h b/drivers/gpu/ipu-v3/ipu-prv.h index

[PATCH v3 5/6] fbdev: Move framebuffer I/O helpers into

2023-05-02 Thread Thomas Zimmermann
Implement framebuffer I/O helpers, such as fb_read*() and fb_write*(), in the architecture's header file or the generic one. The common case has been the use of regular I/O functions, such as __raw_readb() or memset_io(). A few architectures used plain system- memory reads and writes. Sparc used

[PATCH v3 0/6] fbdev: Move framebuffer I/O helpers to

2023-05-02 Thread Thomas Zimmermann
(was: fbdev: Use regular I/O function for framebuffers) Fbdev provides helpers for framebuffer I/O, such as fb_readl(), fb_writel() or fb_memcpy_to_fb(). The implementation of each helper depends on the architecture, but they are all equivalent to regular I/O functions of similar names. So use reg

[PATCH v3 1/6] fbdev/matrox: Remove trailing whitespaces

2023-05-02 Thread Thomas Zimmermann
Fix coding style. No functional changes. Signed-off-by: Thomas Zimmermann Reviewed-by: Sam Ravnborg --- drivers/video/fbdev/matrox/matroxfb_accel.c | 6 +++--- drivers/video/fbdev/matrox/matroxfb_base.h | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/video/fbde