Re: [PATCH v2 33/44] ftrace: WARN on rcuidle

2022-10-04 Thread Mark Rutland
On Mon, Sep 19, 2022 at 12:00:12PM +0200, Peter Zijlstra wrote: > CONFIG_GENERIC_ENTRY disallows any and all tracing when RCU isn't > enabled. > > XXX if s390 (the only other GENERIC_ENTRY user as of this writing) > isn't comfortable with this, we could switch to > HAVE_NOINSTR_VALIDATION which is

Re: [PATCH v2 00/44] cpuidle,rcu: Clean up the mess

2022-10-04 Thread Ulf Hansson
On Mon, 19 Sept 2022 at 12:18, Peter Zijlstra wrote: > > Hi All! > > At long last, a respin of the cpuidle vs rcu cleanup patches. > > v1: https://lkml.kernel.org/r/20220608142723.103523...@infradead.org > > These here patches clean up the mess that is cpuidle vs rcuidle. > > At the end of the rid

Re: [PATCH v2 12/44] cpuidle,dt: Push RCU-idle into driver

2022-10-04 Thread Ulf Hansson
On Tue, 4 Oct 2022 at 13:03, Ulf Hansson wrote: > > On Mon, 19 Sept 2022 at 12:18, Peter Zijlstra wrote: > > > > Doing RCU-idle outside the driver, only to then temporarily enable it > > again before going idle is daft. > > > > Notably: this converts all dt_init_idle_driver() and > > __CPU_PM_CPU

Re: [PATCH v2 38/44] cpuidle,powerdomain: Remove trace_.*_rcuidle()

2022-10-04 Thread Ulf Hansson
On Mon, 19 Sept 2022 at 12:17, Peter Zijlstra wrote: > > OMAP was the one and only user. > > Signed-off-by: Peter Zijlstra (Intel) There are changes to the runtime PM core as part of $subject patch. Perhaps move those parts into a separate patch? In any case, the code looks good to me. Reviewed

Re: [PATCH v2 39/44] cpuidle,clk: Remove trace_.*_rcuidle()

2022-10-04 Thread Ulf Hansson
On Mon, 19 Sept 2022 at 12:17, Peter Zijlstra wrote: > > OMAP was the one and only user. OMAP? :-) > > Signed-off-by: Peter Zijlstra (Intel) Reviewed-by: Ulf Hansson Kind regards Uffe > --- > drivers/clk/clk.c |8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > --- a/dri

Re: [PATCH v2 23/44] arm,smp: Remove trace_.*_rcuidle() usage

2022-10-04 Thread Ulf Hansson
On Mon, 19 Sept 2022 at 12:18, Peter Zijlstra wrote: > > None of these functions should ever be ran with RCU disabled anymore. > > Specifically, do_handle_IPI() is only called from handle_IPI() which > explicitly does irq_enter()/irq_exit() which ensures RCU is watching. > > The problem with smp_c

Re: [PATCH v2 14/44] cpuidle,cpu_pm: Remove RCU fiddling from cpu_pm_{enter,exit}()

2022-10-04 Thread Ulf Hansson
On Mon, 19 Sept 2022 at 12:17, Peter Zijlstra wrote: > > All callers should still have RCU enabled. > > Signed-off-by: Peter Zijlstra (Intel) > Acked-by: Mark Rutland Reviewed-by: Ulf Hansson Kind regards Uffe > --- > kernel/cpu_pm.c |9 - > 1 file changed, 9 deletions(-) > > --

Re: [PATCH v2 12/44] cpuidle,dt: Push RCU-idle into driver

2022-10-04 Thread Ulf Hansson
On Mon, 19 Sept 2022 at 12:18, Peter Zijlstra wrote: > > Doing RCU-idle outside the driver, only to then temporarily enable it > again before going idle is daft. > > Notably: this converts all dt_init_idle_driver() and > __CPU_PM_CPU_IDLE_ENTER() users for they are inextrably intertwined. > > Sign