Re: [PATCH] ARC:kernel:Fix typos in comments

2022-06-22 Thread Vineet Gupta
On 6/22/22 00:52, Jilin Yuan wrote: Delete the redundant word 'call'. Signed-off-by: Jilin Yuan --- arch/arc/kernel/smp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arc/kernel/smp.c b/arch/arc/kernel/smp.c index d947473f1e6d..6c22a53711e9 100644 --- a/arch/ar

Re: [PATCH] ARC:mm:Fix syntax errors in comments

2022-06-22 Thread Vineet Gupta
On 6/22/22 01:30, Bagas Sanjaya wrote: - * If the U-mapping is not congruent to to K-mapping, former needs flushing. + * If the U-mapping is not congruent to K-mapping, former needs flushing. */ void flush_dcache_page(struct page *page) { The patch is OK, but its subject is wrong. Ri

Re: [PATCH] ARC:mm:Fix syntax errors in comments

2022-06-22 Thread Julia Lawall
On Wed, 22 Jun 2022, Bagas Sanjaya wrote: > On 6/22/22 16:38, Julia Lawall wrote: > >>> So code that is fine will have typos forever? Fixing typos in comments > >>> doesn't break git blame for the following code. And typos in comments > >>> give a bad impression about the state of the code in

Re: [PATCH] ARC:mm:Fix syntax errors in comments

2022-06-22 Thread Bagas Sanjaya
On 6/22/22 16:38, Julia Lawall wrote: >>> So code that is fine will have typos forever? Fixing typos in comments >>> doesn't break git blame for the following code. And typos in comments >>> give a bad impression about the state of the code in general. >> >> Of course not! Documentation is as imp

Re: [PATCH] ARC:mm:Fix syntax errors in comments

2022-06-22 Thread Julia Lawall
On Wed, 22 Jun 2022, Shahab Vahedi wrote: > On 6/22/22 11:16, Julia Lawall wrote: > > > > > > On Wed, 22 Jun 2022, Shahab Vahedi wrote: > > > >> On 6/22/22 10:30, Bagas Sanjaya wrote: > >> > >>> I think that this kind of cleanup patches (typofixes) are best done > >>> as part of **actual** work

Re: [PATCH] ARC:mm:Fix syntax errors in comments

2022-06-22 Thread Julia Lawall
On Wed, 22 Jun 2022, Shahab Vahedi wrote: > On 6/22/22 10:30, Bagas Sanjaya wrote: > > > I think that this kind of cleanup patches (typofixes) are best done > > as part of **actual** work on the code in question (for example > > refactoring or fixing build errors). > > Amen! So code that is fi

Re: [PATCH] ARC:mm:Fix syntax errors in comments

2022-06-22 Thread Bagas Sanjaya
On Wed, Jun 22, 2022 at 04:04:23PM +0800, Jilin Yuan wrote: > Delete the redundant word 'to'. > > Signed-off-by: Jilin Yuan > --- > arch/arc/mm/cache.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arc/mm/cache.c b/arch/arc/mm/cache.c > index 5446967ea98d..84fe78

[PATCH] ARC:mm:Fix syntax errors in comments

2022-06-22 Thread Jilin Yuan
Delete the redundant word 'to'. Signed-off-by: Jilin Yuan --- arch/arc/mm/cache.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arc/mm/cache.c b/arch/arc/mm/cache.c index 5446967ea98d..84fe78c41c37 100644 --- a/arch/arc/mm/cache.c +++ b/arch/arc/mm/cache.c @@ -750,7 +7

[PATCH] ARC:kernel:Fix typos in comments

2022-06-22 Thread Jilin Yuan
Delete the redundant word 'call'. Signed-off-by: Jilin Yuan --- arch/arc/kernel/smp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arc/kernel/smp.c b/arch/arc/kernel/smp.c index d947473f1e6d..6c22a53711e9 100644 --- a/arch/arc/kernel/smp.c +++ b/arch/arc/kernel/smp.c