Re: [PATCH] ARC: Use 40-bit physical page mask for PAE

2021-04-26 Thread Vineet Gupta
On 4/26/21 9:43 AM, Vladimir Isaev wrote: > Hi, > > On Monday, April 26, 2021 7:30 PM, Vineet Gupta wrote: >> On 4/26/21 3:08 AM, Vladimir Isaev wrote: >> >>>#endif /* _UAPI__ASM_ARC_PAGE_H */ >>> diff --git a/arch/arc/mm/ioremap.c b/arch/arc/mm/ioremap.c >>> index fac4adc90204..eb109d57d544 10

RE: [PATCH] ARC: Use 40-bit physical page mask for PAE

2021-04-26 Thread Vladimir Isaev
Hi, On Monday, April 26, 2021 7:30 PM, Vineet Gupta wrote: > On 4/26/21 3:08 AM, Vladimir Isaev wrote: > > > > > #endif /* _UAPI__ASM_ARC_PAGE_H */ > > diff --git a/arch/arc/mm/ioremap.c b/arch/arc/mm/ioremap.c > > index fac4adc90204..eb109d57d544 100644 > > --- a/arch/arc/mm/ioremap.c > > +++

Re: [PATCH] ARC: Use max_high_pfn as a HIGHMEM zone border

2021-04-26 Thread Vineet Gupta
On 4/26/21 9:15 AM, Mike Rapoport wrote: > On Mon, Apr 26, 2021 at 11:55:00AM +, Vladimir Isaev wrote: >> Hi Mike, >> >> On Mon, April 26, 2021 2:29 PM, Mike Rapoport wrote: >>> On Mon, Apr 26, 2021 at 01:10:04PM +0300, Vladimir Isaev wrote: - max_zone_pfn[ZONE_HIGHMEM] = min_low_pfn; >>>

Re: [PATCH] ARC: Use 40-bit physical page mask for PAE

2021-04-26 Thread Vineet Gupta
+CC Arnd On 4/26/21 3:08 AM, Vladimir Isaev wrote: > 32-bit PAGE_MASK can not be used as a mask for physical addresses > when PAE is enabled. PHYSICAL_PAGE_MASK must be used for physical > addresses instead of PAGE_MASK. Can you provide a bit more context : like w/o this exit/munmap on 5.x kerne

Re: [PATCH] ARC: Use max_high_pfn as a HIGHMEM zone border

2021-04-26 Thread Mike Rapoport
On Mon, Apr 26, 2021 at 11:55:00AM +, Vladimir Isaev wrote: > Hi Mike, > > On Mon, April 26, 2021 2:29 PM, Mike Rapoport wrote: > > On Mon, Apr 26, 2021 at 01:10:04PM +0300, Vladimir Isaev wrote: > > > - max_zone_pfn[ZONE_HIGHMEM] = min_low_pfn; > > > + max_zone_pfn[ZONE_HIGHMEM] = max_high_pf

RE: [PATCH] ARC: Use max_high_pfn as a HIGHMEM zone border

2021-04-26 Thread Vladimir Isaev
Hi Mike, On Mon, April 26, 2021 2:29 PM, Mike Rapoport wrote: > On Mon, Apr 26, 2021 at 01:10:04PM +0300, Vladimir Isaev wrote: > > - max_zone_pfn[ZONE_HIGHMEM] = min_low_pfn; > > + max_zone_pfn[ZONE_HIGHMEM] = max_high_pfn; > > This is correct with PAE40, but it will break !PAE40 when "highm

Re: [PATCH] ARC: Use 40-bit physical page mask for PAE

2021-04-26 Thread kernel test robot
Hi Vladimir, Thank you for the patch! Yet something to improve: [auto build test ERROR on v5.12] [also build test ERROR on next-20210426] [cannot apply to arc/for-next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '-

[PATCH] ARC: Use max_high_pfn as a HIGHMEM zone border

2021-04-26 Thread Vladimir Isaev
Commit 4af22ded0ecf ("arc: fix memory initialization for systems with two memory banks") fixed highmem, but not for PAE case when highmem is actually bigger than lowmem. Signed-off-by: Vladimir Isaev Cc: Mike Rapoport --- arch/arc/mm/init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH] ARC: Use 40-bit physical page mask for PAE

2021-04-26 Thread Vladimir Isaev
32-bit PAGE_MASK can not be used as a mask for physical addresses when PAE is enabled. PHYSICAL_PAGE_MASK must be used for physical addresses instead of PAGE_MASK. Signed-off-by: Vladimir Isaev --- arch/arc/include/asm/pgtable.h | 12 +++- arch/arc/include/uapi/asm/page.h | 7 +++

Re: [PATCH] ARC: Use max_high_pfn as a HIGHMEM zone border

2021-04-26 Thread Mike Rapoport
Hi, On Mon, Apr 26, 2021 at 01:10:04PM +0300, Vladimir Isaev wrote: > Commit 4af22ded0ecf ("arc: fix memory initialization for systems with two > memory banks") fixed highmem, but not for PAE case when highmem is > actually bigger than lowmem. > > Signed-off-by: Vladimir Isaev > Cc: Mike Rapopor