Re: [PATCH v2 1/2] dl-runtime: reloc_{offset,index} now functions arch overide'able

2020-06-05 Thread Vineet Gupta
On 6/5/20 1:16 PM, Adhemerval Zanella via Libc-alpha wrote: > > On 01/06/2020 19:18, Vineet Gupta wrote: >> The existing macros are fragile and expect local variables with a >> certain name. Fix this by defining them as functions with default >> implementation in a new header dl-runtime.h which ar

Re: [PATCH v2 2/2] ARC/dl-runtime helper macros

2020-06-05 Thread Vineet Gupta
On 6/5/20 1:26 PM, Adhemerval Zanella via Libc-alpha wrote: > > On 01/06/2020 19:18, Vineet Gupta wrote: >> This is purely for review purposes to attest the interface defined >> in prior patch > LGTM with some style nits, however I think it should be pushed along with > the ARC patchset. Thx. In

Re: [PATCH v2 2/2] ARC/dl-runtime helper macros

2020-06-05 Thread Adhemerval Zanella
On 01/06/2020 19:18, Vineet Gupta wrote: > This is purely for review purposes to attest the interface defined > in prior patch LGTM with some style nits, however I think it should be pushed along with the ARC patchset. Reviewed-by: Adhemerval Zanella > --- > sysdeps/arc/dl-runtime.h | 42 +

Re: [PATCH v2 1/2] dl-runtime: reloc_{offset,index} now functions arch overide'able

2020-06-05 Thread Adhemerval Zanella
On 01/06/2020 19:18, Vineet Gupta wrote: > The existing macros are fragile and expect local variables with a > certain name. Fix this by defining them as functions with default > implementation in a new header dl-runtime.h which arches can override > if need be. > > This came up during ARC port

Re: [PATCH v2 0/2] rework dl-runtime: reloc_{offset,index}

2020-06-05 Thread Vineet Gupta
On 6/1/20 3:18 PM, Vineet Gupta via Libc-alpha wrote: > Vineet Gupta (2): > dl-runtime: reloc_{offset,index} now functions arch overide'able > ARC/dl-runtime helper macros > > elf/dl-runtime.c| 28 +++-- > elf/dl-runtime.h| 30 ++

Re: [PATCH v6 06/13] ARC: hardware floating point support

2020-06-05 Thread Adhemerval Zanella
On 05/06/2020 01:44, Vineet Gupta wrote: > On 5/29/20 4:50 PM, Vineet Gupta via Libc-alpha wrote: Although this code follow other architectures, I think it woudl be better to move forward a macro that emulates function calls and use proper static inline function instead for _FPU_*

RE: [PATCH v2 1/4] ARC: allow to override default mcpu compiler flag

2020-06-05 Thread Alexey Brodkin
Hi Eugeniy, A couple of minor notes below. > -Original Message- > From: Eugeniy Paltsev > Sent: Thursday, June 4, 2020 8:39 PM > To: linux-snps-arc@lists.infradead.org; Vineet Gupta > Cc: linux-ker...@vger.kernel.org; Alexey Brodkin ; > Eugeniy Paltsev > > Subject: [PATCH v2 1/4] ARC: