Re: [RFC v6 07/23] RISC-V: Use 64-bit time_t and off_t for RV32 and RV64

2020-02-18 Thread Vineet Gupta
On 2/18/20 5:03 PM, Alistair Francis wrote: >>> +#define STAT_IS_KERNEL_STAT 1 >> Isn't this irrelevant: seems to be only used for legacy __NR_stat/__NR_stat64 >> syscalls based__xstat()/__xstat64(). > Is it? It seems to be used in a few places, including: > > sysdeps/unix/sysv/linux/fxstatat.c >

[PATCH] Remove STATFS_IS_STATFS64 conditional as it is zero in all ports

2020-02-18 Thread Vineet Gupta
Signed-off-by: Vineet Gupta --- sysdeps/unix/sysv/linux/alpha/kernel_stat.h | 1 - sysdeps/unix/sysv/linux/fstatfs64.c | 14 -- sysdeps/unix/sysv/linux/generic/kernel_stat.h | 2 -- .../unix/sysv/linux/generic/wordsize-32/fstatfs.c | 2 -- .../unix/sysv/linu

Re: [RFC v6 07/23] RISC-V: Use 64-bit time_t and off_t for RV32 and RV64

2020-02-18 Thread Alistair Francis
On Tue, Feb 18, 2020 at 4:57 PM Vineet Gupta wrote: > > Hi Alistair, > > On 1/12/20 2:33 AM, Alistair Francis wrote: > > diff --git a/sysdeps/unix/sysv/linux/riscv/kernel_stat.h > > b/sysdeps/unix/sysv/linux/riscv/kernel_stat.h > > [snip]... > > > +#define STAT_IS_KERNEL_STAT 1 > > Isn't this irr

Re: [RFC v6 07/23] RISC-V: Use 64-bit time_t and off_t for RV32 and RV64

2020-02-18 Thread Vineet Gupta
Hi Alistair, On 1/12/20 2:33 AM, Alistair Francis wrote: > diff --git a/sysdeps/unix/sysv/linux/riscv/kernel_stat.h > b/sysdeps/unix/sysv/linux/riscv/kernel_stat.h [snip]... > +#define STAT_IS_KERNEL_STAT 1 Isn't this irrelevant: seems to be only used for legacy __NR_stat/__NR_stat64 syscalls

Re: switching ARC to 64-bit time_t (Re: [RFC v6 07/23] RISC-V: Use 64-bit time_t and off_t for RV32 and RV64)

2020-02-18 Thread Joseph Myers
On Tue, 18 Feb 2020, Vineet Gupta wrote: > An the reason this all works on RISCV is that your kernel doesn't define > __ARCH_WANT_STAT64 -> lacks __NR_statat64 and instead uses the statx call > which > does itemized copy and would work fine when copying from 32-bits time (in > kernel) > to 64-bi

switching ARC to 64-bit time_t (Re: [RFC v6 07/23] RISC-V: Use 64-bit time_t and off_t for RV32 and RV64)

2020-02-18 Thread Vineet Gupta
Hi Alistair, Arnd On 2/14/20 2:39 PM, Alistair Francis wrote: > On Tue, Feb 11, 2020 at 5:30 PM Joseph Myers wrote: >> On Tue, 11 Feb 2020, Alistair Francis wrote: >> > diff --git a/sysdeps/unix/sysv/linux/riscv/bits/typesizes.h > b/sysdeps/unix/sysv/linux/riscv/bits/typesizes.h > ne