Re: [PATCH 04/26] mips: remove ioremap_cachable

2019-08-19 Thread Paul Burton
Hi Christoph, On Sat, Aug 17, 2019 at 09:32:31AM +0200, Christoph Hellwig wrote: > Just define ioremap_cache directly. > > Signed-off-by: Christoph Hellwig Acked-by: Paul Burton Thanks, Paul > --- > arch/mips/include/asm/io.h | 7 +++ > 1 file changed, 3 insertions(+), 4 deletions(-

Re: [PATCH 08/26] m68k: simplify ioremap_nocache

2019-08-19 Thread Christoph Hellwig
On Mon, Aug 19, 2019 at 10:56:02AM +0200, Geert Uytterhoeven wrote: > BTW, shouldn't we get rid of the sole user of ioremap_uc(), too? > Seems to make a difference on x86 only, where it is "strongly uncached" > (whatever that may mean ;-) Yes, we probably should. However that actually seems worth

Re: [PATCH 18/26] m68k: rename __iounmap and mark it static

2019-08-19 Thread Geert Uytterhoeven
Hi Christoph, On Sat, Aug 17, 2019 at 9:49 AM Christoph Hellwig wrote: > m68k uses __iounmap as the name for an internal helper that is only > used for some CPU types. Mark it static and give it a better name. > > Signed-off-by: Christoph Hellwig Thanks for your patch! > --- a/arch/m68k/mm/km

Re: [PATCH 08/26] m68k: simplify ioremap_nocache

2019-08-19 Thread Geert Uytterhoeven
Hi Christoph, On Sat, Aug 17, 2019 at 9:48 AM Christoph Hellwig wrote: > Just define ioremap_nocache to ioremap instead of duplicating the > inline. Also defined ioremap_uc in terms of ioremap instead of > the using a double indirection. > > Signed-off-by: Christoph Hellwig Acked-by: Geert Uyt

Re: [PATCH 03/26] m68k, microblaze: remove ioremap_fullcache

2019-08-19 Thread Geert Uytterhoeven
On Sat, Aug 17, 2019 at 9:41 AM Christoph Hellwig wrote: > No callers of this function. > > Signed-off-by: Christoph Hellwig > arch/m68k/include/asm/kmap.h | 7 --- Acked-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots o

Re: [PATCH 19/26] arm64: remove __iounmap

2019-08-19 Thread Will Deacon
On Sat, Aug 17, 2019 at 09:32:46AM +0200, Christoph Hellwig wrote: > No need to indirect iounmap for arm64. > > Signed-off-by: Christoph Hellwig > --- > arch/arm64/include/asm/io.h | 3 +-- > arch/arm64/mm/ioremap.c | 4 ++-- > 2 files changed, 3 insertions(+), 4 deletions(-) Not sure why w