Re: [PATCH] treewide: remove current_text_addr

2018-08-31 Thread Nick Desaulniers
On Mon, Aug 27, 2018 at 6:34 AM H. Peter Anvin wrote: > > On 08/27/18 06:11, Peter Zijlstra wrote: > > On Mon, Aug 27, 2018 at 05:26:53AM -0700, H. Peter Anvin wrote: > > > >> _THIS_IP_, however, is completely ill-defined, other than being an > >> address *somewhere* in the same global function (n

Re: Patch "asm-generic/bitops/lock.h: Rewrite using atomic_fetch_" causes kernel crash

2018-08-31 Thread Will Deacon
On Fri, Aug 31, 2018 at 12:30:50AM +, Vineet Gupta wrote: > On 08/30/2018 01:45 PM, Peter Zijlstra wrote: > >> > >> Indeed this is the mother of all issues, I tried and system is clearly > >> hosed with > >> and works after. > >> What's amazing is the commit 4aef66c8ae9 which introduced it is

Re: __clear_bit_lock to use atomic clear_bit (was Re: Patch "asm-generic/bitops/lock.h)

2018-08-31 Thread Peter Zijlstra
On Fri, Aug 31, 2018 at 12:29:27AM +, Vineet Gupta wrote: > On 08/30/2018 02:44 AM, Peter Zijlstra wrote: > >> Back in 2016, Peter had fixed this file due to a problem I reported on > >> ARC. See > >> commit f75d48644c56a ("bitops: Do not default to __clear_bit() for > >> __clear_bit_unlock()"