Re: [PATCH] treewide: remove current_text_addr

2018-08-25 Thread H. Peter Anvin
On 08/25/18 20:16, H. Peter Anvin wrote: > On 08/25/18 19:38, H. Peter Anvin wrote: >> >> If it was worthwhile it would make more sense to at least force this >> into the rodata section with the string, something like the attached >> file for an example; however, I have a hunch it doesn't matter. >

Re: [PATCH] treewide: remove current_text_addr

2018-08-25 Thread H. Peter Anvin
On 08/25/18 19:38, H. Peter Anvin wrote: > > If it was worthwhile it would make more sense to at least force this > into the rodata section with the string, something like the attached > file for an example; however, I have a hunch it doesn't matter. > An even nuttier version which avoids the ext

Re: [PATCH] treewide: remove current_text_addr

2018-08-25 Thread H. Peter Anvin
On 08/25/18 03:48, Helge Deller wrote: > > Currently alpha, s390, sparc, sh, c6x, ia64 and parisc provide an > inline assembly function to get the current instruction pointer. > As mentioned in an earlier thread, I personally would *prefer* if > _THIS_IP_ would use those inline assembly instruct

Re: [PATCH 6/8] kbuild: consolidate Devicetree dtb build rules

2018-08-25 Thread Masahiro Yamada
Hi Rob, 2018-08-22 6:55 GMT+09:00 Rob Herring : > There is nothing arch specific about building dtb files other than their > location under /arch/*/boot/dts/. Keeping each arch aligned is a pain. > The dependencies and supported targets are all slightly different. > Also, a cross-compiler for eac

Re: [PATCH] treewide: remove current_text_addr

2018-08-25 Thread Linus Torvalds
On Tue, Aug 21, 2018 at 1:31 PM Nick Desaulniers wrote: > > I suspect that current_text_addr predated GNU C extensions for statement > expressions and/or taking the address of a label, then the macro was > reimplemented for every new archs include/asm/processor.h, even though > there were very few

Re: [PATCH] treewide: remove current_text_addr

2018-08-25 Thread Helge Deller
On 21.08.2018 22:28, Nick Desaulniers wrote: > Prefer _THIS_IP_ defined in linux/kernel.h. > > Most definitions of current_text_addr were the same as _THIS_IP_, but > a few archs had inline assembly instead. > > This patch removes the final call site of current_text_addr, making all > of the defi