Re: [PATCH v2 2/4] ARC: allow to use IOC and non-IOC DMA devices simultaneously

2018-08-20 Thread Vineet Gupta
On 08/13/2018 10:08 AM, Eugeniy Paltsev wrote: > On Mon, 2018-08-13 at 16:24 +, Vineet Gupta wrote: >> On 07/30/2018 09:26 AM, Eugeniy Paltsev wrote: >>> @@ -1263,11 +1254,7 @@ void __init arc_cache_init_master(void) >>> if (is_isa_arcv2() && ioc_enable) >>> arc_ioc_setup(); >>>

Re: [PATCH 1/2] gpio: tb10x: Create local helper variables

2018-08-20 Thread Christian Ruppert
Acked-by: Christian Ruppert On 06.08.2018 17:12, Linus Walleij wrote: > Create a local struct device *dev helper variable to make the code > easier to read. > > Most GPIO drivers use "np" (node pointer) rather than "dn" (device node) > to point to the device tree node. Let's follow this conventi

Re: [PATCH] gpio: tb10x: Use the right include

2018-08-20 Thread Christian Ruppert
Acked-by: Christian Ruppert On 06.08.2018 16:23, Linus Walleij wrote: > This driver includes the legacy and > but all it needs is really . > > Cc: linux-snps-arc@lists.infradead.org > Cc: Christian Ruppert > Signed-off-by: Linus Walleij > --- > drivers/gpio/gpio-tb10x.c | 3 +-- > 1 file ch

Re: [PATCH 2/2] gpio: tb10x: Use GENERIC_GPIO

2018-08-20 Thread Christian Ruppert
Acked-by: Christian Ruppert On 06.08.2018 17:12, Linus Walleij wrote: > Instead of open coding logic for reading and writing GPIO lines, > use the generic GPIO library. Also switch to using the spinlock > from the generic GPIO to protect the registers. > > Cc: linux-snps-arc@lists.infradead.org