Re: [RESEND PATCH v2] devres: Really align data field to unsigned long long

2018-07-08 Thread Alexey Brodkin
Hi Greg, On Mon, 2018-07-09 at 07:48 +0200, Greg KH wrote: > On Mon, Jul 09, 2018 at 07:44:44AM +0300, Alexey Brodkin wrote: > > Depending on ABI "long long" type of a particular 32-bit CPU > > might be aligned by either word (32-bits) or double word (64-bits). > > Make sure "data" is really 64-bi

Re: [RESEND PATCH v2] devres: Really align data field to unsigned long long

2018-07-08 Thread Greg KH
On Mon, Jul 09, 2018 at 07:44:44AM +0300, Alexey Brodkin wrote: > Depending on ABI "long long" type of a particular 32-bit CPU > might be aligned by either word (32-bits) or double word (64-bits). > Make sure "data" is really 64-bit aligned for any 32-bit CPU. > > At least for 32-bit ARC cores ABI

[RESEND PATCH v2] devres: Really align data field to unsigned long long

2018-07-08 Thread Alexey Brodkin
Depending on ABI "long long" type of a particular 32-bit CPU might be aligned by either word (32-bits) or double word (64-bits). Make sure "data" is really 64-bit aligned for any 32-bit CPU. At least for 32-bit ARC cores ABI requires "long long" types to be aligned by normal 32-bit word. This make

Re: [PATCH v2] devres: Really align data field to unsigned long long

2018-07-08 Thread Greg KH
On Sun, Jul 08, 2018 at 09:45:31PM +0300, Алексей Бродкин wrote: > Hi Greg, > > вс, 8 июл. 2018 г. в 21:40, Greg KH : > > > > On Sun, Jul 08, 2018 at 08:56:21PM +0300, Alexey Brodkin wrote: > > > Depending on ABI "long long" type of a particular 32-bit CPU > > > might be aligned by either word (32

Re: [PATCH v2] devres: Really align data field to unsigned long long

2018-07-08 Thread Алексей Бродкин
Hi Greg, вс, 8 июл. 2018 г. в 21:40, Greg KH : > > On Sun, Jul 08, 2018 at 08:56:21PM +0300, Alexey Brodkin wrote: > > Depending on ABI "long long" type of a particular 32-bit CPU > > might be aligned by either word (32-bits) or double word (64-bits). > > Make sure "data" is really 64-bit aligned

Re: [PATCH v2] devres: Really align data field to unsigned long long

2018-07-08 Thread Greg KH
On Sun, Jul 08, 2018 at 08:56:21PM +0300, Alexey Brodkin wrote: > Depending on ABI "long long" type of a particular 32-bit CPU > might be aligned by either word (32-bits) or double word (64-bits). > Make sure "data" is really 64-bit aligned for any 32-bit CPU. > > At least for 32-bit ARC cores ABI

[PATCH v2] devres: Really align data field to unsigned long long

2018-07-08 Thread Alexey Brodkin
Depending on ABI "long long" type of a particular 32-bit CPU might be aligned by either word (32-bits) or double word (64-bits). Make sure "data" is really 64-bit aligned for any 32-bit CPU. At least for 32-bit ARC cores ABI requires "long long" types to be aligned by normal 32-bit word. This make