On Tue, May 08, 2018 at 11:05:20AM +0100, Robin Murphy wrote:
> On 24/04/18 15:02, Christoph Hellwig wrote:
>> Only used by the AMD GART driver, which must be built in.
>
> FWIW debug_dma_dump_mappings() is also called by the Intel VT-d driver, but
> the same reasoning still applies.
I'll update
Hi Christoph,
On 2018-04-24 16:02, Christoph Hellwig wrote:
> Most mainstream architectures are using 65536 entries, so lets stick to
> that. If someone is really desperate to override it that can still be
> done through , but I'd rather see a really good
> rationale for that.
>
> dma_debug_init
On 24/04/18 15:02, Christoph Hellwig wrote:
Only used by the AMD GART driver, which must be built in.
FWIW debug_dma_dump_mappings() is also called by the Intel VT-d driver,
but the same reasoning still applies. This does rather beg the question
of whether it's right to have bits of low-level
On 27/04/18 16:53, Christoph Hellwig wrote:
There is no arch specific code required for dma-debug, so there is no
need to opt into the support either.
Makes sense, and a purely negative diffstat is always pleasing :)
Reviewed-by: Robin Murphy
Signed-off-by: Christoph Hellwig
---
.../io/d
On 24/04/18 15:02, Christoph Hellwig wrote:
Just keep a single variable with a descriptive name instead of two
with confusing names.
Reviewed-by: Robin Murphy
Signed-off-by: Christoph Hellwig
---
lib/dma-debug.c | 20
1 file changed, 4 insertions(+), 16 deletions(-)
On 24/04/18 15:02, Christoph Hellwig wrote:
Most mainstream architectures are using 65536 entries, so lets stick to
that. If someone is really desperate to override it that can still be
done through , but I'd rather see a really good
rationale for that.
dma_debug_init is now called as a core_in
