Re: [PATCH v5 1/2] PCI support added to ARC

2016-01-14 Thread Vineet Gupta
On Thursday 14 January 2016 05:29 PM, Arnd Bergmann wrote: > On Thursday 14 January 2016 10:51:32 Vineet Gupta wrote: A somewhat nicer method would be to have callback pointers in struct pci_host_bridge, and call those when they are non-NULL so we can remove the global pcibios_*

Re: [PATCH v5 1/2] PCI support added to ARC

2016-01-14 Thread Arnd Bergmann
On Thursday 14 January 2016 10:51:32 Vineet Gupta wrote: > >> > >> A somewhat nicer method would be to have callback pointers in struct > >> pci_host_bridge, and call those when they are non-NULL so we can > >> remove the global pcibios_* functions from the API. That would also > >> bring us a big

Re: [PATCH v6 1/2] PCI support added to ARC

2016-01-14 Thread Vineet Gupta
On Thursday 14 January 2016 04:34 PM, Joao Pinto wrote: This patch adds PCI support to ARC and updates drivers/pci Makefile enabling the ARC arch to use the generic PCI setup functions. Signed-off-by: Joao Pinto Acked-by: Vineet Gupta @B

Re: [PATCH v5 1/2] PCI support added to ARC

2016-01-14 Thread Joao Pinto
Hi, On 1/14/2016 10:51 AM, Vineet Gupta wrote: > On Thursday 14 January 2016 04:12 PM, Joao Pinto wrote: >> Hi, >> >> On 1/14/2016 10:22 AM, Arnd Bergmann wrote: >>> On Thursday 14 January 2016 05:26:58 Vineet Gupta wrote: > +/* > + * We don't have to worry about legacy ISA devices, so no

Re: [PATCH v5 1/2] PCI support added to ARC

2016-01-14 Thread Vineet Gupta
On Thursday 14 January 2016 04:12 PM, Joao Pinto wrote: > Hi, > > On 1/14/2016 10:22 AM, Arnd Bergmann wrote: >> On Thursday 14 January 2016 05:26:58 Vineet Gupta wrote: +/* + * We don't have to worry about legacy ISA devices, so nothing to do here + */ +resource_size_t pcibios_

Re: [PATCH v5 1/2] PCI support added to ARC

2016-01-14 Thread Joao Pinto
Hi, On 1/14/2016 10:22 AM, Arnd Bergmann wrote: > On Thursday 14 January 2016 05:26:58 Vineet Gupta wrote: >>> +/* >>> + * We don't have to worry about legacy ISA devices, so nothing to do here >>> + */ >>> +resource_size_t pcibios_align_resource(void *data, const struct resource >>> *res, >>> +

Re: [PATCH v5 1/2] PCI support added to ARC

2016-01-14 Thread Arnd Bergmann
On Thursday 14 January 2016 05:26:58 Vineet Gupta wrote: > > +/* > > + * We don't have to worry about legacy ISA devices, so nothing to do here > > + */ > > +resource_size_t pcibios_align_resource(void *data, const struct resource > > *res, > > + resource_size_t size, r