On 10/23/15 11:14, Krzysztof Kozlowski wrote:
> On 23.10.2015 11:01, Jaehoon Chung wrote:
>> Exynos3250 and exnos5250 are some differences in Mobile Storage Host.
>> (For example, exynos3250 support the HS400 mode, but exynos5250 doesn't
>> support it.)
>> Exynos3250 can perform the similar functio
Alim Akhtar wrote:
>
> Gentle Ping !!
>
Thanks ;-)
>
> On Wed, Mar 18, 2015 at 4:50 PM, Alim Akhtar wrote:
> > From: Seungwon Jeon
> >
> > HS400 timing values are added for SMDK5420, exynos5420-peach-pit
> > and exynos5800-peach-pi boards.
> > This also adds RCLK GPIO line, this gpio should be
Alim Akhtar wrote:
>
> Ping?
>
Alim,
Can you please re-send it based on latest my tree?
It would be helpful for me ;)
Thanks,
Kukjin
> On Wed, Feb 25, 2015 at 12:05 PM, Jaehoon Chung
> wrote:
> > Hi, Alim.
> >
> > Acked-by: Jaehoon Chung
> >
> > Best Regards,
> > Jaehoon Chung
> >
> > On 01
On 02/02/15 17:51, Javier Martinez Canillas wrote:
> Hello Marek,
>
Hi Marek,
> On Mon, Feb 2, 2015 at 9:33 AM, Marek Szyprowski
> wrote:
>> Hello,
>>
>> This patchset adds new mmc power sequence driver, which performs eMMC
>> card hardware reset. Such power sequence, involving resetting emmc ca
On 02/05/15 00:06, Javier Martinez Canillas wrote:
> Hello Kukjin,
>
Hi,
> On 01/30/2015 02:06 PM, Javier Martinez Canillas wrote:
>> On 01/30/2015 12:13 PM, Ulf Hansson wrote:
Patch #1 extends the simple MMC power sequence DT binding to support more
than one GPIO and patch #2 adds
On 01/14/15 22:32, Jaehoon Chung wrote:
> Hi, Alim.
>
> On 01/14/2015 07:30 PM, Alim Akhtar wrote:
>> This adds HS400 mode support for exynos dw_mmc host controller.
>>
>> Currently tested on Exynos5800-peach-pi platform for HS400 mode.
>> Tested HS200 mode with this series applied, HS200 still wo
On 08/18/14 12:06, Andreas Färber wrote:
Am 18.08.2014 18:54, schrieb Kukjin Kim:
On 08/18/14 09:10, Andreas Färber wrote:
Hi Jaehoon,
Am 18.08.2014 14:23, schrieb Jaehoon Chung:
Socfpga and Rockchip were queued into each SoC tree.
I want to know whether this patch is queued or not into
On 08/18/14 09:10, Andreas Färber wrote:
Hi Jaehoon,
Am 18.08.2014 14:23, schrieb Jaehoon Chung:
Socfpga and Rockchip were queued into each SoC tree.
I want to know whether this patch is queued or not into Samsung-Soc tree.
Do you have any other plan for this patch?
It isn't applied in his tr
On 08/01/14 01:02, Doug Anderson wrote:
Jaehoon
On Wed, Jul 30, 2014 at 10:35 PM, Jaehoon Chung wrote:
Slot quirks "disable-wp" is deprecated.
Instead, use the host quirk "disable-wp".
(Because the slot-node is removed in dt-file.)
Signed-off-by: Jaehoon Chung
Tested-by: Sachin Kamat
Acked-by
On 08/01/14 01:02, Doug Anderson wrote:
Jaehoon
On Wed, Jul 30, 2014 at 10:35 PM, Jaehoon Chung wrote:
Slot quirks "disable-wp" is deprecated.
Instead, use the host quirk "disable-wp".
(Because the slot-node is removed in dt-file.)
Signed-off-by: Jaehoon Chung
Tested-by: Sachin Kamat
Acked-by
plied for 3.16-rcX fix.
> > (Also, 3rd patch is close to fix patch.)
> >
> > Kukjin,
> > Is it fine to be taken in Ulf's?
>
> I tried applied the complete patchset for 3.16 rc4, but some of the
> DTS patches fails. What are these patches ba
Yuvaraj Kumar C D wrote:
>
+ Doug
Hi,
> This patch updates hs-200 device tree property from
> caps2-mmc-hs200-1.8v to mmc-hs200-1.8v for peach-pit
> and peach-pi boards.
>
> Signed-off-by: Yuvaraj Kumar C D
Already I've queued same patch into my local but waiting for dependencies for
push to
Sonny Rao wrote:
>
> This patch changes the fifo reset code to follow the reset procedure
> outlined in the documentation of Synopsys Mobile storage host databook
> 7.2.13.
>
> v2: Add Generic DMA support
> per the documentation, move interrupt clear before wait
> make the test for DMA h
Kukjin Kim wrote:
>
> Sylwester Nawrocki wrote:
> >
> > Hi,
> >
> Hi,
>
> > On 02/02/2013 01:45 AM, Kukjin Kim wrote:
> > > Since mach/regs-sdi.h is used only for s3cmci.c, so this moves the
> > > header file into the driver file, drivers/mmc
Sylwester Nawrocki wrote:
>
> Hi,
>
Hi,
> On 02/02/2013 01:45 AM, Kukjin Kim wrote:
> > Since mach/regs-sdi.h is used only for s3cmci.c, so this moves the
> > header file into the driver file, drivers/mmc/host/s3cmci.c file.
> >
> > Signed-off-by: Kukjin Ki
Since mach/regs-sdi.h is used only for s3cmci.c, so this moves the
header file into the driver file, drivers/mmc/host/s3cmci.c file.
Signed-off-by: Kukjin Kim
---
arch/arm/mach-s3c24xx/dma-s3c2410.c |1 -
arch/arm/mach-s3c24xx/dma-s3c2412.c |1 -
arch/arm/mach
dcc
>
> After applied that patch, it needs not to set MMC_CAP2_BROKEN_VOLTAGE.
>
Yeah, we don't need more this. This will be queued into -late branch for
v3.7 or can be queued into cleanup for next merge window because this is not
critical.
Thanks.
Best regards,
Kgene.
--
Kukjin
es will need to defined new callbacks
> which I fell is not really required.
>
Yes.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim , Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" i
in to 3.4. I think you should
just drop this patchset from your tree in linux-next entirely now.
Yep, I dropped it in my -next.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim , Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
--
To unsubscribe from this list: send the l
On 03/28/12 02:54, Mark Brown wrote:
On Tue, Mar 27, 2012 at 11:50:24AM -0400, Chris Ball wrote:
On Tue, Feb 21 2012, Chris Ball wrote:
On Tue, Feb 21 2012, Kukjin Kim wrote:
I created topic branch for this we talked. You can pull that following:
git://git.kernel.org/pub/scm/linux/kernel
es broken build for pre-Exynos SoCs.
I think, it is protected by CONFIG_OF and the pre-EXYNOS SoCs is not
support device tree yet. Could you please let me know the build error
and build condition?
Thanks.
Best regards,
Kgene.
--
Kukjin Kim , Senior Engineer,
SW Solution Development Team, Samsung
On 03/07/12 06:01, Marek Szyprowski wrote:
Hello,
On Wednesday, March 07, 2012 2:20 PM Kukjin Kim wrote:
On 03/06/12 01:51, Kukjin Kim wrote:
On 03/05/12 18:29, Jaehoon Chung wrote:
Hi Kukjin.
Is it merged?
Best Regards,
Jaehoon Chung
On 02/24/2012 06:56 PM, Thomas Abraham wrote:
On 23
On 03/06/12 01:51, Kukjin Kim wrote:
On 03/05/12 18:29, Jaehoon Chung wrote:
Hi Kukjin.
Is it merged?
Best Regards,
Jaehoon Chung
On 02/24/2012 06:56 PM, Thomas Abraham wrote:
On 23 February 2012 11:18, Jaehoon Chung wrote:
Thomas Arbrahams's patchset have changed the device name in
universal_c210.c
@@ -749,7 +749,7 @@ static struct s3c_sdhci_platdata universal_hsmmc0_data
__initdata = {
};
static struct regulator_consumer_supply mmc0_supplies[] = {
- REGULATOR_SUPPLY("vmmc", "s3c-sdhci.0"),
+ REGULATOR_SUPPLY("vmmc", "exynos4-sdh
le for you to test/review the patch?
Hi Chris,
Maybe I lost Mark's runtime PM supporting patches. I couldn't find it in
my mail box. Sorry for that :(
Mark, could you please send it to me again?
Thanks.
Best regards,
Kgene.
--
Kukjin Kim , Senior Engineer,
SW Solution Development
Chris Ball wrote:
>
> Hi,
>
Hi,
> On Thu, Feb 16 2012, Kukjin Kim wrote:
> > I mean if I or you create topic branch for this whole series, can be
> > merged into both tree for avoiding conflicts with further working. Of
> > course, the topic branch don't hav
On 02/12/12 06:37, Chris Ball wrote:
Hi,
On Thu, Feb 09 2012, Kukjin Kim wrote:
Looks ok to me and I'd like to pick this series in samsung tree with Chris'
ack.
Chris, is it ok? If you need to merge this in your tree, please let me know.
I will provide topic branch for it.
If an
deletions(-)
create mode 100644 include/linux/mmc/sdhci-s3c.h
Hi,
I don't agree with this.
Basically, the components(struct s3c_sdhci_platdata and some enums) you
moved here are just for platform data on each board in arch/arm/.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim , Senior Eng
after S3C64XX or just for S3C64XX, so need to check data sheet of
SDHCI part for S3C24XX and S3C64XX and later.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim , Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
--
To unsubscribe from this list: send the line "unsubscribe lin
gt; create mode 100644 Documentation/devicetree/bindings/mmc/samsung-
> sdhci.txt
Hi,
Looks ok to me and I'd like to pick this series in samsung tree with Chris'
ack.
Chris, is it ok? If you need to merge this in your tree, please let me know.
I will provide topic bra
t->mmc->caps |= pdata->host_caps;
> >
> > + if (pdata->host_caps2)
> > + host->mmc->caps2 |= pdata->host_caps2;
> > +
> > ret = sdhci_add_host(host);
> > if (ret) {
> > dev_err(dev, "sdhci_add_host
t;
Yeah, you're right. They in Samsung directories are not used anywhere else. So
statically declaration can be used.
As a note, I always run checkpatch but sparse before applying but
unfortunately, checkpatch didn't complain about that.
Let me check where fixes are needed in Sam
Russell King wrote:
>
> Signed-off-by: Russell King
Acked-by: Kukjin Kim
Thanks.
Best regards,
Kgene.
--
Kukjin Kim , Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
> ---
> arch/arm/mach-exynos/dma.c | 38 ++
Russell King wrote:
>
> Signed-off-by: Russell King
Acked-by: Kukjin Kim
Thanks.
Best regards,
Kgene.
--
Kukjin Kim , Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
> ---
> arch/arm/mach-exynos/dma.c |4 ++--
> arch/arm/mach-s5p64
H v2 1/2] ARM: SAMSUNG: Add
pm_caps into platform data' with my ack?
If any problems, please let me know.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim , Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
--
To unsubscribe from this list: send the line "unsubscrib
Sangwook Lee wrote:
>
> sdhci-s3c updates pm_caps from platform data for SDIO PM.
>
> Signed-off-by: Sangwook Lee
Acked-by: Kukjin Kim
Hi Chris,
Could you please pick this up in your tree for v3.3?
Thanks.
Best regards,
Kgene.
--
Kukjin Kim , Senior Engineer,
SW Solution Deve
+68,7 @@ enum clk_types {
> struct s3c_sdhci_platdata {
> unsigned intmax_width;
> unsigned inthost_caps;
> + unsigned intpm_caps;
> enum cd_types cd_type;
> enum clk_types clk_type;
>
> --
> 1.7.4.1
Hi Sangwook,
I think you n
MMC..this field is
necessary)
>
Hi,
This description is better than previous.
However, I wonder this is _really_ used for eMMC at sdhci-s3c.c driver.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim , Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
> Signed-off-by:
Chris Ball wrote:
>
> Hi Kukjin,
>
> On Wed, Nov 02 2011, Kukjin Kim wrote:
> >> This patch modifies the driver to stop depending on the clock names
> >> being passed from the platform and switch over to bus clock lookup
> >> using generic clock names.
>
Jaehoon Chung wrote:
>
>
Well...
Firstly, you need to add description here why this change is needed.
Secondly, you need to check latest maintainer's tree, in this case, the
dev-xxx.c are merged into plat-samsung/devs.c ago.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim , Senior E
l.
>
> Signed-off-by: Rajeshwari Shinde
Acked-by: Kukjin Kim
Hi Chirs,
Could you please pick this up in your tree for this merge window?
Thanks.
Best regards,
Kgene.
--
Kukjin Kim , Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
> ---
> drivers/mmc/hos
lease add this in your tree for
this merge window? or if you want, I will apply this to Samsung tree
with other Rajeshwari's patches. I'm ok either...
Thanks.
Best regards,
Kgene.
--
Kukjin Kim , Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
--
To
Chris Ball wrote:
>
> Hi,
>
> On Wed, Sep 21 2011, Kukjin Kim wrote:
> > Acked-by: Kukjin Kim
> >
> > Hi Chris,
> >
> > This is ok to me. Could you please pick this up in your tree so that I
can
> > pick 2nd patch up in my tree.
> >
> >
Thomas Abraham wrote:
>
> The default controller configuration which was previously setup by
> platform helper functions is moved into the driver.
>
> Cc: Ben Dooks
> Signed-off-by: Thomas Abraham
Acked-by: Kukjin Kim
Hi Chris,
This is ok to me. Could you please pick th
n tested on the following platforms.
> SMDK2416, SMDK6410, SMDKC100, SMDKV210 and SMDKV310.
Oh, I found :)
Looks ok to me, will apply.
As a note, please kindly ignore previous my comments on v.1 patch.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim , Senior Engineer,
SW Solution Development Team, Samsung
Thomas Abraham wrote:
>
> Dear Mr. Kim,
>
> On 5 September 2011 10:46, Kukjin Kim wrote:
> > Thomas Abraham wrote:
> >>
> >> The sdhci platform helper function that sets up the default controller
> >> configuration is removed for all Samsung
_setup_sdhci_cfg_card;
> #endif
> }
>
> @@ -341,17 +293,11 @@ static inline void s5pv210_default_sdhci3(void) { }
> #ifdef CONFIG_EXYNOS4_SETUP_SDHCI
> extern char *exynos4_hsmmc_clksrcs[4];
>
> -extern void exynos4_setup_sdhci_cfg_card(struct platform_device *dev,
&
< 25 * 100)
> + ctrl |= (S3C_SDHCI_CTRL3_FCSEL3 |
> S3C_SDHCI_CTRL3_FCSEL2);
> + writel(ctrl, host->ioaddr + S3C_SDHCI_CONTROL3);
> }
>
> /**
> --
Basically, it's good to move common codes and to remove that. But I'm not
sure we don't _
/* R/W */
> @@ -293,6 +296,7 @@ struct _mmc_csd {
> #define EXT_CSD_SEC_ERASE_MULT 230 /* RO */
> #define EXT_CSD_SEC_FEATURE_SUPPORT 231 /* RO */
> #define EXT_CSD_TRIM_MULT232 /* RO */
> +#define EXT_CSD_CMD6_TIME248 /* RO
From: Wonil Choi
Signed-off-by: Wonil Choi
Signed-off-by: Minho Ban
Cc: Ben Dooks
Signed-off-by: Kukjin Kim
---
drivers/mmc/host/sdhci-s3c.c |6 ++
1 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/mmc/host/sdhci-s3c.c b/drivers/mmc/host/sdhci-s3c.c
index
Kyungmin Park wrote:
>
> On Fri, Mar 11, 2011 at 11:30 AM, Kukjin Kim
wrote:
> > Kyungmin Park wrote:
> >>
> >> From: Kyungmin Park
> >>
> >> Exynos4 has the DesignWare Host controller at channel 4.
> >>
> > Yeah, Exynos4210 ha
other file, eg., dev-dwmmc.c or dev-dwmci.c should be added for its
platform devices.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim , Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
> Signed-off-by: Kyungmin Park
> ---
> diff --git a/arch/arm/mach-exynos4/includ
this and we'll adopt
and test it on our platform.
Thanks and Happy New year!
Best regards,
Kgene.
--
Kukjin Kim , Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
1bit, 4bit and 8bit bus width with SDR/DDR
but it has some hardware limititation with 8bit DDR mode now.
So, needs later version of mshci so that can be work it with
this code.
Signed-off-by: Hyunsung Jang
Signed-off-by: Hyuk Lee
Signed-off-by: Kukjin Kim
---
drivers/mmc/host/Kconfig | 1
e MMC maintainer, Chris' response(or any other response) about
this.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim , Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
simply proceed on your own.
Hi Chris,
How was going on?
I couldn't find this in your tree yet :-(
Please let me know about your merge plan of this.
If any problems, please kindly let me know :-)
Ben,
If you're ok this to you, please send your ack...
it would be helpful to Chris to h
g into my tree for 37
merge window.
...
Ben, could you please check this patch?...this is ok to me for Samsung
HSMMC...if any opinions, please kindly let us know.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim , Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
--
oller.
Signed-off-by: Jeongbae Seo
Cc: Jaehoon Chung
Cc: Kyungmin Park
Cc: Ben Dooks
Signed-off-by: Kukjin Kim
---
Changes since v4:
- Added missing change
Changes since v3:
- Modified comparision condition as per Kyungmin Park's suggestion
Changes since v2:
- Changed clock control
oller.
Signed-off-by: Jeongbae Seo
Cc: Jaehoon Chung
Cc: Kyungmin Park
Cc: Ben Dooks
Signed-off-by: Kukjin Kim
---
Changes since v3:
- Modified comparision condition as per Kyungmin Park's suggestion
Changes since v2:
- Changed clock control method to overriding from using quirk
- Thi
oller.
Signed-off-by: Jeongbae Seo
Cc: Jaehoon Chung
Cc: Ben Dooks
Signed-off-by: Kukjin Kim
---
Changes since v2:
- Changed clock control method to overriding from using quirk
- This patch is referred from that of Jaehoon Chung's support non-standard
clock setting
Changes since v1:
- Se
This patch adds support S5PV310/S5PC210 HSMMC and additional host capabilities.
HSMMC of S5PV310 does not have internal clock divider so need to update for it.
Changes since v2:
- Changed clock control method to overriding from using quirk
- This patch is referred from that of Jaehoon Chung's supp
From: Jeongbae Seo
This patch adds to support additional host capabilities like SD/MMC high speed,
SDHCI bus width and
etc.
Signed-off-by: Jeongbae Seo
Signed-off-by: Kukjin Kim
---
drivers/mmc/host/sdhci-s3c.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a
t I think, you can do it against dev/gpio-update.
Anyway could you please make additional patch for it?
It would be nice if you could do it :-)
Others ok to me...but I will sort out regarding sdhci gpio configuration in
future time.
(snip)
Thanks.
Best regards,
Kgene.
--
Kukjin Kim , Senior Engineer,
S
Jeongbae Seo wrote:
>
> Ben Dooks worte:
> > On 17/09/10 10:45, Kukjin Kim wrote:
> > > From: Hyuk Lee
> > >
> > > This patch adds to support no internal clock divider in SDHCI.
> > > The external clock divider can be used to make a proper clock
&g
From: Jeongbae Seo
This patch adds to support additional host capabilities
like SD/MMC high speed, SDHCI bus width and etc.
Signed-off-by: Jeongbae Seo
Signed-off-by: Kukjin Kim
---
drivers/mmc/host/sdhci-s3c.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a
This patch adds support S5PV310/S5PC210 HSMMC and additional host capabilities.
HSMMC of S5PV310 does not have internal clock divider so need to update for it.
(used SDHCI_QUIRK_NONSTANDARD_CLOCK quirk and added clk_type plat data)
Changes since v1:
- Separated to each topic
[PATCH v2 1/2] sdhci
From: Hyuk Lee
This patch adds to support no internal clock divider in SDHCI.
The external clock divider can be used to make a proper clock
because SDHCI doesn't support internal clock divider by itself.
Signed-off-by: Hyuk Lee
Signed-off-by: Jeongbae Seo
Signed-off-by: Kukji
-425,6 +478,16 @@ static int __devinit sdhci_s3c_probe(struct
> platform_device *pdev)
> /* HSMMC on Samsung SoCs uses SDCLK as timeout clock */
> host->quirks |= SDHCI_QUIRK_DATA_TIMEOUT_USES_SDCLK;
>
> + /*
> + * If controller does not have internal clock
now.
> > + host->quirks |= SDHCI_QUIRK_NONSTANDARD_CLOCK;
> > +
> > + if (pdata->host_caps)
> > + host->mmc->caps |= pdata->host_caps;
> > +
> >ret = sdhci_add_host(host);
> >if (ret) {
> >dev_err(dev, "sdhci_add_host() failed\n");
> > --
Thanks.
Best regards,
Kgene.
--
Kukjin Kim , Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
with 8-bit bus"
> > + help
> > + Support HSMMC Channel 2 8-bit bus.
> > + If selected, Channel 3 is disabled.
>
> I think it's not needed since most boards have fixed bandwith and
> cfg_gpio handle it regardless these configuration.
> Als
Kukjin Kim wrote:
>
> Kyungmin Park wrote:
> >
> > On Thu, Sep 2, 2010 at 7:20 PM, Kukjin Kim
wrote:
> > > Jaehoon Chung wrote:
> > >>
> > >> This is sdhci-s3c patch for c210.
> > >> c210 didn't use divider of host contro
Kyungmin Park wrote:
>
> On Thu, Sep 2, 2010 at 7:20 PM, Kukjin Kim wrote:
> > Jaehoon Chung wrote:
> >>
> >> This is sdhci-s3c patch for c210.
> >> c210 didn't use divider of host controller.
> >>
> >> Host Controller need other cl
mdelay(1);
+ }
+
+ writew(SDHCI_CLOCK_INT_EN | SDHCI_CLOCK_CARD_EN,
+ host->ioaddr + SDHCI_CLOCK_CONTROL);
+
+ host->clock = clock;
+ }
}
/**
@@ -221,6 +257,11 @@ static unsigned int sdhci_s3c_get_min_clock(s
Thanks.
Best regards,
Kgene.
--
Kukjin Kim , Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
> On Wed, Jun 09, 2010 at 11:39:42AM +0200, Marek Szyprowski wrote:
> > S3C SDHCI host controller can change the source for generating mmc
clock.
> > By default host bus
Chris Ball wrote:
>
> Hi,
>
Hi :-)
> This wasn't merged, after some questions from Kyungmin Park -- is
> the patch still desirable?
>
This patch is being in mainline now.
(Commit ID: 3fe42e077f65351503f5004031549db330bb105e)
Thanks.
Best regards,
Kgene.
--
Kukjin Ki
Marek Szyprowski wrote:
>
> Hello,
>
Hi Marek :-)
> On Friday, August 13, 2010 9:32 AM Kukjin Kim wrote:
>
> > This is just information about Samsung sdmmc stuff building error now.
> >
> > I found Marek's 'sdhci-s3c: enable SDHCI_QUIRK_NO_HISPD_BIT
Uwe Kleine-Konig wrote:
>
> Hello,
>
Hi :-)
> On Fri, Aug 13, 2010 at 08:33:40PM +0900, Kukjin Kim wrote:
> > Kukjin Kim wrote:
> > >
> > > Hi,
> > >
> > > Following is build error when selected MMC without PM.
> > >
> > >
kernel.org
> Cc: Andrew Morton
> Signed-off-by: Uwe Kleine-König
Acked-by: Kukjin Kim
> ---
> drivers/mmc/core/host.c |2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/mmc/core/host.c b/drivers/mmc/core/host.c
> index 0efe631..d80cfdc 1006
Kukjin Kim wrote:
>
> Hi,
>
> Following is build error when selected MMC without PM.
>
> drivers/built-in.o: In function `mmc_alloc_host':
> drivers/mmc/core/host.c:108: undefined reference to `mmc_pm_notify'
> make[1]: *** [.tmp_vmlinux1] Error 1
> make
INIT_DELAYED_WORK_DEFERRABLE(&host->disable,
mmc_host_deeper_disable);
+#ifdef CONFIG_PM
host->pm_notify.notifier_call = mmc_pm_notify;
+#endif
/*
* By default, hosts do not support SGIO or large requests.
---
Thanks.
Best regards,
Kgene.
--
Kukjin Kim , Senior Engineer,
SW S
arek, in future please make sure your patch has no building problem before
submitting.
(or it can help to add some kind of dependency note in your patch)
Thanks.
Best regards,
Kgene.
--
Kukjin Kim , Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
--
To unsubscrib
From: Hyuk Lee
If host controller doesn't have WP pin which should be connnected with SDMMC
card WP pin, can implement get_ro function with using the allocated gpio.
In order to use this quirk wp_gpio in the platform data must be set.
Signed-off-by: Hyuk Lee
Signed-off-by: Kukjin Kim
Cc
Marek Szyprowski wrote:
>
> Hello,
Hi :-)
>
> On Tuesday, July 27, 2010 2:44 PM Kukjin Kim wrote:
>
> > From: Hyuk Lee
> >
> > If host controller doesn't have WP pin which should be connnected with
> > SDMMC
> > card WP pin, can implement get
Maurus Cuelenaere wrote:
>
> Op 27-07-10 13:58, Kukjin Kim schreef:
> > Maurus Cuelenaere wrote:
> >> Op 23-07-10 13:56, Kukjin Kim schreef:
> >>> From: Hyuk Lee
> >>>
> >>> If host controller doesn't have WP pin which should be c
igned-off-by: Kukjin Kim
---
arch/arm/mach-s5pv210/mach-smdkv210.c | 26 ++
1 files changed, 26 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-s5pv210/mach-smdkv210.c
b/arch/arm/mach-s5pv210/mach-smdkv210.c
index d20adf7..5b58278 100644
--- a/arch/arm/mach-s5
From: Hyuk Lee
If host controller doesn't have WP pin which should be connnected with SDMMC
card WP pin, can implement get_ro function with using the allocated gpio.
In order to use this quirk wp_gpio in the platform data must be set.
Signed-off-by: Hyuk Lee
Signed-off-by: Kukji
From: Hyuk Lee
This patch adds the members of platdata which is wp_gpio.
The wp_gpio is a gpio_number which is connected with WP pin of SD Slot.
Signed-off-by: Hyuk Lee
Signed-off-by: Kukjin Kim
---
arch/arm/plat-samsung/dev-hsmmc.c |2 ++
arch/arm/plat-samsung/dev-hsmmc1.c
This patch adds support SDMMC write protection pin on SMDKV210.
Changes since v3:
Addressed comments from Kyungmin Park and Marek Szyprowski
- Added pdata 'bool has_gpio_wp' as per Marek
- Moved new WP quirk checking as per Kyungmin
Changes since v2:
Addressed comments from Marek Szyprowski
- m
Marek Szyprowski wrote:
>
> Hello,
>
> On Friday, July 23, 2010 1:57 PM Kukjin Kim wrote:
>
> > From: Hyuk Lee
> >
> > If host controller doesn't have WP pin which should be connnected with
> > SDMMC
> > card WP pin, can implement get_ro funct
Kyungmin Park wrote:
>
> On Fri, Jul 23, 2010 at 8:56 PM, Kukjin Kim wrote:
> > From: Hyuk Lee
> >
> > If host controller doesn't have WP pin which should be connnected with
SDMMC
> > card WP pin, can implement get_ro function with using the allocated
g
Maurus Cuelenaere wrote:
>
> Op 23-07-10 13:56, Kukjin Kim schreef:
> > From: Hyuk Lee
> >
> > If host controller doesn't have WP pin which should be connnected with SDMMC
> > card WP pin, can implement get_ro function with using the allocated gpio.
> >
t from the card-detection patches and can be
applied
> > directly onto linux-next kernel tree.
> >
> > > and
> > > sdhci-s3c-add-support-for-new-card-detection-methods.patch
> > >
> > > the latter of which is below.
> > >
> > > Am I mi
From: Hyuk Lee
On Samsung's SDMMC hosts the timeout clock is derivied from the SD Clock
which is set dynamically. So checked SDHCI_QUIRK_DATA_TIMEOUT_USES_SDCLK
quirk and removed 'sdhci_s3c_get_timeout_clk' callback which doesn't need
any more.
Signed-off-by: Hyuk Lee
Signe
From: Hyuk Lee
This patch adds the members of platdata which is wp_gpio.
The wp_gpio is a gpio_number which is connected with WP pin of SD Slot.
Signed-off-by: Hyuk Lee
Signed-off-by: Kukjin Kim
---
arch/arm/plat-samsung/dev-hsmmc.c |1 +
arch/arm/plat-samsung/dev-hsmmc1.c
From: Hyuk Lee
If host controller doesn't have WP pin which should be connnected with SDMMC
card WP pin, can implement get_ro function with using the allocated gpio.
In order to use this quirk wp_gpio in the platform data must be set.
Signed-off-by: Hyuk Lee
Signed-off-by: Kukji
igned-off-by: Kukjin Kim
---
arch/arm/mach-s5pv210/mach-smdkv210.c | 22 ++
1 files changed, 22 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-s5pv210/mach-smdkv210.c
b/arch/arm/mach-s5pv210/mach-smdkv210.c
index d20adf7..e573beb 100644
--- a/arch/arm/mach-s5pv210
This patch adds support SDMMC write protection pin on SMDKV210.
Changes since v2:
Addressed comments from Marek Szyprowski
- modified wp_gpio checking method for support gpio number 0.
- removed unnecessary checking in dev-hsmmc.c
Changes since v1:
Addressed comments from Ben Dooks, Maurus Cuele
dhci-g
pio.c:91: error: dereferencing pointer to incomplete type
/home/kgene/linux/linux-2.6-mainline-dev/arch/arm/mach-s5pc100/setup-sdhci-g
pio.c:91: error: 'S3C_SDHCI_CD_INTERNAL' undeclared (first use in
make[2]: *** [arch/arm/mach-s5pc100/setup-sdhci-gpio.o] Error 1
and s3c64xx also.
h extends the driver with support for the new card
> detection methods can be applied.
>
> Signed-off-by: Marek Szyprowski
> Signed-off-by: Kyungmin Park
Ok..will apply soon.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim , Senior Engineer,
SW Solution Development Team, Samsung Elect
Marek Szyprowski wrote:
>
> Hello,
>
Hello :-)
> On Saturday, July 03, 2010 3:01 AM Kukjin Kim wrote:
>
> > From: Hyuk Lee
> >
> > If host controller doesn't have WP pin which should be connnected with
> > SDMMC
> > card WP pin, can imple
1 - 100 of 124 matches
Mail list logo
