Seems reasonable,
Acked-by: Ian Molton
-Ian
On Sun, 14 Sep 2014 23:51:24 +0400
Sergei Shtylyov wrote:
> I spent a couple of days with the driver just hanging due to me forgetting to
> specify the external crystal frequency, so that clk_get_rate() returned 0 and
> thus th
> + unsigned int f;
> + pdata->clk_enable(host->pdev, &f);
> + }
>
> tmio_mmc_disable_mmc_irqs(host, TMIO_MASK_ALL);
> +
> + if (pdata->clk_disable)
> + pdata->clk_disable(host->pdev);
> +
> return 0;
> }
> EXPORT_SYMBOL(tmio_mmc_h
On Fri, 9 May 2014 15:10:51 +0200
Ulf Hansson wrote:
> On 8 May 2014 17:37, Ben Dooks wrote:
> > On Thu, May 08, 2014 at 11:24:58AM +0200, Ulf Hansson wrote:
> >> Update Ian Molton's email, the maintainer for tmio/sh_mobile_sdhci.
> >>
> >> Cc: Ia
Simple move to remove a redundant header file from public view, when
it only contains driver-internal register definitions.
Reviewed-by: Violeta Menendez
Signed-off-by: Ian Molton
---
drivers/mmc/host/tmio_mmc.h | 47 -
drivers/mmc/host/tmio_mmc_dma.c
should be.
Reviewed-by: Violeta Menendez
Signed-off-by: Ian Molton
---
arch/arm/boot/compressed/sdhi-sh7372.c | 2 +-
arch/arm/boot/compressed/sdhi-shmobile.c | 35 +++-
arch/arm/boot/compressed/sdhi-shmobile.h | 2 ++
3 files changed, 33 insertions(+), 6 deletions
Refactor to remove a return by reference.
Reviewed-by: Violeta Menendez
Signed-off-by: Ian Molton
---
drivers/mmc/host/sh_mobile_sdhi.c | 8 ++-
drivers/mmc/host/tmio_mmc.c | 8 ++-
drivers/mmc/host/tmio_mmc.h | 4 +-
drivers/mmc/host/tmio_mmc_pio.c | 106
Trivial patch to cleanup resource allocation and freeing.
Reviewed-by: Violeta Menendez
Signed-off-by: Ian Molton
---
drivers/mmc/host/tmio_mmc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mmc/host/tmio_mmc.c b/drivers/mmc/host/tmio_mmc.c
index
Trivial patch to correct the error return path.
Reviewed-by: Violeta Menendez
Signed-off-by: Ian Molton
---
drivers/mmc/host/tmio_mmc.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/mmc/host/tmio_mmc.c b/drivers/mmc/host/tmio_mmc.c
index bf6252c
Use devm_ioremap for tmio / sh_mobile.
Reviewed-by: Violeta Menendez
Signed-off-by: Ian Molton
---
drivers/mmc/host/tmio_mmc_pio.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/mmc/host/tmio_mmc_pio.c b/drivers/mmc/host/tmio_mmc_pio.c
index 7db9310
This is a series of small cleanups for the tmio_mmc and sh_mobile_sdhi drivers.
Please apply!
-Ian
[PATCH 1/6] mmc: TMIO: Refactor driver core probe function
[PATCH 2/6] mmc: TMIO: Fixup error return path
[PATCH 3/6] mmc: TMIO: Use devm_ioremap()
[PATCH 4/6] mmc: TMIO: use devm_ for requesti
On Fri, 2011-07-15 at 10:46 +0200, Guennadi Liakhovetski wrote:
> Thanks for the offer, I appreciate it! I am not the only active tmio
> mmc contributor, but yes, I could take that role upon me, if noone
> objects.
> Would be good to hear, what Ian thinks? Is he maybe still planning to
> actively
On Wed, 2011-08-03 at 08:55 -0400, Chris Ball wrote:
> > Good for 3.1, do we also push such "harmless" compiler warning fixes
> to
> > stable?
> >
> > Acked-by: Guennadi Liakhovetski
>
> Pushed for 3.1, thanks. I don't think this is appropriate for stable.
Why on earth not? its obviously corre
Im fine with it as long as it doesnt complicate my plan to add PXA DMA
to the driver.
--
Ian Molton
Linux, Automotive, and other hacking:
http://www.mnementh.co.uk/
On 15 March 2011 09:01, Magnus Damm wrote:
> On Mon, Mar 14, 2011 at 7:51 AM, Guennadi Liakhovetski
> wrote:
>> On
Sounds like a good idea... Its possible that I could implement DMA on
the toshiba stuff too, can your code handle this?
(I havent had time to read this yet)
--
Ian Molton
Linux, Automotive, and other hacking:
http://www.mnementh.co.uk/
On 11 March 2011 07:51, Guennadi Liakhovetski wrote
If its not already gone through...
Acked-by: Ian Molton
--
Ian Molton
Linux, Automotive, and other hacking:
http://www.mnementh.co.uk/
On 30 August 2010 11:50, Matt Fleming wrote:
> From: Yusuke Goda
>
> Adjust the tmio_mmc block size check to accept 2-byte requests in 4-bit
>
@Matt: yes, thats what I was suggesting before.
@Magnus: that looks fine.
--
Ian Molton
Linux, Automotive, and other hacking:
http://www.mnementh.co.uk/
On 26 August 2010 08:26, Magnus Damm wrote:
> On Thu, Aug 26, 2010 at 4:24 PM, Matt Fleming wrote:
>> On Thu, Aug 26, 2010 at 0
; is not a good enough excuse.
--
Ian Molton
Linux, Automotive, and other hacking:
http://www.mnementh.co.uk/
On 25 August 2010 23:05, Andrew Morton wrote:
> On Wed, 25 Aug 2010 22:52:08 +0100
> Matt Fleming wrote:
>
>> On Tue, 13 Jul 2010 11:32:33 +0900
>> Yusuke
This change needs to be modified to test what hardware is present.
this wont work on my hardware TTBOMK.
--
Ian Molton
Linux, Automotive, and other hacking:
http://www.mnementh.co.uk/
On 23 July 2010 12:05, Magnus Damm wrote:
> 2010/7/20 Yusuke Goda :
>> Adjust the tmio_mmc block s
s
out enough to get me what little documentation (register specs and
little more) that they could.
Cheers guys!
--
Ian Molton
Linux, Automotive, and other hacking:
http://www.mnementh.co.uk/
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the bo
Could someone send me a copy of the patch to tmio ?
--
Ian Molton
Linux, Automotive, and other hacking:
http://www.mnementh.co.uk/
On 14 May 2010 20:43, Charles D. Krebs wrote:
>>> Just saw this - am I right in thinking someone has written SDIO
>>> support for TMIO ? Im af
Just saw this - am I right in thinking someone has written SDIO
support for TMIO ? Im afraid I dont appear to have the preceeding
emails.
--
Ian Molton
Linux, Automotive, and other hacking:
http://www.mnementh.co.uk/
On 14 May 2010 09:35, Guennadi Liakhovetski wrote:
> (added linux-mmc
Sounds good to me, and you're right - the MFD level is good for this
config option.
--
Ian Molton
Linux, Automotive, and other hacking:
http://www.mnementh.co.uk/
On 13 May 2010 15:18, Guennadi Liakhovetski wrote:
> On Thu, 13 May 2010, Guennadi Liakhovetski wrote:
>
>> On
[PATCH 07/07] sh: SDHI platform data to the kfr2r09 board
>>
>> These patches contain the SuperH specific changes needed for
>> the tmio-mmc driver to work with SuperH Mobile SDHI hardware.
>>
>> The tmio-mmc patch 0001-MMC-hardware-abstraction-for-CNF-area.patch
>> by
Hi folks,
Andrew, can you please pull
git//git.mnementh.co.uk/linux-2.6-im tmio_clockpower
Thanks!
--
Ian Molton
Linux, Automotive, and other hacking:
http://www.mnementh.co.uk/
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message
1mA IIRC. Its never been calibrated though, its just a mid-priced multimeter.
2009/10/4 Phil Blundell :
> On Sun, 2009-10-04 at 16:51 +0100, Ian Molton wrote:
>> Seriously, on e750 the power draw of the tc6393 in standby is so low
>> my meter cant measure it.
>
> What
Hi Philipp,
Thanks for your patches. I'll roll them in with my patches so that
this all goes in as one patchset, if thats ok with you?
-Ian
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://
a lot of
code for little gain probably.
That said the mmc block is fairly simple, it can be simply reset to
restore state.
Of course there are other issues like how to suupport SD cards that
remain poowered during suspend...
> And I suspect that you feel far from motivated by
> such a change sinc
2009/10/3 Magnus Damm :
> On Sat, Oct 3, 2009 at 3:14 AM, Ian Molton wrote:
> 512kHz?
That was an example. I suppose if your HCLK (the input or host clock,
as named in the TMIO specs) never falls below double the maximum
MMC/SD bus speed, then you will be ok.
Do _any_ SH platforms ac
mmc patch 0001-MMC-hardware-abstraction-for-CNF-area.patch
> by Ian Molton is needed for correct run time behaviour. Without
> this patch the tmio-mmc probe() fails gracefully.
>
> I suggest merging the series in the SuperH tree. Not sure about
> the best way to merge the patch by Ian.
&
ipp gets back to us with the ASIC3 update I'll
re-do my patchset to include ASIC3 - if the changes to tmio-mmc and
submitted seperately, it will break ASIC3 so that needs to go in the
same patchset. Philipp will be ready this weekend, not long to wait.
--
Ian Molton
Linux, Automotive, and other hackin
il superH and ASIC3 have been
tested and working without modifying it. Thats why I've asked Philipp
to test my changes to it.
--
Ian Molton
Linux, Automotive, and other hacking:
http://www.mnementh.co.uk/
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
2) My series is then merged through the SuperH tree:
> [PATCH 00/07] sh: SuperH Mobile SDHI changes
> (I may need to rework some patches after feedback)
>
> I'd like to see this in 2.6.32 since it's a fairly insular change and
> we've been struggling with this
he kconfig bit
>> merged in 2.6.32-rc?
>
>
>
> Please flag the proposed merge plans clearly in the description when
> you send out the patch series and lets take a look at it then.
>
> I don't need much reason to shove stuff into -rc2, but it's nice to
> have
we stick to 2.6.33 then this little change took more than
> one year from initial patches to inclusion in a stable kernel
That happens. No point in rushing things, lets get it _right_.
btw, tc6387xb is a very 'thin' MFD layer for a similar sounding
device, you might use that?
--
I
Philipp Zabel :
> Am Dienstag, den 29.09.2009, 13:52 +0100 schrieb Ian Molton:
>> Hi guys,
>>
>> This is the full TMIO MMC patchset, compiled, tested, checkpatch passed.
>
> With bus shift support dropped from the SD_CONFIG register accessors, I
> can't use this as-is on
hen you're done.
HTH!
-Ian
2009/9/30 Magnus Damm :
> Hey Ian,
>
> [CC akpm]
>
> On Tue, Sep 29, 2009 at 9:52 PM, Ian Molton wrote:
>> Hi guys,
>>
>> This is the full TMIO MMC patchset, compiled, tested, checkpatch passed.
>>
>> Please base all tm
c" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
Ian Molton
Linux, Automotive, and other hacking:
http://www.mnementh.co.uk/
--
To unsubscribe from this list: send the line "unsubscribe linux-m
n hardware.
--
Ian Molton
Linux, Automotive, and other hacking:
http://www.mnementh.co.uk/
From 46909530b67a1c83c1e22ac5fcfcada27d4fab54 Mon Sep 17 00:00:00 2001
From: Ian Molton
Date: Thu, 24 Sep 2009 23:24:18 +0100
Subject: [PATCH 1/5] MMC: hardware abstraction for CNF area
This patch abstracts o
update: I just tried a quick hack that simply restarts the mmc card
probe at f_min if it fails and this allows my 'weirdo' card/host setup
to function normally again.
I'll knock up a patch implementing this a bit more cleanly and submit
it for opinions shortly.
2009/9/29 Ian Molt
Excellent. I'll post the tmio clock patch later today.
2009/9/29 pHilipp Zabel :
> On Tue, Sep 29, 2009 at 5:09 AM, Ian Molton wrote:
>> *prod*
>>
>> After all the fuss about this, no-ones going to comment?
>>
>> I just found the last tmio-related bug I wa
ore robust solution - if initialisation fails at 400kHz
try again at f_min (if its lower than 400kHz).
this requires no machine specific knowledge in the core and may
increase robustness generally, as well as fixing my case.
Comments please?
2009/9/29 Ian Molton :
> Hi folks,
&
higher than those commonly requested, and the
next lowest quite a LOT lower (eg. we tend to init at ~200-250kHz on
TMIO which is awful IMO).
2009/9/29 Magnus Damm :
> On Tue, Sep 29, 2009 at 12:09 PM, Ian Molton wrote:
>> *prod*
>>
>> After all the fuss about this, no-ones goin
in with all the affected drivers tested and ASIC3 I _do not have
one of_ to test.
Its only a few lines - can we get it finished please?
-Ian
2009/9/26 Ian Molton :
> 2009/9/26 Ian Molton :
> Hi guys,
> This is the tmio based part of the tmio-mmc driver update that removes the
> CNF area (cl
, and none of t7l66 or
tc6387, and only with one card.
I'll look into it tomorrow and see what actual clock frequency is
getting selected.
I'm off to bed now.
--
Ian Molton
Linux, Automotive, and other hacking:
http://www.mnementh.co.uk/
--
To unsubscribe from this list: send the line &q
2009/9/26 Ian Molton :
Hi guys,
This is the tmio based part of the tmio-mmc driver update that removes the
CNF area (clock and power control) from the driver and abstracts it so that
more users can share the MMC driver itself.
Its compilable, runs on my hardware, and is checkpatch clean.
I
Don Mullis wrote:
sdcard.org specs appear to not be (any longer) public. When downloading
some today I had to give an employer's name, and received in return PDFs
watermarked with that name.
If you can put in any name, and they dont verify it, I cant imagine they
can claim the specs are priv
46 matches
Mail list logo
