Re: [PATCH 1/1] mmc: core: Use regulator_get_voltage() if OCR mask is empty.

2014-08-15 Thread Mark Brown
On Fri, Aug 15, 2014 at 07:19:41AM -0700, Tim Kryger wrote: > That is a little different from my suggestion where the constraints > check is skipped when the regulator output is fixed. It effectively > does this now when the regulator itself provides the fixed voltage. > However, the checks aren'

Re: [PATCH v4] mmc: implement Driver Stage Register handling

2014-08-15 Thread Uwe Kleine-König
Hello Ulf, On Fri, Aug 15, 2014 at 11:05:39AM +0200, Ulf Hansson wrote: > On 15 August 2014 10:38, Uwe Kleine-König > wrote: > > From: Sascha Hauer > > > > Some eMMC and SD cards implement a DSR register that allows to tune > > raise/fall times and drive strength of the CMD and DATA outputs. > >

Re: [PATCH] mmc: tmio: Fix hang during suspend

2014-08-15 Thread Geert Uytterhoeven
Hi Ulf, On Fri, Aug 15, 2014 at 4:42 PM, Ulf Hansson wrote: > On 14 August 2014 17:23, Geert Uytterhoeven wrote: >> On R-Car Gen 2, the SDHI registers cannot be accessed while the SDHI >> module clock is disabled. Doing so will cause a lock-up. >> >> When suspending, enable the module clock befo

Re: [PATCH 1/1] mmc: core: Use regulator_get_voltage() if OCR mask is empty.

2014-08-15 Thread Ulf Hansson
On 15 August 2014 11:55, Mark Brown wrote: > On Fri, Aug 15, 2014 at 09:48:43AM +0200, Javier Martinez Canillas wrote: > >> But now I wonder why regulator_list_voltage() even list the voltage for >> fixed regulators (desc->fixed_uV) since they don't have the ability to >> vary voltage. The regulat

Re: [PATCH] mmc: tmio: Fix hang during suspend

2014-08-15 Thread Ulf Hansson
On 14 August 2014 17:23, Geert Uytterhoeven wrote: > On R-Car Gen 2, the SDHI registers cannot be accessed while the SDHI > module clock is disabled. Doing so will cause a lock-up. > > When suspending, enable the module clock before disabling the SDHI > interrupts, and disable the clock again afte

Re: [PATCH 1/1] mmc: core: Use regulator_get_voltage() if OCR mask is empty.

2014-08-15 Thread Tim Kryger
On Fri, Aug 15, 2014 at 12:48 AM, Javier Martinez Canillas wrote: > Hello Tim, > > On 08/15/2014 07:36 AM, Tim Kryger wrote: >> On Thu, Aug 14, 2014 at 8:19 AM, Mark Brown wrote: >> >>> Right, there's two things going on here. One is that as you describe we >>> shouldn't be putting constraints i

Re: [PATCH v2 2/2] mmc: dw_mmc: Add support for MIPS

2014-08-15 Thread Alim Akhtar
Hi Andrew, On Thu, Aug 14, 2014 at 10:15 PM, Andrew Bresticker wrote: > There are upcoming MIPS SoCs with dw_mmc hosts. > > Signed-off-by: Andrew Bresticker Reviewed-by: Alim Akhtar > --- > drivers/mmc/host/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drive

Re: [PATCH v2 1/2] mmc: dw_mmc: Add dependency on DMA

2014-08-15 Thread Alim Akhtar
Hi Andrew, On Thu, Aug 14, 2014 at 10:15 PM, Andrew Bresticker wrote: > The dw_mmc drivers rely on the DMA API, so update the Kconfig entry > to depend on HAS_DMA. Since the drivers should build on any platform > with DMA, allow the driver to compile tested on non-ARC/ARM platforms. > > Signed-o

Re: [PATCH v2] mmc: sdhci-pxav3: set_uhs_signaling is initialized twice differently

2014-08-15 Thread Peter Griffin
Hi, > This means that uhs is currently broken for this platform currently, as pxav3 > has some special constriants which means it can't use the generic callback. > > This happened in > commit 96d7b78cfc2f ("mmc: sdhci: convert sdhci_set_uhs_signaling() into a > library function") > commit a702c8

[PATCH v3] mmc: sdhci-pxav3: set_uhs_signaling is initialized twice differently

2014-08-15 Thread Peter Griffin
.set_uhs_signaling field is currently initialised twice once to the arch specific callback pxav3_set_uhs_signaling, and also to the generic sdhci_set_uhs_signaling callback. This means that uhs is currently broken for this platform currently, as pxav3 has some special constriants which means it ca

[PATCH v2] mmc: sdhci-pxav3: set_uhs_signaling is initialized twice differently

2014-08-15 Thread Peter Griffin
.set_uhs_signaling field is currently initialised twice once to the arch specific callback pxav3_set_uhs_signaling, and also to the generic sdhci_set_uhs_signaling callback. This means that uhs is currently broken for this platform currently, as pxav3 has some special constriants which means it ca

Re: [PATCH] mmc: sdhci-pxav3: set_uhs_signaling is initialized twice differently

2014-08-15 Thread Peter Griffin
Hi Russell, > > This happened in > > commit 96d7b78cfc2f ("mmc: sdhci: convert sdhci_set_uhs_signaling() into a > > library function") > > commit a702c8abb2a9 ("mmc: host: split up sdhci-pxa, create sdhci-pxav3.c")' > > This is exactly why named initialisers should always follow the > declaratio

Re: [PATCH] mmc: tmio: Fix hang during suspend

2014-08-15 Thread Ian Molton
On Thu, 14 Aug 2014 17:23:53 +0200 Geert Uytterhoeven wrote: > On R-Car Gen 2, the SDHI registers cannot be accessed while the SDHI > module clock is disabled. Doing so will cause a lock-up. > > When suspending, enable the module clock before disabling the SDHI > interrupts, and disable the cloc

Re: [PATCH 1/1] mmc: core: Use regulator_get_voltage() if OCR mask is empty.

2014-08-15 Thread Javier Martinez Canillas
Hello Mark, On 08/15/2014 11:55 AM, Mark Brown wrote: > On Fri, Aug 15, 2014 at 09:48:43AM +0200, Javier Martinez Canillas wrote: > >> But now I wonder why regulator_list_voltage() even list the voltage for >> fixed regulators (desc->fixed_uV) since they don't have the ability to > > That's beca

Re: [PATCH 1/1] mmc: core: Use regulator_get_voltage() if OCR mask is empty.

2014-08-15 Thread Mark Brown
On Fri, Aug 15, 2014 at 09:48:43AM +0200, Javier Martinez Canillas wrote: > But now I wonder why regulator_list_voltage() even list the voltage for > fixed regulators (desc->fixed_uV) since they don't have the ability to > vary voltage. The regulator_list_voltage() documentation says: That's beca

Re: [PATCH] mmc: sdhci-pxav3: set_uhs_signaling is initialized twice differently

2014-08-15 Thread Russell King - ARM Linux
On Fri, Aug 15, 2014 at 10:12:38AM +0100, Peter Griffin wrote: > .set_uhs_signaling field is currently initialised twice once to the > arch specific callback pxav3_set_uhs_signaling, and also to the generic > sdhci_set_uhs_signaling callback. > > This means that uhs is currently broken for this pl

[PATCH] mmc: sdhci-pxav3: set_uhs_signaling is initialized twice differently

2014-08-15 Thread Peter Griffin
.set_uhs_signaling field is currently initialised twice once to the arch specific callback pxav3_set_uhs_signaling, and also to the generic sdhci_set_uhs_signaling callback. This means that uhs is currently broken for this platform currently, as pxav3 has some special constriants which means it ca

Re: [PATCH v4] mmc: implement Driver Stage Register handling

2014-08-15 Thread Ulf Hansson
On 15 August 2014 10:38, Uwe Kleine-König wrote: > From: Sascha Hauer > > Some eMMC and SD cards implement a DSR register that allows to tune > raise/fall times and drive strength of the CMD and DATA outputs. > The values to use depend on the card in use and the host. > It might be needed to redu

Re: [PATCH 1/1] mmc: core: Use regulator_get_voltage() if OCR mask is empty.

2014-08-15 Thread Mark Brown
On Thu, Aug 14, 2014 at 10:36:18PM -0700, Tim Kryger wrote: > On Thu, Aug 14, 2014 at 8:19 AM, Mark Brown wrote: > > > Right, there's two things going on here. One is that as you describe we > > shouldn't be putting constraints in .dtsi files if we don't know they're > > OK for a given board. T

[PATCH v4] mmc: implement Driver Stage Register handling

2014-08-15 Thread Uwe Kleine-König
From: Sascha Hauer Some eMMC and SD cards implement a DSR register that allows to tune raise/fall times and drive strength of the CMD and DATA outputs. The values to use depend on the card in use and the host. It might be needed to reduce the drive strength to prevent voltage peaks above the host

RE: [PATCH v3] mmc: core: try 1.8v signling in ddr mode if host and device

2014-08-15 Thread Dong, Chuanxiao
> -Original Message- > From: Ulf Hansson [mailto:ulf.hans...@linaro.org] > Sent: Friday, August 15, 2014 4:34 PM > To: Dong, Chuanxiao > Cc: linux-mmc; ch...@printf.org > Subject: Re: [PATCH v3] mmc: core: try 1.8v signling in ddr mode if host and > device > > On 15 August 2014 05:28, Ch

Re: [PATCH v3] mmc: core: try 1.8v signling in ddr mode if host and device

2014-08-15 Thread Ulf Hansson
On 15 August 2014 05:28, Chuanxiao Dong wrote: > Even (e)MMC card can support 3.3v to 1.2v vccq in DDR, but not all > host controller can support this, like some of the SDHCI host > which connect to an eMMC device. Some of these host controller > still needs to use 1.8v vccq for supporting DDR mod

Re: [PATCH v3] mmc: implement Driver Stage Register handling

2014-08-15 Thread Uwe Kleine-König
Hello Ulf, On Thu, Aug 14, 2014 at 11:26:28AM +0200, Ulf Hansson wrote: > > diff --git a/drivers/mmc/core/host.c b/drivers/mmc/core/host.c > > index 95cceae96944..52e83f389428 100644 > > --- a/drivers/mmc/core/host.c > > +++ b/drivers/mmc/core/host.c > > @@ -452,6 +452,14 @@ int mmc_of_parse(struc

Re: [PATCH] mmc: check EXT_CSD_PARTITION_SETTING_COMPLETED before creating partitions

2014-08-15 Thread Ulf Hansson
On 14 August 2014 15:27, Grégory Soutadé wrote: > Le 14/08/2014 13:46, Ulf Hansson a écrit : >> On 13 August 2014 11:20, Grégory Soutadé wrote: >>> Le 13/08/2014 10:36, Ulf Hansson a écrit : On 17 July 2014 16:57, Grégory Soutadé wrote: > Create MMC general purpose partitions only if >>

Re: [PATCH 1/1] mmc: core: Use regulator_get_voltage() if OCR mask is empty.

2014-08-15 Thread Javier Martinez Canillas
Hello Tim, On 08/15/2014 07:36 AM, Tim Kryger wrote: > On Thu, Aug 14, 2014 at 8:19 AM, Mark Brown wrote: > >> Right, there's two things going on here. One is that as you describe we >> shouldn't be putting constraints in .dtsi files if we don't know they're >> OK for a given board. The other