Hi Richard,
> * About the share between i.MX and PPC eSDHC.
> Why configure a few parts be shared between the i.MX eSDHC and PPC
> eSDHC? Can they be separated into two independent systems?
The rule of thumb is to avoid code-duplication. Assume the PPC driver gets
fixed an off-by-one error in the
Hello
I wonder if you could review the three patches I sent the mailing list:
especially the following ones:
mmc: add suspend/resume in the sdhci-pltfm driver
mmc: split the sdhci.h to help platforms that uses shdci-pltfm d.d.
These follow the advice discussed with Wolfram in the thread named:
On Thu, Sep 23, 2010 at 04:18:02PM -0700, Philip Rakity wrote:
>Since your patches are not available yet -- I think it makes more sense if
>this patch is considered for inclusion and you can add then include its
>functionality in your code.
Hmm, I don't think so. As I mentioned elsewhe
Hi:
Why I can't use the --compose to post the additional msg before sending
out the serial patches?
:(
Anyway, paste them here:
Hi Wolfram:
Here are the patches that enable the sdhci of i.MX51.
The IO and WP functions are verified on i.MX51 BBG board.
The missing bits of the HOST_CONTROL and so on
Hi All:
Sorry, for wrong --compose usage.
Hi Wolfram:
Here are the patches that enable the sdhci of i.MX51.
The IO and WP funcs are verified on i.MX51 BBG board.
The misssing bits of the HOST_CONTROL and so on had been made up in the 4-3
patch.
Hi Uwe:
I would change MSL part to the "dynamicall
Modify the machine specific codes and add the eSDHC1 and eSDHC2 support
on MX51 BBG platform.
IOMUX, CLOCK, register the device.
Signed-off-by: Richard Zhu
---
arch/arm/mach-mx5/board-mx51_babbage.c | 38 ++
arch/arm/mach-mx5/clock-mx51.c | 193 ++
Enable the fsl esdhc driver on mx51 platforms
Signed-off-by: Richard Zhu
---
arch/arm/configs/mx51_defconfig |9 +++--
1 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/arch/arm/configs/mx51_defconfig b/arch/arm/configs/mx51_defconfig
index a665ecb..4f3067b 100644
--- a/arch
Based on SDHCI API, esdhc driver supports PIO and simple internal
DMA modes.
Signed-off-by: Richard Zhu
---
drivers/mmc/host/Kconfig | 13 ++
drivers/mmc/host/Makefile|1 +
drivers/mmc/host/sdhci-imx.c | 395 ++
3 files changed, 409 insertio
Add host's own get_ro func to support the controller that used it's own WP
mechanism
Some controllers maybe have their exceptional WP mechanism in the different HW
design
when implement the get_ro, add one get_ro api to supported them.
Signed-off-by: Richard Zhu
---
drivers/mmc/host/sdhci-pltf
Based on SDHCI API, esdhc driver supports PIO and simple internal
DMA modes.
Signed-off-by: Richard Zhu
---
drivers/mmc/host/Kconfig | 13 ++
drivers/mmc/host/Makefile|1 +
drivers/mmc/host/sdhci-imx.c | 395 ++
3 files changed, 409 insertio
Modify the machine specific codes and add the eSDHC1 and eSDHC2 support
on MX51 BBG platform.
IOMUX, CLOCK, register the device.
Signed-off-by: Richard Zhu
---
arch/arm/mach-mx5/board-mx51_babbage.c | 38 ++
arch/arm/mach-mx5/clock-mx51.c | 193 ++
Add host's own get_ro func to support the controller that used it's own WP
mechanism
Some controllers maybe have their exceptional WP mechanism in the different HW
design
when implement the get_ro, add one get_ro api to supported them.
Signed-off-by: Richard Zhu
---
drivers/mmc/host/sdhci-pltf
Enable the fsl esdhc driver on mx51 platforms
Signed-off-by: Richard Zhu
---
arch/arm/configs/mx51_defconfig |9 +++--
1 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/arch/arm/configs/mx51_defconfig b/arch/arm/configs/mx51_defconfig
index a665ecb..4f3067b 100644
--- a/arch
Hi Wolfram:
Here are the patches that I changed the codes refer to your previous comments.
The data IO and WP func are verified on the i.MX51 BBG board.
The missing bits of the HOST_CONTROL and so on had been complemented in 4-3
patch.
Hi Uwe:
The MSL specifed part code is still on-going.
I woul
Hi,
On Mon, Sep 20, 2010 at 03:32:58AM -0400, zhangfei gao wrote:
> From: Zhangfei Gao
> Date: Mon, 20 Sep 2010 15:15:18 -0400
> Subject: [PATCH 4/4] sdhci: correct f_min in sd 3.0
>
> Change-Id: Ie8604dbb5296b15da67071164564f21c60652b60
>
> Signed-off-by: Zhangfei Gao
> ---
> drivers/mmc/hos
Hi Wolfram:
I have the following a few common comments about these patches.
* About the share between i.MX and PPC eSDHC.
Why configure a few parts be shared between the i.MX eSDHC and PPC
eSDHC? Can they be separated into two independent systems?
It would bring the conveniences to maintain stuff
Hi,
On Mon, Sep 20, 2010 at 03:32:58AM -0400, zhangfei gao wrote:
> From: Zhangfei Gao
> Date: Mon, 20 Sep 2010 15:15:18 -0400
> Subject: [PATCH 4/4] sdhci: correct f_min in sd 3.0
>
> Change-Id: Ie8604dbb5296b15da67071164564f21c60652b60
>
> Signed-off-by: Zhangfei Gao
> ---
> drivers/mmc/hos
* Sukumar Ghorai [100915 07:41]:
> wires variable is renamed, extended and this single variable to be used to
> pass the platform capabilities, e.g DDR mode. Also removed the hardcoded
> value was using as bus-width.
This looks like a nice clean-up, I'll queue this via the omap
patches.
Re
2010/6/22 Rabin Vincent :
> The Ux500 variants have only one IRQ line hooked up. Allow these to
> work by directing the PIO interrupts also to the first IRQ line.
I see this one is dangling in the patch tracker, FYI I have regression
tested this on the PB1176MPcore with its unmodified ARM PL180
Hi Ben,
On Thu, Sep 23, 2010 at 04:22:05PM +0200, Marek Szyprowski wrote:
> If not all clocks has been defined in platform data, driver will cause
> a null pointer dereference when it is being removed. This patch fixes
> this issue.
>
> Signed-off-by: Marek Szyprowski
> Signed-off-by: Kyungmin P
If its not already gone through...
Acked-by: Ian Molton
--
Ian Molton
Linux, Automotive, and other hacking:
http://www.mnementh.co.uk/
On 30 August 2010 11:50, Matt Fleming wrote:
> From: Yusuke Goda
>
> Adjust the tmio_mmc block size check to accept 2-byte requests in 4-bit
> mode if the
On Thu, 23 Sep 2010 16:22:05 +0200
Marek Szyprowski wrote:
> If not all clocks has been defined in platform data, driver will cause
> a null pointer dereference when it is being removed. This patch fixes
> this issue.
>
> Signed-off-by: Marek Szyprowski
> Signed-off-by: Kyungmin Park
> ---
>
> That's a much bigger change, though -- you'd be making sdhci_dumpregs()
> a no-op unless CONFIG_MMC_DEBUG is defined, right? That's a change in
> semantics, since it's intentionally called from many non-debug error
> paths right now.
Hmm, true. dev_info would keep the semantics then, but chang
Hi Wolfram,
On Thu, Sep 23, 2010 at 10:39:46AM +0200, Wolfram Sang wrote:
> Uh, that was fast.
Sorry, you're right, was fast. I'm okay with improving patches after
they enter mmc-next, but I'll leave more time for comments on patches
in future before merging.
> I would have preferred to switch
>From 8502f5450c8d97d5a096269c44196684e7e0957d Mon Sep 17 00:00:00 2001
From: Philip Rakity
Date: Thu, 23 Sep 2010 08:45:38 -0700
Subject: [PATCH] sdhci: Show SD Command when doing debug printks
helps to know if read or write to understand error
Signed-off-by: Philip Rakity
---
drivers/mmc/hos
Re did patch to fit into 80 char line length rule
=
>From 1ba80b60d0ca3ba3114e2aa25f1afdb8a6af3842 Mon Sep 17 00:00:00 2001
From: Philip Rakity
Date: Thu, 23 Sep 2010 08:15:03 -0700
Subject: [PATCH] sdhci: allow for initial eMMC 74 clock generation by controller
resend of patch to
Hi All,
I am working on integrating the mmc driver on Linux and when I try to mount the
device I always get the error "mounting /dev/mmc on m failed: Invalid argument"
.
I also see that when ever I try to mount,the drivers request function is invoked
to read the first sector(MBR).Thus the driver a
If not all clocks has been defined in platform data, driver will cause
a null pointer dereference when it is being removed. This patch fixes
this issue.
Signed-off-by: Marek Szyprowski
Signed-off-by: Kyungmin Park
---
drivers/mmc/host/sdhci-s3c.c |6 --
1 files changed, 4 insertions(+),
With current code card insert/eject interrupts will acknowledge outstanding
commands. Normally this seems to be no problem, however if the hardware gets
stuck and no interrupts for CMD_TIMEOUT or CMD_RESPEND are generated, then
inserting and ejecting cards will falsely acknowledge outstanding comma
When doing excessive hotplug, e.g., repeated insert/eject operations,
the hardware may get confused to a point where no CMDTIMEOUT/CMDRESPEND
interrupts are generated any more.
As a result requests get stuck, e.g.:
[ 360.351562] INFO: task kworker/u:0:5 blocked for more than 120 seconds.
[ 360.3
Hi
Here are two fixes for mmc_test performance tests. They apply to the mmc-next
branch of Chris Ball's mmc tree at:
git://git.kernel.org/pub/scm/linux/kernel/git/cjb/mmc.git
The following changes since commit 0bff5cae99dfc9f820cdbddcc4f2cf55627ccfac:
Philip Rakity (1):
mmc: s
>From 676448f4d2623103cc5a4d246afe9ce32b7f339d Mon Sep 17 00:00:00 2001
From: Adrian Hunter
Date: Thu, 23 Sep 2010 13:08:21 +0300
Subject: [PATCH 2/2] mmc_test: fix display of .5 KiB
Append .5 to KiB display when there are an odd number of
sectors.
Signed-off-by: Adrian Hunter
---
drivers/mmc/
>From aad98716cd9e8f83831721010d58d2a9f8ea2d2b Mon Sep 17 00:00:00 2001
From: Adrian Hunter
Date: Thu, 23 Sep 2010 12:55:15 +0300
Subject: [PATCH 1/2] mmc_test: fix memory allocation segment limits
Correctly allocate memory to meet the host controller
driver's maximum segment size and count limit
On 09/23/2010 11:51 AM, Wolfram Sang wrote:
>
>> static int mmc_pad_resources(struct sdhci_host *sdhci)
>> {
>> if (!devm_stm_pad_claim(sdhci->mmc->parent,
>> &stx7108_mmc_pad_config,
>> dev_name(sdhci->mmc->parent)))
>>
> static int mmc_pad_resources(struct sdhci_host *sdhci)
> {
> if (!devm_stm_pad_claim(sdhci->mmc->parent,
> &stx7108_mmc_pad_config,
> dev_name(sdhci->mmc->parent)))
> return -ENODEV;
>
> return 0;
>
On 09/23/2010 10:48 AM, Wolfram Sang wrote:
> I think it will be better to give init() access to all information
> needed than to implement another hook. I tried with this patch
>
> https://patchwork.kernel.org/patch/196992/
>
> I am still not sure what kind of information you need from the pdev.
This patch fixes a warning when compile the sdhci:
pwr may be used uninitialized in sdhci_set_power
Also removes some include files that live in sdhci.h
header file.
Signed-off-by: Giuseppe Cavallaro
---
drivers/mmc/host/sdhci.c | 11 ++-
1 files changed, 2 insertions(+), 9 deletions
Some platforms based on the shdci-pltfm device driver need to
set own quirks (that currently are in drivers/mmc/host/sdhci.h).
This patch splits this header file in two parts:
o drivers/mmc/host/sdhci.h
it includes the HC registers
o include/linux/mmc/sdhci.h
it includes the private st
Signed-off-by: Giuseppe Cavallaro
---
drivers/mmc/host/sdhci-pltfm.c | 22 ++
1 files changed, 22 insertions(+), 0 deletions(-)
diff --git a/drivers/mmc/host/sdhci-pltfm.c b/drivers/mmc/host/sdhci-pltfm.c
index e045e3c..89ea64b 100644
--- a/drivers/mmc/host/sdhci-pltfm.c
++
> >> 3) In the end, another hook could be added in the sdhci_pltfm_data to
> >>invoke specific own functions for claiming resources etc.
> >>For example, I need an extra callback to invoke the STM pad manager
> >>that's used for managing clocks, PIO lines and syscfg registers.
> >>
> >>
On Thu, Sep 23, 2010 at 12:08:06AM +0100, Chris Ball wrote:
> Hi Philip,
>
> On Wed, Sep 22, 2010 at 03:25:13PM -0700, Philip Rakity wrote:
> > Subject: [PATCH] sdhci: print out controller name for register debug
> >
> > In a multi-controller environment it is helpful to know which controller
> >
41 matches
Mail list logo
