[PATCH 1/2] [media] ds3000: Remove useless 'locking'

2012-08-30 Thread Rémi Cardona
s (and not recursion as the comments suggest). However, this open- coded mechanism is anything but race-free and should have used a proper mutex. Signed-off-by: Rémi Cardona --- drivers/media/dvb/frontends/ds3000.c |9 - 1 file changed, 9 deletions(-) diff --git a/drivers/media/dvb/fronte

[PATCH RFC 0/2] ds3000 firmware loading improvements

2012-08-30 Thread Rémi Cardona
ch be of interest? Would a patch that completely removes the register check (and thus always loads the firmware at init time) be a preferred alternative? Thanks for any pointers/reviews. Rémi Cardona -- SmartJog | T: +33 1 5868 6229 27 Blvd Hippolyte Marquès, 94200 Ivry-sur-Seine, France www.s

[PATCH 2/2] [media] ds3000: properly report firmware loading issues

2012-08-30 Thread Rémi Cardona
ds3000_readreg() returns negative values in case of i2c failures. The old code would simply return 0 when failing to read the 0xb2 register, misleading ds3000_initfe() into believing that the firmware had been correctly loaded. Signed-off-by: Rémi Cardona --- drivers/media/dvb/frontends/ds3000

Re: [PATCH 2/2] [media] ds3000: properly report firmware loading issues

2012-08-30 Thread Rémi Cardona
Hi Antti, On 08/30/2012 03:39 PM, Antti Palosaari wrote: > As I understand firmware downloading failure is coming from the fact > that register read fails => fails to detect if firmware is already > running or not. Well we actually see 2 cases: - the register read failure (when ds3000_readreg()

Re: [PATCH 2/2] [media] ds3000: properly report firmware loading issues

2012-09-03 Thread Rémi Cardona
On 08/30/2012 06:00 PM, Antti Palosaari wrote: > hmm, looks like ds3000_readreg() logic is still a little bit broken. It > checks count of sent messages and compares it to 2. But if I2C-adapter > sends only 1 message or 3 (which should not be possible) function return > that count instead of -EREMO

Re: [PATCH 2/2] [media] ds3000: properly report firmware loadingissues

2012-09-03 Thread Rémi Cardona
Hi Max, On 08/31/2012 10:29 AM, nibble.max wrote: > As remember that there is a fault in the tuner register read function in > ds3000.c file. > It will cause the read back value wrong. Well, using 0x12 works out for most of the cards we have in the wild. Not knowing what 0x11 / 0x12 means, I'd b

Re: [PATCH 1/2] [media] ds3000: Remove useless 'locking'

2012-09-03 Thread Rémi Cardona
On 08/30/2012 11:36 AM, Rémi Cardona wrote: > Since b9bf2eafaad9c1ef02fb3db38c74568be601a43a, the function > ds3000_firmware_ondemand() is called only once during init. This > locking scheme may have been useful when the firmware was loaded at > each tune. > > Furthermore,

[PATCH v2 0/6] ds3000 improvements

2012-09-14 Thread Rémi Cardona
Hi all, Here is an updated and more complete patch series for ds3000. I've done my testing on top of kernel 3.5.2 and things look ok so far. Reviews and comments are again more than welcome. Cheers, Rémi Cardona -- SmartJog | T: +33 1 5868 6229 27 Blvd Hippolyte Marquès, 94200 Ivry-sur-

[PATCH 2/6] [media] ds3000: remove useless 'locking'

2012-09-14 Thread Rémi Cardona
s (and not recursion as the comments suggest). However, this open- coded mechanism is anything but race-free and should have used a proper mutex. Signed-off-by: Rémi Cardona --- drivers/media/dvb/frontends/ds3000.c |9 - 1 file changed, 9 deletions(-) diff --git a/drivers/media/dvb/fronte

[PATCH 4/6] [media] ds3000: bail out early on i2c failures during firmware load

2012-09-14 Thread Rémi Cardona
-off-by: Rémi Cardona --- drivers/media/dvb/frontends/ds3000.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/media/dvb/frontends/ds3000.c b/drivers/media/dvb/frontends/ds3000.c index 675..162faaf 100644 --- a/drivers/media/dvb/frontends/ds3000.c

[PATCH 1/6] [media] ds3000: Declare MODULE_FIRMWARE usage

2012-09-14 Thread Rémi Cardona
Signed-off-by: Rémi Cardona --- drivers/media/dvb/frontends/ds3000.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/dvb/frontends/ds3000.c b/drivers/media/dvb/frontends/ds3000.c index 4c8ac26..46874c7 100644 --- a/drivers/media/dvb/frontends/ds3000.c +++ b/drivers/media

[PATCH 6/6] [media] ds3000: add module parameter to force firmware upload

2012-09-14 Thread Rémi Cardona
Signed-off-by: Rémi Cardona --- drivers/media/dvb/frontends/ds3000.c |9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/media/dvb/frontends/ds3000.c b/drivers/media/dvb/frontends/ds3000.c index 970963c..3e0e9de 100644 --- a/drivers/media/dvb/frontends/ds3000

[PATCH 5/6] [media] ds3000: properly report firmware probing issues

2012-09-14 Thread Rémi Cardona
loaded. This should make it more obvious if the chip is in a weird state. Signed-off-by: Rémi Cardona --- drivers/media/dvb/frontends/ds3000.c |8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/media/dvb/frontends/ds3000.c b/drivers/media/dvb/frontends/ds3000.c

[PATCH 3/6] [media] ds3000: properly report register read errors

2012-09-14 Thread Rémi Cardona
This brings both ds3000_readreg() and ds3000_tuner_readreg() in line with ds3000_writereg() and ds3000_tuner_writereg() respectively. Signed-off-by: Rémi Cardona --- drivers/media/dvb/frontends/ds3000.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers

Re: [PATCH v2 0/6] ds3000 improvements

2012-09-17 Thread Rémi Cardona
On 09/16/2012 03:26 AM, Antti Palosaari wrote: > On 09/14/2012 12:27 PM, Rémi Cardona wrote: >> Hi all, >> >> Here is an updated and more complete patch series for ds3000. I've >> done my testing on top of kernel 3.5.2 and things look ok so far. >> >&

[PATCH 6/7] [media] ds3000: add module parameter to force firmware upload

2012-09-28 Thread Rémi Cardona
Signed-off-by: Rémi Cardona --- drivers/media/dvb-frontends/ds3000.c |6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/media/dvb-frontends/ds3000.c b/drivers/media/dvb-frontends/ds3000.c index 59184a8..c66d731 100644 --- a/drivers/media/dvb-frontends/ds3000.c

[PATCH 7/7] [media] dw2102: Declare MODULE_FIRMWARE usage

2012-09-28 Thread Rémi Cardona
Signed-off-by: Rémi Cardona --- drivers/media/usb/dvb-usb/dw2102.c | 36 ++-- 1 file changed, 26 insertions(+), 10 deletions(-) diff --git a/drivers/media/usb/dvb-usb/dw2102.c b/drivers/media/usb/dvb-usb/dw2102.c index 9382895..937c744 100644 --- a/drivers

[PATCH v3 0/7] ds3000/dw2102 improvements

2012-09-28 Thread Rémi Cardona
h 7 is new, as we have recently gotten a few S480 cards from TeVii and we were missing their firmware, and found modinfo to be lacking the info. Thanks again for any review/comments. Cheers, Rémi Cardona -- SmartJog | T: +33 1 5868 6229 27 Blvd Hippolyte Marquès, 94200 Ivry-sur-Sei

[PATCH 2/7] [media] ds3000: remove useless 'locking'

2012-09-28 Thread Rémi Cardona
s (and not recursion as the comments suggest). However, this open- coded mechanism is anything but race-free and should have used a proper mutex. Signed-off-by: Rémi Cardona --- drivers/media/dvb-frontends/ds3000.c |9 - 1 file changed, 9 deletions(-) diff --git a/drivers/media/dvb-fronte

[PATCH 4/7] [media] ds3000: bail out early on i2c failures during firmware load

2012-09-28 Thread Rémi Cardona
-off-by: Rémi Cardona --- drivers/media/dvb-frontends/ds3000.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/media/dvb-frontends/ds3000.c b/drivers/media/dvb-frontends/ds3000.c index 675..162faaf 100644 --- a/drivers/media/dvb-frontends/ds3000.c

[PATCH 5/7] [media] ds3000: properly report firmware probing issues

2012-09-28 Thread Rémi Cardona
ds3000_readreg() returns negative values in case of i2c failures. The old code would simply return 0 when failing to read the 0xb2 register, misleading ds3000_initfe() into believing that the firmware had been correctly loaded. Signed-off-by: Rémi Cardona --- drivers/media/dvb-frontends/ds3000

[PATCH 1/7] [media] ds3000: Declare MODULE_FIRMWARE usage

2012-09-28 Thread Rémi Cardona
Signed-off-by: Rémi Cardona --- drivers/media/dvb-frontends/ds3000.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/dvb-frontends/ds3000.c b/drivers/media/dvb-frontends/ds3000.c index 4c8ac26..46874c7 100644 --- a/drivers/media/dvb-frontends/ds3000.c +++ b/drivers/media

[PATCH 3/7] [media] ds3000: properly report register read errors

2012-09-28 Thread Rémi Cardona
This brings both ds3000_readreg() and ds3000_tuner_readreg() in line with ds3000_writereg() and ds3000_tuner_writereg() respectively. Signed-off-by: Rémi Cardona --- drivers/media/dvb-frontends/ds3000.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers

Re: [PATCH v3 0/7] ds3000/dw2102 improvements

2012-10-01 Thread Rémi Cardona
Hi Antti, I realized I forgot to CC you on those patches. Thanks for any further comments you might have. Cheers, Rémi Cardona -- SmartJog | T: +33 1 5868 6229 27 Blvd Hippolyte Marquès, 94200 Ivry-sur-Seine, France www.smartjog.com | a TDF Group company -- To unsubscribe from this list: send

[git:v4l-dvb/for_v3.7] [media] ds3000: add module parameter to force firmware upload

2012-10-08 Thread Rémi Cardona
471 cards we have in production, only a tiny fraction require this option. That's why I didn't change the default behavior. Cheers, Rémi Cardona -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More m