Re: v4l: Use the video_drvdata function in drivers

2009-11-18 Thread Laurent Pinchart
Hi Devin, On Wednesday 18 November 2009 10:36:45 Devin Heitmueller wrote: > On Wed, Nov 18, 2009 at 4:13 AM, Hans Verkuil wrote: > > I agree that it would help to split this patch up. Some cases are > > trivial, so they can be put together in one patch. When things get more > > complex it makes s

Re: v4l: Use the video_drvdata function in drivers

2009-11-18 Thread Devin Heitmueller
On Wed, Nov 18, 2009 at 4:42 AM, Laurent Pinchart wrote: > I will setup a test tree to help maintainers test the changes. I can split > some patches if needed, but how would that help exactly ? Hello Laurent, In this case, splitting up the patch would just make it easier to review, and potential

Re: v4l: Use the video_drvdata function in drivers

2009-11-18 Thread Laurent Pinchart
On Wednesday 18 November 2009 10:13:30 Hans Verkuil wrote: > > On Wed, Nov 18, 2009 at 2:01 AM, Hans Verkuil wrote: > >> Very nice cleanup! > > > > The last time I saw one of these relatively innocent-looking changes > > being done across all drivers without testing, it introduced a rather > > nas

Re: v4l: Use the video_drvdata function in drivers

2009-11-18 Thread Laurent Pinchart
Hi Devin, On Wednesday 18 November 2009 09:56:12 Devin Heitmueller wrote: > On Wed, Nov 18, 2009 at 2:01 AM, Hans Verkuil wrote: > > Very nice cleanup! > > The last time I saw one of these relatively innocent-looking changes > being done across all drivers without testing, it introduced a rather

Re: v4l: Use the video_drvdata function in drivers

2009-11-18 Thread Devin Heitmueller
On Wed, Nov 18, 2009 at 4:13 AM, Hans Verkuil wrote: > I agree that it would help to split this patch up. Some cases are trivial, > so they can be put together in one patch. When things get more complex it > makes sense to put it in a separate patch for easier reviewing by the > relevant maintaine

Re: v4l: Use the video_drvdata function in drivers

2009-11-18 Thread Laurent Pinchart
On Wednesday 18 November 2009 08:01:48 Hans Verkuil wrote: > On Wednesday 18 November 2009 01:38:48 Laurent Pinchart wrote: > > Fix all device drivers to use the video_drvdata function instead of > > maintaining a local list of minor to private data mappings. Call > > video_set_drvdata to register

Re: v4l: Use the video_drvdata function in drivers

2009-11-18 Thread Hans Verkuil
> On Wed, Nov 18, 2009 at 2:01 AM, Hans Verkuil wrote: >> Very nice cleanup! > > The last time I saw one of these relatively innocent-looking changes > being done across all drivers without testing, it introduced a rather > nasty and hard to find OOPS into one of my drivers and I had to fix > it:

Re: v4l: Use the video_drvdata function in drivers

2009-11-18 Thread Devin Heitmueller
On Wed, Nov 18, 2009 at 2:01 AM, Hans Verkuil wrote: > Very nice cleanup! The last time I saw one of these relatively innocent-looking changes being done across all drivers without testing, it introduced a rather nasty and hard to find OOPS into one of my drivers and I had to fix it: http://linu

Re: v4l: Use the video_drvdata function in drivers

2009-11-17 Thread Hans Verkuil
On Wednesday 18 November 2009 01:38:48 Laurent Pinchart wrote: > Fix all device drivers to use the video_drvdata function instead of > maintaining a local list of minor to private data mappings. Call > video_set_drvdata to register the driver private pointer when not > already done. > > Where appl

v4l: Use the video_drvdata function in drivers

2009-11-17 Thread Laurent Pinchart
Fix all device drivers to use the video_drvdata function instead of maintaining a local list of minor to private data mappings. Call video_set_drvdata to register the driver private pointer when not already done. Where applicable, the local list of mappings is completely removed when it becomes un