[PATCH v4l-utils] ir-keytable: bpf: improve rsc imon pointer decoder

2019-10-20 Thread Sean Young
Sometimes the remotes sends 4 bits rather than 5. This makes the pointer much more reliable. Signed-off-by: Sean Young --- utils/keytable/bpf_protocols/imon_rsc.c | 66 + 1 file changed, 35 insertions(+), 31 deletions(-) diff --git a/utils/keytable/bpf_protocols/imon_rsc

[PATCH v4l-utils] keytable: do not warn if keymap not found in IR_KEYTABLE_USER_DIR

2019-10-14 Thread Sean Young
The following error is logged even though imon_rsc.toml is found at /lib/udev/rc_keymaps/imon_rsc.toml: $ ir-keytable -a /etc/rc_maps.cfg /etc/rc_keymaps/imon_rsc.toml: error: cannot open: No such file or directory Signed-off-by: Sean Young --- utils/keytable/keytable.c | 78 +++

Re: v4l-utils undefined symbol: dvb_dev_alloc

2019-10-13 Thread _ _ _ _ _
9:02, Mauro Carvalho Chehab > wrote: > > Em Sat, 12 Oct 2019 18:28:41 +0100 > _ _ _ _ _ escreveu: > >> I've been waiting for a working version of DVB-S2 capable tools and >> utilities to appear in a stable release of Mint, but it hasn't happened >> yet,

Re: v4l-utils undefined symbol: dvb_dev_alloc

2019-10-12 Thread _ _ _ _ _
es to appear in a stable release of Mint, but it hasn't happened >> yet, so I decided to build the latest stable v4l-utils from source. >> >> I built v4l-utils version 1.18.0 on Linux Mint 18.3 >> >> the compilation process appeared to run through OK with only

Re: v4l-utils undefined symbol: dvb_dev_alloc

2019-10-12 Thread Mauro Carvalho Chehab
Em Sat, 12 Oct 2019 18:28:41 +0100 _ _ _ _ _ escreveu: > I've been waiting for a working version of DVB-S2 capable tools and utilities > to appear in a stable release of Mint, but it hasn't happened yet, so I > decided to build the latest stable v4l-utils from source. >

v4l-utils undefined symbol: dvb_dev_alloc

2019-10-12 Thread _ _ _ _ _
I've been waiting for a working version of DVB-S2 capable tools and utilities to appear in a stable release of Mint, but it hasn't happened yet, so I decided to build the latest stable v4l-utils from source. I built v4l-utils version 1.18.0 on Linux Mint 18.3 the compilation proces

Jenkins build is back to normal : v4l-utils #52

2019-10-03 Thread Jenkins Builder Robot
See <https://builder.linuxtv.org/job/v4l-utils/52/display/redirect?page=changes>

[PATCH v4l-utils] ir-ctl: report timeout when it cannot be modified

2019-10-03 Thread Sean Young
There are many IR devices which cannot modify their timeout, but do have a timeout which should be reported (e.g. mtk_cir). Signed-off-by: Sean Young --- utils/ir-ctl/ir-ctl.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/utils/ir-ctl/ir-ctl.c b/utils/ir-ctl/i

Build failed in Jenkins: v4l-utils #51

2019-10-03 Thread Jenkins Builder Robot
See <https://builder.linuxtv.org/job/v4l-utils/51/display/redirect?page=changes> Changes: [hverkuil-cisco] libcecutil: do not assume building in source tree. -- [...truncated 18.06 KB...] make[3]: Leaving directory '<https://builder.linux

Build failed in Jenkins: v4l-utils #50

2019-10-03 Thread Jenkins Builder Robot
See <https://builder.linuxtv.org/job/v4l-utils/50/display/redirect?page=changes> Changes: [hverkuil-cisco] utils/libcecutil: add CEC utility library [hverkuil-cisco] cec-follower: switch to the new CEC utilities library [hverkuil-cisco] cec-compliance: use the new CEC utilities l

Re: [PATCHv2 1/2] v4l: Add macros for printing V4L fourcc values

2019-10-02 Thread Ezequiel Garcia
On Mon, 2019-09-16 at 12:04 +0200, Hans Verkuil wrote: > From: Sakari Ailus > > Add two macros that facilitate printing V4L fourcc values with printf > family of functions. v4l2_fourcc_conv provides the printf conversion > specifier for printing formats and v4l2_fourcc_args prov

Re: [ANN] v4l-utils: remove utils/cec-follower/cec-log.h after a 'git pull'

2019-10-02 Thread Hans Verkuil
On 10/2/19 10:52 AM, Hans Verkuil wrote: > Just a heads up: I synced v4l-utils with the latest media_tree master branch, > and that required some reorganization for the CEC utilities. > > If you do a 'git pull' in an existing v4l-utils repo, then it will fail to > build

Re: Build failed in Jenkins: v4l-utils #43

2019-10-02 Thread Hans Verkuil
;> Hi Mauro, >>>> >>>> On 10/2/19 10:16 AM, Jenkins Builder Robot wrote: >>>>> See >>>>> <https://builder.linuxtv.org/job/v4l-utils/43/display/redirect?page=changes> >>>>> >>>>> Changes: >>>>>

Re: Build failed in Jenkins: v4l-utils #43

2019-10-02 Thread Mauro Carvalho Chehab
s Builder Robot wrote: > >>> See > >>> <https://builder.linuxtv.org/job/v4l-utils/43/display/redirect?page=changes> > >>> > >>> Changes: > >>> > >>> [hverkuil-cisco] keytable: add new generated keymaps > >>> &

Re: Build failed in Jenkins: v4l-utils #43

2019-10-02 Thread Hans Verkuil
On 10/2/19 11:36 AM, Mauro Carvalho Chehab wrote: > Em Wed, 2 Oct 2019 10:25:02 +0200 > Hans Verkuil escreveu: > >> Hi Mauro, >> >> On 10/2/19 10:16 AM, Jenkins Builder Robot wrote: >>> See >>> <https://builder.linuxtv.org/job/v4l-utils/4

Re: Build failed in Jenkins: v4l-utils #43

2019-10-02 Thread Mauro Carvalho Chehab
Em Wed, 2 Oct 2019 10:25:02 +0200 Hans Verkuil escreveu: > Hi Mauro, > > On 10/2/19 10:16 AM, Jenkins Builder Robot wrote: > > See > > <https://builder.linuxtv.org/job/v4l-utils/43/display/redirect?page=changes> > > > > Changes: > > > > [

Jenkins build is back to normal : v4l-utils #45

2019-10-02 Thread Jenkins Builder Robot
See <https://builder.linuxtv.org/job/v4l-utils/45/display/redirect>

Build failed in Jenkins: v4l-utils #44

2019-10-02 Thread Jenkins Builder Robot
See <https://builder.linuxtv.org/job/v4l-utils/44/display/redirect?page=changes> Changes: [hverkuil-cisco] cec utils: support CEC_ADAP_G_CONNECTOR_INFO -- [...truncated 1.09 MB...] ^~~ log_msg In file included from cec-followe

[ANN] v4l-utils: remove utils/cec-follower/cec-log.h after a 'git pull'

2019-10-02 Thread Hans Verkuil
Just a heads up: I synced v4l-utils with the latest media_tree master branch, and that required some reorganization for the CEC utilities. If you do a 'git pull' in an existing v4l-utils repo, then it will fail to build due to an orphaned utils/cec-follower/cec-log.h file. Just remove

Re: Build failed in Jenkins: v4l-utils #43

2019-10-02 Thread Hans Verkuil
Hi Mauro, On 10/2/19 10:16 AM, Jenkins Builder Robot wrote: > See > <https://builder.linuxtv.org/job/v4l-utils/43/display/redirect?page=changes> > > Changes: > > [hverkuil-cisco] keytable: add new generated keymaps > > [hverkuil-cisco] msg2ctl.pl: add newlin

Build failed in Jenkins: v4l-utils #43

2019-10-02 Thread Jenkins Builder Robot
See <https://builder.linuxtv.org/job/v4l-utils/43/display/redirect?page=changes> Changes: [hverkuil-cisco] keytable: add new generated keymaps [hverkuil-cisco] msg2ctl.pl: add newline after log_msg [hverkuil-cisco] cec-follower: drop the hardcoded UI commands list [hverkuil-cisco] cec-c

[PATCH v11 02/15] media: v4l: link dt-bindings and uapi

2019-09-30 Thread Marco Felsch
Since we expose the definition to the dt-bindings we need to keep those definitions in sync. To address this the patch adds a simple cross reference to the dt-bindings. Signed-off-by: Marco Felsch --- Changelog: v11: - new patch since the split https://patchwork.linuxtv.org/patch/58491/ v2-v10:

[PATCH 1/1] v4l: fwnode: Make v4l2_fwnode_endpoint_free() safer

2019-09-23 Thread Sakari Ailus
Assign vep->link_frequencies to NULL after releasing its memory. Without this change, multiple calls to v4l2_fwnode_endpoint_free() would result in double kfree calls. Signed-off-by: Sakari Ailus --- drivers/media/v4l2-core/v4l2-fwnode.c | 1 + 1 file changed, 1 insertion(+) diff --git a/driver

[PATCH 1/1] v4l: Put camera sensor, lens and flash drivers under MEDIA_CAMERA_SUPPORT

2019-09-23 Thread Sakari Ailus
Instead of individually depending on MEDIA_CAMERA_SUPPORT (or forgetting it), put all camera sensor, lens and flash drivers under MEDIA_CAMERA_SUPPORT as a whole. The lens VCM devices didn't use to do this, but make them depend on MEDIA_CAMERA_SUPPORT as well since there's no use for these devices

Re: [PATCH] media: v4l: cadence: Fix how unsued lanes are handled in 'csi2rx_start()'

2019-09-17 Thread Marc Gonzalez
On 12/09/2019 22:44, Christophe JAILLET wrote: > Subject: [PATCH] media: v4l: cadence: Fix how unsued lanes are handled in > 'csi2rx_start()' s/unsued/unused > The 2nd parameter of 'find_first_zero_bit()' is a number of bits, not of > bytes. So use 'BITS_PE

Re: [PATCHv2 1/2] v4l: Add macros for printing V4L fourcc values

2019-09-16 Thread Hans Verkuil
On 9/16/19 2:07 PM, Sakari Ailus wrote: > On Mon, Sep 16, 2019 at 12:04:32PM +0200, Hans Verkuil wrote: >> From: Sakari Ailus >> >> Add two macros that facilitate printing V4L fourcc values with printf >> family of functions. v4l2_fourcc_conv provides the printf

Re: [PATCHv2 1/2] v4l: Add macros for printing V4L fourcc values

2019-09-16 Thread Sakari Ailus
On Mon, Sep 16, 2019 at 12:04:32PM +0200, Hans Verkuil wrote: > From: Sakari Ailus > > Add two macros that facilitate printing V4L fourcc values with printf > family of functions. v4l2_fourcc_conv provides the printf conversion > specifier for printing formats and v4l2_fourcc_ar

[PATCHv2 1/2] v4l: Add macros for printing V4L fourcc values

2019-09-16 Thread Hans Verkuil
From: Sakari Ailus Add two macros that facilitate printing V4L fourcc values with printf family of functions. v4l2_fourcc_conv provides the printf conversion specifier for printing formats and v4l2_fourcc_args provides the actual arguments for that conversion specifier. These macros are useful

Re: [RFC] V4L2 & Metadata: switch to /dev/v4l-metaX instead of /dev/videoX

2019-09-14 Thread Laurent Pinchart
on that allows you > to select whether you want metadata devices to appear as videoX or v4l-metaX. > I would prefer to set it to v4l-metaX by default. > > We can also consider backporting this to the stable/long-term kernels. > > Metadata capture was introduced in 4.12 for the

Re: [RFC] V4L2 & Metadata: switch to /dev/v4l-metaX instead of /dev/videoX

2019-09-12 Thread Hans Verkuil
On 9/12/19 4:57 PM, Philipp Zabel wrote: > On Thu, 2019-09-12 at 16:49 +0200, Hans Verkuil wrote: >> On 9/12/19 4:21 PM, Mauro Carvalho Chehab wrote: >>> Em Thu, 12 Sep 2019 14:16:11 +0100 >>> Kieran Bingham escreveu: >>> Hi Hans, On 12/09/2019 08:48, Hans Verkuil wrote: > Hi al

Re: [RFC] V4L2 & Metadata: switch to /dev/v4l-metaX instead of /dev/videoX

2019-09-12 Thread Philipp Zabel
On Thu, 2019-09-12 at 16:49 +0200, Hans Verkuil wrote: > On 9/12/19 4:21 PM, Mauro Carvalho Chehab wrote: > > Em Thu, 12 Sep 2019 14:16:11 +0100 > > Kieran Bingham escreveu: > > > > > Hi Hans, > > > > > > On 12/09/2019 08:48, Hans Verkuil wrote: > > > > Hi all, > > > > > > > > I am increasingly

Re: [RFC] V4L2 & Metadata: switch to /dev/v4l-metaX instead of /dev/videoX

2019-09-12 Thread Hans Verkuil
apabilities before exposing them for userspace to select. > >>> >>> This patch https://patchwork.linuxtv.org/patch/58693/ adds a new >>> VFL_TYPE_METADATA >>> so at least drivers can now explicitly signal that they want to register a >>> metadata d

Re: [RFC] V4L2 & Metadata: switch to /dev/v4l-metaX instead of /dev/videoX

2019-09-12 Thread Mauro Carvalho Chehab
ivers can now explicitly signal that they want to register a > > metadata device. > > > > This also makes it possible to add a kernel config option that allows you > > to select whether you want metadata devices to appear as videoX or > > v4l-metaX. > > I would pr

Re: [RFC] V4L2 & Metadata: switch to /dev/v4l-metaX instead of /dev/videoX

2019-09-12 Thread Hans Verkuil
metadata device. >> >> This also makes it possible to add a kernel config option that allows you >> to select whether you want metadata devices to appear as videoX or v4l-metaX. >> I would prefer to set it to v4l-metaX by default. > > I think I prefer this separation (

Re: [PATCH 2/6] v4l: subdev: Provide a locking scheme for subdev operations

2019-09-12 Thread Sakari Ailus
Hi Hans, On Thu, Sep 12, 2019 at 03:11:27PM +0200, Hans Verkuil wrote: > On 8/19/19 2:47 PM, Sakari Ailus wrote: > > The V4L2 sub-device's operations are called both from other drivers as > > well as through the IOCTL uAPI. Previously the sub-device drivers were > > responsible for managing their

Re: [RFC] V4L2 & Metadata: switch to /dev/v4l-metaX instead of /dev/videoX

2019-09-12 Thread Kieran Bingham
; to select whether you want metadata devices to appear as videoX or v4l-metaX. > I would prefer to set it to v4l-metaX by default. I think I prefer this separation (v4l-metaX). Having metadata as a (separate) videoX seemed odd to me - but I only saw/was affected by the metadata topics wh

Re: [PATCH 2/6] v4l: subdev: Provide a locking scheme for subdev operations

2019-09-12 Thread Hans Verkuil
On 8/19/19 2:47 PM, Sakari Ailus wrote: > The V4L2 sub-device's operations are called both from other drivers as > well as through the IOCTL uAPI. Previously the sub-device drivers were > responsible for managing their own serialisation. This patch adds an > optional mutex the drivers may set, and

Re: [PATCH 1/6] v4l: subdev: Set sd->devnode before registering the subdev

2019-09-12 Thread Hans Verkuil
On 8/19/19 2:47 PM, Sakari Ailus wrote: > The subdev's video device node was only assigned after registering the > device node in the system. While it is unlikely that a driver needed to > use this field in handling system calls to its file handle, there remains > a slim chance the devnode field re

[RFC] V4L2 & Metadata: switch to /dev/v4l-metaX instead of /dev/videoX

2019-09-12 Thread Hans Verkuil
VFL_TYPE_METADATA so at least drivers can now explicitly signal that they want to register a metadata device. This also makes it possible to add a kernel config option that allows you to select whether you want metadata devices to appear as videoX or v4l-metaX. I would prefer to set it to v4l-metaX by

[PATCH] v4l2-dev: refine selection of valid v4l-touch ioctls

2019-09-12 Thread Hans Verkuil
The selection of which ioctls are valid for touch devices was too wide. Refine this to only the set of ioctls that make sense for such devices. Signed-off-by: Hans Verkuil --- This patch sits on top of Vandana's metadata patch: https://patchwork.linuxtv.org/patch/58693/ --- drivers/media/v4l2-co

[PATCH v4l-utils] ir-ctl: support sending protocols decoded by BPF decoders

2019-09-06 Thread Sean Young
Encode keymaps using xbox-dvd, pulse_distance, pulse_length and manchester BPF decoders. The kernel has no idea how to encode them so this must be done in userspace. Signed-off-by: Sean Young --- utils/common/ir-encode.c | 26 ++- utils/common/keymap.c | 1 + utils/ir-ctl/Makefile.

[PATCH v4l-utils] keytable: ensure we have enough memlock pages

2019-09-04 Thread Sean Young
Since kernel v5.2, BPF maps and programs are charged against RLIMT_MEMLOCK. By default this limit is 64KB however all of these are already taken (16 patges) by the time we've booted on Fedora. This results in a permission denied. The error message is confusing since error happens when running as r

[PATCH v4l-utils] ir-ctl: warn if keycode has multiple definitions

2019-08-29 Thread Sean Young
Signed-off-by: Sean Young --- utils/ir-ctl/ir-ctl.c | 52 --- 1 file changed, 29 insertions(+), 23 deletions(-) diff --git a/utils/ir-ctl/ir-ctl.c b/utils/ir-ctl/ir-ctl.c index 28d8d97a..e884b4f8 100644 --- a/utils/ir-ctl/ir-ctl.c +++ b/utils/ir-ctl/ir-ctl

[PATCH v4l-utils] ir-ctl: support raw format by default

2019-08-28 Thread Sean Young
When "ir-ctl -r" outputs data it prints one line per space and pulse. This is not very space efficient and long protocols like rc-6 are unlikely to fit on the screen. The new format is much more compact. A single IR message is printed on a single line. The pulse is prefixed with an optional + and

[PATCH v4l-utils 2/2] toml: update to tomlc99 commit f12c8f00b457defaae1495773d76dfb9ff1bf4c8

2019-08-27 Thread Sean Young
The toml reader has a a slew of updates. Sync. Signed-off-by: Sean Young --- utils/common/toml.c | 1584 +++ utils/common/toml.h | 50 +- 2 files changed, 892 insertions(+), 742 deletions(-) diff --git a/utils/common/toml.c b/utils/common/toml.c index e

[PATCH v4l-utils 1/2] rc_keymap: change raw format to much more common raw string

2019-08-27 Thread Sean Young
Many programs and documentation lists raw IR a list of ints: +8800 –4400 +550 –1650 +550 –1650 +550 –1650 +550 –550 +550 The + and - are optional and are there for readability. I think this is much nicer format that 1) toml arrays and 2) lirc pulse space format. In fact, I think "ir-ctl

[PATCH v4l-utils 1/2] keytable: move keymap parsing into its own file

2019-08-26 Thread Sean Young
We would like to reuse keymap parsing for transmitting IR based on keymap in ir-ctl. This also reduces the size of our huge keytable.c, and keeps knowledge toml localised to the keymap parser. Signed-off-by: Sean Young --- utils/keytable/Makefile.am| 2 +- utils/keytable/bpf_load.c |

[PATCH v4l-utils 2/2] ir-ctl: send keys based on keymap

2019-08-26 Thread Sean Young
ir-ctl can now send keys based on rc keymaps. The keymap file must be specified and the keys to be sent: ir-ctl -k /lib/udev/rc_keymaps/hauppauge.toml -K KEY_VOLUMEUP Signed-off-by: Sean Young --- utils/common/keymap.c| 471 ++ utils/common/keymap.h| 39 + utils/common/toml.c

[PATCH 1/6] v4l: subdev: Set sd->devnode before registering the subdev

2019-08-19 Thread Sakari Ailus
The subdev's video device node was only assigned after registering the device node in the system. While it is unlikely that a driver needed to use this field in handling system calls to its file handle, there remains a slim chance the devnode field remains NULL while the driver expects to find a vi

[PATCH 2/6] v4l: subdev: Provide a locking scheme for subdev operations

2019-08-19 Thread Sakari Ailus
The V4L2 sub-device's operations are called both from other drivers as well as through the IOCTL uAPI. Previously the sub-device drivers were responsible for managing their own serialisation. This patch adds an optional mutex the drivers may set, and it will be used to serialise access to driver's

Re: [PATCH v2] v4l: rcar-fcp: Read IP version register at probe time

2019-08-16 Thread Laurent Pinchart
Hi Geert, On Fri, Aug 16, 2019 at 10:21:42AM +0200, Geert Uytterhoeven wrote: > On Wed, Aug 14, 2019 at 4:55 PM Laurent Pinchart wrote: > > This helps identifying the IP core version, for debugging purpose only > > for now. > > > > Signed-off-by: Laurent Pinchart > > > --- a/drivers/media/platfo

Re: [PATCH v2] v4l: rcar-fcp: Read IP version register at probe time

2019-08-16 Thread Laurent Pinchart
Hi Kieran, On Fri, Aug 16, 2019 at 09:07:14AM +0100, Kieran Bingham wrote: > On 14/08/2019 15:54, Laurent Pinchart wrote: > > This helps identifying the IP core version, for debugging purpose only > > for now. > > > > Signed-off-by: Laurent Pinchart > > --- > > Changes since v1: > > > > - Use d

Re: [PATCH v2] v4l: rcar-fcp: Read IP version register at probe time

2019-08-16 Thread Geert Uytterhoeven
Hi Laurent, On Wed, Aug 14, 2019 at 4:55 PM Laurent Pinchart wrote: > This helps identifying the IP core version, for debugging purpose only > for now. > > Signed-off-by: Laurent Pinchart > --- a/drivers/media/platform/rcar-fcp.c > +++ b/drivers/media/platform/rcar-fcp.c > @@ -138,6 +167,18 @@

Re: [PATCH v2] v4l: rcar-fcp: Read IP version register at probe time

2019-08-16 Thread Kieran Bingham
Hi Laurent, On 14/08/2019 15:54, Laurent Pinchart wrote: > This helps identifying the IP core version, for debugging purpose only > for now. > > Signed-off-by: Laurent Pinchart > --- > Changes since v1: > > - Use devm_platform_ioremap_resource() > --- > drivers/media/platform/rcar-fcp.c | 41 +

[PATCH v2] v4l: rcar-fcp: Read IP version register at probe time

2019-08-14 Thread Laurent Pinchart
This helps identifying the IP core version, for debugging purpose only for now. Signed-off-by: Laurent Pinchart --- Changes since v1: - Use devm_platform_ioremap_resource() --- drivers/media/platform/rcar-fcp.c | 41 +++ 1 file changed, 41 insertions(+) diff --git a

Re: [PATCH v2 1/1] v4l: Documentation: Serial busses use parallel mbus codes

2019-08-13 Thread Hans Verkuil
Ailus Acked-by: Hans Verkuil Regards, Hans > --- > since v1: > > - Add an example of mbus pixel codes on serial and parallel busses. > > Documentation/media/kapi/csi2.rst | 7 +++ > Documentation/media/uapi/v4l/subdev-formats.rst | 8 >

[PATCH v2 1/1] v4l: Documentation: Serial busses use parallel mbus codes

2019-08-13 Thread Sakari Ailus
. Documentation/media/kapi/csi2.rst | 7 +++ Documentation/media/uapi/v4l/subdev-formats.rst | 8 2 files changed, 15 insertions(+) diff --git a/Documentation/media/kapi/csi2.rst b/Documentation/media/kapi/csi2.rst index a7e75e2eba85a..c67736a15c45b 100644 --- a/Documentation

Re: [PATCH v2 1/1] v4l: Documentation: Raw Bayer formats are not RGB formats

2019-08-13 Thread Hans Verkuil
> - Remove _rgb-formats: and refer to _pixfmt-rgb: instead. Same for > _rgb-formats-deprecated. > > Documentation/media/uapi/v4l/control.rst |2 +- > Documentation/media/uapi/v4l/hist-v4l2.rst|2 +- > .../v4l/{pixfmt-rgb.rst => pixfmt-bayer.

[PATCH v2 1/1] v4l: Documentation: Raw Bayer formats are not RGB formats

2019-08-13 Thread Sakari Ailus
Ailus --- since v1: - Add description for raw Bayer formats - Fix reference clash (rename _pixfmt-rgb to _pixfmt-bayer in pixfmt-bayer.rst) - Remove _rgb-formats: and refer to _pixfmt-rgb: instead. Same for _rgb-formats-deprecated. Documentation/media/uapi/v4l/control.rst |2 +- Document

Re: [PATCH 1/1] v4l: Documentation: Raw Bayer formats are not RGB formats

2019-08-13 Thread Sakari Ailus
get this warning when building the docs: > > Documentation/media/uapi/v4l/pixfmt-bayer.rst:14: WARNING: duplicate label > pixfmt-rgb, other instance in Documentation/media/uapi/v4l/pixfmt-rgb.rst Oops. I built the documentation but somehow missed this. I'll fix it. > > >

[PATCH v4l-utils] v4l-helpers.h: count mappings separately from buffers

2019-08-13 Thread Philipp Zabel
This is required to avoid leaking mapped buffers when trying to unmap after reqbufs(0), to test buffer orphaning. Fixes: 6300b376cb3e ("v4l2-compliance: test orphaned buffer support"); Signed-off-by: Philipp Zabel --- utils/common/v4l-helpers.h | 8 ++-- 1 file changed, 6 insert

Re: [PATCH 1/1] v4l: Documentation: Serial busses use parallel mbus codes

2019-08-13 Thread Hans Verkuil
> --- > Documentation/media/kapi/csi2.rst | 7 +++ > Documentation/media/uapi/v4l/subdev-formats.rst | 4 > 2 files changed, 11 insertions(+) > > diff --git a/Documentation/media/kapi/csi2.rst > b/Documentation/media/kapi/csi2.rst > index a7e75e2eb

Re: [PATCH 1/1] v4l: Documentation: Raw Bayer formats are not RGB formats

2019-08-13 Thread Hans Verkuil
hem into RGB and raw Bayer formats. > > Signed-off-by: Sakari Ailus Fantastic! This has been annoying me for a long time. Very nice improvement. However, I get this warning when building the docs: Documentation/media/uapi/v4l/pixfmt-bayer.rst:14: WARNING: duplicate label pixfmt-rgb, other

[PATCH 1/1] v4l: Documentation: Raw Bayer formats are not RGB formats

2019-08-13 Thread Sakari Ailus
Ailus --- Documentation/media/uapi/v4l/pixfmt-bayer.rst | 29 + .../media/uapi/v4l/pixfmt-packed-rgb.rst | 1306 Documentation/media/uapi/v4l/pixfmt-rgb.rst | 1318 - Documentation/media/uapi/v4l/pixfmt.rst |1 + 4 files changed, 1327 insertions(+),

[PATCH 1/1] v4l: Documentation: Serial busses use parallel mbus codes

2019-08-13 Thread Sakari Ailus
/v4l/subdev-formats.rst | 4 2 files changed, 11 insertions(+) diff --git a/Documentation/media/kapi/csi2.rst b/Documentation/media/kapi/csi2.rst index a7e75e2eba85a..c67736a15c45b 100644 --- a/Documentation/media/kapi/csi2.rst +++ b/Documentation/media/kapi/csi2.rst @@ -72,3 +72,10 @@ the

[PATCH v2 v4l-utils] keytable: add support for keymap with raw literals

2019-08-08 Thread Sean Young
These rc keymaps look like: [[protocols]] name = 'Beon_Colour_TV' protocol = 'raw' [[protocols.raw]] keycode = 'KEY_POWER' raw = [ 1324, 842, 6697, 26400, 1324, 842, 6697 ] [[protocols.raw]] keycode = 'KEY_MUTE' raw = [ 1305,

[PATCH v4l-utils] keytable: add support for keymap with raw literal strings

2019-08-07 Thread Sean Young
This adds support for converting lircd raw_codes remote definitions. This means that the vast majority of lircd files can be converted. This feature requires loops in BPF programs so this is only supported in kernel 5.3 onwards. Signed-off-by: Sean Young --- contrib/lircd2toml.py

[PATCH v4l-utils] keytable: generate missing keys like KEY_ZOOM

2019-07-30 Thread Sean Young
The input-event-codes.h now contains lines like: Ensure these parsed correctly. Signed-off-by: Sean Young --- utils/keytable/Makefile.am | 40 + utils/keytable/gen_input_events.pl | 92 ++ utils/keytable/parse.h | 9 +++ 3 files chang

[PATCH v4l-utils] keytable: check keymaps

2019-07-30 Thread Sean Young
Signed-off-by: Sean Young --- utils/keytable/Makefile.am | 3 +++ utils/keytable/keytable.c | 40 +- 2 files changed, 29 insertions(+), 14 deletions(-) diff --git a/utils/keytable/Makefile.am b/utils/keytable/Makefile.am index 148b9446..0a8f5936 100644 --- a

[PATCH v4l-utils] ir-ctl: show user how scancodes should be presented

2019-07-23 Thread Sean Young
Currently ir-ctl just says the scancode is invalid, which is not very clear. Signed-off-by: Sean Young --- utils/common/ir-encode.c | 66 utils/common/ir-encode.h | 2 +- utils/ir-ctl/ir-ctl.c| 10 ++ 3 files changed, 56 insertions(+), 22 deletio

Re: [PATCH v5] media: v4l: ctrls: Add debug messages

2019-07-22 Thread Sakari Ailus
Hi Ezequiel, On Sat, Jul 20, 2019 at 08:47:07AM -0300, Ezequiel Garcia wrote: > Currently, the v4l2 control code is a bit silent on errors. > Add debug messages on (hopefully) most of the error paths. > > Signed-off-by: Ezequiel Garcia > --- > Changes from v3: > * Add missing parenthesis around

[PATCH v5] media: v4l: ctrls: Add debug messages

2019-07-20 Thread Ezequiel Garcia
Currently, the v4l2 control code is a bit silent on errors. Add debug messages on (hopefully) most of the error paths. Signed-off-by: Ezequiel Garcia --- Changes from v3: * Add missing parenthesis around macro argument. Changes from v3: * Fix checkpatch.pl warnings about long lines. Changes fro

Re: [PATCH v3] media: v4l: ctrls: Add debug messages

2019-07-20 Thread Ezequiel Garcia
On Sat, 2019-07-20 at 11:36 +0200, Hans Verkuil wrote: > On 7/19/19 11:53 PM, Ezequiel Garcia wrote: > > On Thu, 2019-06-27 at 09:38 +0200, Hans Verkuil wrote: > > > Hi Ezequiel, > > > > > > 'checkpatch.pl --strict' finds way too many issues. > > > > > > I'm pretty certain you didn't run it. > >

Re: [PATCH v3] media: v4l: ctrls: Add debug messages

2019-07-20 Thread Hans Verkuil
On 7/19/19 11:53 PM, Ezequiel Garcia wrote: > On Thu, 2019-06-27 at 09:38 +0200, Hans Verkuil wrote: >> Hi Ezequiel, >> >> 'checkpatch.pl --strict' finds way too many issues. >> >> I'm pretty certain you didn't run it. >> > > Shame on me, I did run it and skipped fixing the long lines :-( > >> Pl

[PATCH v4] media: v4l: ctrls: Add debug messages

2019-07-19 Thread Ezequiel Garcia
Currently, the v4l2 control code is a bit silent on errors. Add debug messages on (hopefully) most of the error paths. Signed-off-by: Ezequiel Garcia --- Changes from v3: * Fix checkpatch.pl warnings about long lines. Changes from v2: * Check and noisy-warn if vdev is NULL. Changes from v1: * D

Re: [PATCH v3] media: v4l: ctrls: Add debug messages

2019-07-19 Thread Ezequiel Garcia
On Thu, 2019-06-27 at 09:38 +0200, Hans Verkuil wrote: > Hi Ezequiel, > > 'checkpatch.pl --strict' finds way too many issues. > > I'm pretty certain you didn't run it. > Shame on me, I did run it and skipped fixing the long lines :-( > Please fix the issues and post a v4. > > A lot (but not a

Re: regarding commit "v4l2-ctl: get fmt after source change" in v4l-utils repository

2019-07-10 Thread Hans Verkuil
On 7/10/19 12:12 PM, Hans Verkuil wrote: > Hi Dafna, > > On 7/1/19 12:30 PM, Dafna Hirschfeld wrote: >> commit 84219e2b5d013709ee5259621715966c46eec746 >> Author: Hans Verkuil >> Date: Sat Mar 30 14:16:25 2019 +0100 >> >> v4l2-ctl: get fmt after source change >> >> When a source change

Re: regarding commit "v4l2-ctl: get fmt after source change" in v4l-utils repository

2019-07-10 Thread Hans Verkuil
Hi Dafna, On 7/1/19 12:30 PM, Dafna Hirschfeld wrote: > commit 84219e2b5d013709ee5259621715966c46eec746 > Author: Hans Verkuil > Date: Sat Mar 30 14:16:25 2019 +0100 > > v4l2-ctl: get fmt after source change > > When a source change event arrives during decoding get the new > form

[PATCH v2 1/2] v4l: Add 12-bit raw bayer linear packed formats

2019-07-07 Thread Edgar Thier
These formats are compressed 12-bit raw bayer formats with four different pixel orders. The pixel follow one another without any padding, thus are packed in a 'linear' fashion. Signed-off-by: Edgar Thier --- Documentation/media/uapi/v4l/pixfmt-rgb.rst | 1 + .../media/uapi/

Re: [PATCH 1/2] v4l: Add 12-bit raw bayer linear packed formats

2019-07-05 Thread Sakari Ailus
> > Signed-off-by: Edgar Thier > --- > Documentation/media/uapi/v4l/pixfmt-rgb.rst | 1 + > .../media/uapi/v4l/pixfmt-srggb12lp.rst | 60 +++ > drivers/media/v4l2-core/v4l2-ioctl.c | 4 ++ > include/uapi/linux/videodev2.h|

[PATCH 1/2] v4l: Add 12-bit raw bayer linear packed formats

2019-07-05 Thread Edgar Thier
These formats are compressed 12-bit raw bayer formats with four different pixel orders. The pixel follow one another without any padding, thus are packed in a 'linear' fashion. Signed-off-by: Edgar Thier --- Documentation/media/uapi/v4l/pixfmt-rgb.rst | 1 + .../media/uapi/

[PATCH v4l-utils 2/2] gen_keytables.pl: remove duplicate scancodes from keymap

2019-07-03 Thread Sean Young
One scancode can only be mapped to one keycode. In addition, the toml is invalid so the keymap cannot be loaded. Cc: Bastien Nocera Signed-off-by: Sean Young --- utils/keytable/gen_keytables.pl | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/utils/keytable/gen_k

[PATCH v4l-utils 1/2] gen_keytables.pl: strip comments from C files

2019-07-03 Thread Sean Young
Some keymaps contain mappings in comments which should have not been included. Cc: Bastien Nocera Signed-off-by: Sean Young --- utils/keytable/gen_keytables.pl | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/utils/keytable/gen_keytables.pl b/utils/keytable/gen

regarding commit "v4l2-ctl: get fmt after source change" in v4l-utils repository

2019-07-01 Thread Dafna Hirschfeld
commit 84219e2b5d013709ee5259621715966c46eec746 Author: Hans Verkuil Date: Sat Mar 30 14:16:25 2019 +0100 v4l2-ctl: get fmt after source change When a source change event arrives during decoding get the new format at that point instead of after restarting streaming. If there i

Re: [PATCH 1/2] v4l: Add Genicam 12-bit bayer packed formats

2019-06-28 Thread Sakari Ailus
ting Genicam PFNC as such is the obvious solution. I'd also expect the new naming convention to be used on existing formats, too, but that conversion should be done at the same time than adopting that convention for new formats. How about calling it "Linear Packed" as was sugg

[PATCH 1/2] v4l: Add Genicam 12-bit bayer packed formats

2019-06-28 Thread Edgar Thier
These formats are compressed 12-bit raw bayer formats with four different pixel orders. They are similar to 10-bit bayer formats 'IPU3'. The naming and pixel structure follow the Genicam Pixel Format Naming Convention (PFNC). Signed-off-by: Edgar Thier --- .../media/uapi/v4l/p

Re: [PATCH v3] media: v4l: ctrls: Add debug messages

2019-06-27 Thread Hans Verkuil
Hi Ezequiel, 'checkpatch.pl --strict' finds way too many issues. I'm pretty certain you didn't run it. Please fix the issues and post a v4. A lot (but not all) of the warnings report lines that are too long and from what I can see most are easily fixed without reducing readability. Regards,

[PATCH v4l-utils] ir-ctl: increase limit to match kernel

2019-06-25 Thread Sean Young
This changed in kernel v5.3. In earlier versions, EINVAL will be returned. Signed-off-by: Sean Young --- utils/ir-ctl/ir-ctl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/utils/ir-ctl/ir-ctl.c b/utils/ir-ctl/ir-ctl.c index ad830612..03c2791d 100644 --- a/utils/ir-ctl/

[PATCH v3] media: v4l: ctrls: Add debug messages

2019-06-22 Thread Ezequiel Garcia
Currently, the v4l2 control code is a bit silent on errors. Add debug messages on (hopefully) most of the error paths. Signed-off-by: Ezequiel Garcia --- Changes from v2: * Check and noisy-warn if vdev is NULL. Changes from v1: * Drop changes in the debug parameter semantics. * Drop new module d

Re: [PATCH v2] media: v4l: ctrls: Add debug messages

2019-06-22 Thread Ezequiel Garcia
On Sat, 2019-06-22 at 08:53 +0200, Hans Verkuil wrote: > On 6/22/19 12:50 AM, Ezequiel Garcia wrote: > > Currently, the v4l2 control code is a bit silent on errors. > > Add debug messages on (hopefully) most of the error paths. > > > > Signed-off-by: Ezequiel Garcia > > --- > > Changes from v1: >

Re: [PATCH v2] media: v4l: ctrls: Add debug messages

2019-06-21 Thread Hans Verkuil
On 6/22/19 12:50 AM, Ezequiel Garcia wrote: > Currently, the v4l2 control code is a bit silent on errors. > Add debug messages on (hopefully) most of the error paths. > > Signed-off-by: Ezequiel Garcia > --- > Changes from v1: > * Drop changes in the debug parameter semantics. > * Drop new module

[PATCH v2] media: v4l: ctrls: Add debug messages

2019-06-21 Thread Ezequiel Garcia
Currently, the v4l2 control code is a bit silent on errors. Add debug messages on (hopefully) most of the error paths. Signed-off-by: Ezequiel Garcia --- Changes from v1: * Drop changes in the debug parameter semantics. * Drop new module debug parameter. * Add documentation. * Add a debug error i

Re: [PATCH] v4l: rcar-fcp: Read IP version register at probe time

2019-06-09 Thread Laurent Pinchart
Hi Geert, On Sun, Jun 09, 2019 at 01:51:24PM +0200, Geert Uytterhoeven wrote: > On Sun, Jun 9, 2019 at 12:09 PM Laurent Pinchart wrote: > > On Sun, Jun 09, 2019 at 10:06:19AM +0200, Geert Uytterhoeven wrote: > > > On Sat, Jun 8, 2019 at 2:55 PM Laurent Pinchart wrote: > > > > This helps identifyin

Re: [PATCH] v4l: rcar-fcp: Read IP version register at probe time

2019-06-09 Thread Geert Uytterhoeven
Hi Laurent, On Sun, Jun 9, 2019 at 12:09 PM Laurent Pinchart wrote: > On Sun, Jun 09, 2019 at 10:06:19AM +0200, Geert Uytterhoeven wrote: > > On Sat, Jun 8, 2019 at 2:55 PM Laurent Pinchart wrote: > > > This helps identifying the IP core version, for debugging purpose only > > > for now. > > > >

Re: [PATCH] v4l: rcar-fcp: Read IP version register at probe time

2019-06-09 Thread Laurent Pinchart
Hi Geert, On Sun, Jun 09, 2019 at 10:06:19AM +0200, Geert Uytterhoeven wrote: > On Sat, Jun 8, 2019 at 2:55 PM Laurent Pinchart wrote: > > This helps identifying the IP core version, for debugging purpose only > > for now. > > > > Signed-off-by: Laurent Pinchart > > Thanks for your patch! > > >

Re: [PATCH] v4l: rcar-fcp: Read IP version register at probe time

2019-06-09 Thread Geert Uytterhoeven
Hi Laurent, On Sat, Jun 8, 2019 at 2:55 PM Laurent Pinchart wrote: > This helps identifying the IP core version, for debugging purpose only > for now. > > Signed-off-by: Laurent Pinchart Thanks for your patch! > --- a/drivers/media/platform/rcar-fcp.c > +++ b/drivers/media/platform/rcar-fcp.c

[PATCH] v4l: rcar-fcp: Read IP version register at probe time

2019-06-08 Thread Laurent Pinchart
This helps identifying the IP core version, for debugging purpose only for now. Signed-off-by: Laurent Pinchart --- drivers/media/platform/rcar-fcp.c | 43 +++ 1 file changed, 43 insertions(+) diff --git a/drivers/media/platform/rcar-fcp.c b/drivers/media/platform/r

Re: [PATCH v2 4/4] media: v4l: ctrls: Add debug messages

2019-06-03 Thread Ezequiel Garcia
On Mon, 2019-06-03 at 09:16 +0200, Hans Verkuil wrote: > On 6/1/19 7:57 PM, Ezequiel Garcia wrote: > > On Mon, 2019-03-11 at 12:36 +0100, Hans Verkuil wrote: > > > On 2/27/19 6:07 PM, Ezequiel Garcia wrote: > > > > Currently, the v4l2 control code is a bit silent on errors. > > > > Now that we have

Re: [PATCH v2 4/4] media: v4l: ctrls: Add debug messages

2019-06-03 Thread Hans Verkuil
On 6/1/19 7:57 PM, Ezequiel Garcia wrote: > On Mon, 2019-03-11 at 12:36 +0100, Hans Verkuil wrote: >> On 2/27/19 6:07 PM, Ezequiel Garcia wrote: >>> Currently, the v4l2 control code is a bit silent on errors. >>> Now that we have a debug parameter, it's possible to enable >>> debugging messages her

Re: [PATCH v2 4/4] media: v4l: ctrls: Add debug messages

2019-06-01 Thread Ezequiel Garcia
On Mon, 2019-03-11 at 12:36 +0100, Hans Verkuil wrote: > On 2/27/19 6:07 PM, Ezequiel Garcia wrote: > > Currently, the v4l2 control code is a bit silent on errors. > > Now that we have a debug parameter, it's possible to enable > > debugging messages here. > > > > Add debug messages on (hopefully)

  1   2   3   4   5   6   7   8   9   10   >