The changes made for the cx23888 caused regressions in the analog support
for cx23885/cx23887 based boards (partly due to changes in the locations of
the hue/saturation controls). As a result the wrong registers were being
overwritten.
Add code to use the correct registers if it's a cx
On Sun, 6 May 2012 12:14:55 +0200
Antonio Ospite wrote:
> Hi,
[...]
>
> Antonio Ospite (3):
> gspca - ov534: Add Saturation control
> Input: move drivers/input/fixp-arith.h to include/linux
> gspca - ov534: Add Hue control
>
These changes are now in
http://g
.h to include/linux
> gspca - ov534: Add Hue control
>
> drivers/input/ff-memless.c|3 +-
> drivers/input/fixp-arith.h| 87 --
> drivers/media/video/gspca/ov534.c | 146
> +++--
> include/linux/fixp-
Signed-off-by: Antonio Ospite
---
Changes since version 1:
- Disabled the HUE control for SENSOR_OV767x
drivers/media/video/gspca/ov534.c | 65 +++--
1 file changed, 63 insertions(+), 2 deletions(-)
diff --git a/drivers/media/video/gspca/ov534.c
b/drivers
: Add Saturation control
Input: move drivers/input/fixp-arith.h to include/linux
gspca - ov534: Add Hue control
drivers/input/ff-memless.c|3 +-
drivers/input/fixp-arith.h| 87 --
drivers/media/video/gspca/ov534.c | 146
On Mon, 30 Apr 2012 15:51:01 +0200
Antonio Ospite wrote:
> On Mon, 23 Apr 2012 14:16:25 -0600
> Jonathan Corbet wrote:
>
> > On Mon, 23 Apr 2012 15:21:04 +0200
> > Antonio Ospite wrote:
> >
> > > Jonathan, maybe fixp_sin() and fixp_cos() can be used in
> > > drivers/media/video/ov7670.c too w
On Mon, 23 Apr 2012 14:16:25 -0600
Jonathan Corbet wrote:
> On Mon, 23 Apr 2012 15:21:04 +0200
> Antonio Ospite wrote:
>
> > Jonathan, maybe fixp_sin() and fixp_cos() can be used in
> > drivers/media/video/ov7670.c too where currently ov7670_sine() and
> > ov7670_cosine() are defined, but I did
On Mon, 23 Apr 2012 15:21:04 +0200
Antonio Ospite wrote:
> Jonathan, maybe fixp_sin() and fixp_cos() can be used in
> drivers/media/video/ov7670.c too where currently ov7670_sine() and
> ov7670_cosine() are defined, but I didn't want to send a patch I could
> not test.
Seems like a good idea. N
On Mon, Apr 23, 2012 at 03:21:04PM +0200, Antonio Ospite wrote:
> Hi,
>
> here are a couple more of controls for the gspca ov534 subdriver.
>
> In order to control the HUE value the sensor expects sin(HUE) and
> cos(HUE) to be set so I decided to reuse the fixed point implem
If you "reply to all" please fix Johann Deneux's address, I mis-wrote
it, sorry.
Thanks,
Antonio
--
Antonio Ospite
http://ao2.it
A: Because it messes up the order in which people normally read text.
See http://en.wikipedia.org/wiki/Posting_style
Q: Why is top-posting such a bad thing?
p
CENSE("GPL");
/* controls */
enum e_ctrl {
+ HUE,
SATURATION,
BRIGHTNESS,
CONTRAST,
@@ -88,6 +91,7 @@ enum sensors {
};
/* V4L2 controls supported by the driver */
+static void sethue(struct gspca_dev *gspca_dev);
static void setsaturation(struct
Hi,
here are a couple more of controls for the gspca ov534 subdriver.
In order to control the HUE value the sensor expects sin(HUE) and
cos(HUE) to be set so I decided to reuse the fixed point implementation
of sine and cosine from drivers/input/fixp-arith.h, see patches 2 and 3.
Dmitry, can
m in the version 2.6.30. I have a problem with the hue,
> when I put the color bars after DSP, the color fo this bars aren't corrects,
> the hue function are same that the ov7670 mainline. any body know anything
> about this topic?
--
To unsubscribe from this list: send the line "u
Hue control doesn't work and the sensor datasheet is not clear about how
to set hue properly.
Signed-off-by: Antonio Ospite
---
linux/drivers/media/video/gspca/ov534.c | 54 ++--
1 file changed, 5 insertions(+), 49 deletions(-)
Index: gspca/linux/drivers/
14 matches
Mail list logo
